From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44601)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dAJk2-0003oG-08
	for guix-patches@gnu.org; Mon, 15 May 2017 13:25:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dAJjy-0001K5-QB
	for guix-patches@gnu.org; Mon, 15 May 2017 13:25:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:44173)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dAJjy-0001Jx-Mz
	for guix-patches@gnu.org; Mon, 15 May 2017 13:25:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dAJjy-0003cD-Gd
	for guix-patches@gnu.org; Mon, 15 May 2017 13:25:02 -0400
Subject: bug#26924: [PATCH 12/12] gnu: calibre: Don't create uninstaller
Resent-Message-ID: <handler.26924.B26924.149486907613861@debbugs.gnu.org>
From: Marius Bakke <mbakke@fastmail.com>
In-Reply-To: <80c772f8-f358-bb0a-8438-03e83fb6be0f@openmailbox.org>
References: <a474bf3a-2be1-5d4a-28d8-0ef3267e29ce@openmailbox.org>
	<80c772f8-f358-bb0a-8438-03e83fb6be0f@openmailbox.org>
Date: Mon, 15 May 2017 19:24:32 +0200
Message-ID: <87o9uudodr.fsf@fastmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Brendan Tildesley <brendan.tildesley@openmailbox.org>, 26924@debbugs.gnu.org

--=-=-=
Content-Type: text/plain

Brendan Tildesley <brendan.tildesley@openmailbox.org> writes:

> From 71da9cd2a9c030748bd537110935f67af2097430 Mon Sep 17 00:00:00 2001
> From: Brendan Tildesley <brendan.tildesley@openmailbox.org>
> Date: Mon, 15 May 2017 00:37:07 +1000
> Subject: [PATCH 12/12] gnu: calibre: Don't create uninstaller
>
> gnu/packages/ebook.scm (calibre). Don't create uninstaller
> ---
>  gnu/packages/ebook.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/ebook.scm b/gnu/packages/ebook.scm
> index 2e5863e6c..131cf77b3 100644
> --- a/gnu/packages/ebook.scm
> +++ b/gnu/packages/ebook.scm
> @@ -84,6 +84,7 @@
>              (delete-file-recursively "resources/fonts/liberation")
>              (delete-file-recursively "src/chardet")
>              (substitute* (find-files "." "\\.py")
> +              (("self\\.create_uninstaller()") "")
>                (("calibre\\.ebooks\\.markdown") "markdown"))))

Can you add a comment about what the uninstaller is, and why we are
removing it?

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlkZ5FAACgkQoqBt8qM6
VPru8ggAqdKxGwOeXaxHNKg/oT5Zik1nvVRnUB1om/ra2TjLJ8tFIm1sSzTUr0Ws
G++y5w5u/vksbtY2ogzCUa8/AGJMcSrDeqgpb3t3+yfwdlOzu5DoVdXOEs51xhOo
QqqD9enAIJZGnW/0mRUK9+RuUHfg9Xm3+7cpqLh1QU8zEQ/tA63Qb1qqISTuM8rL
Ggbo/b7MTHvgAjdREe7/3neN6Xn6+27F46k+rYsTZjqyEUIM3phgBnlUKFEjxCdE
cTEAs7iUTpIwvspYy93xTZ7AiWCVGsVFL2yQ3BLGbHtqlhkEnCRsqSQgrqhHvbmq
CIsIl4gvheWb9QHpCObnwYcg5NDkFQ==
=cWkU
-----END PGP SIGNATURE-----
--=-=-=--