unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 28262-done@debbugs.gnu.org
Subject: [bug#28262] [PATCH] Handle the same HTTP redirects everywhere.
Date: Thu, 07 Sep 2017 11:43:07 +0200	[thread overview]
Message-ID: <87o9qmyhck.fsf@gnu.org> (raw)
In-Reply-To: <59e6850f-250d-6f21-ee49-78da1145b338@tobias.gr> (Tobias Geerinckx-Rice's message of "Tue, 5 Sep 2017 18:21:36 +0200")

Hi,

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

>> As a followup, we should look into merging the two ‘http-fetch’
>> procedures.  I don’t think the initial motivation for having two
>> separate implementations still holds.
>
> I'll push this fix and close this bug, but if you have the time I'd love
> to know more about that initial motivation. The two have grown quite apart.

Initially (guix http-client) existed simply to paper over API changes in
Guile’s (web client) and to work around bugs in older Guile version.
This is because (guix http-client) is used on the “host” side, where we
support(ed) older releases of Guile 2.0.

(guix build download) didn’t really have this constraint because the
Guile used on the “build” side was known, and known to be recent enough
in most cases.  So all it did was to add a higher-level API above what
Guile provides, which follows redirects, etc.

Since 36626c556ed75219bce196ac93d148f6b9af984c we require Guile >=
2.0.9, so some of the bugs/workarounds we had no longer apply and the
separation probably no longer makes sense.

HTH!

Ludo’.

      reply	other threads:[~2017-09-07  9:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-28 13:46 [bug#28262] [PATCH] Handle the same HTTP redirects everywhere Tobias Geerinckx-Rice
2017-08-28 13:52 ` Tobias Geerinckx-Rice
2017-08-31 13:10 ` Ludovic Courtès
2017-09-05 16:21   ` bug#28262: " Tobias Geerinckx-Rice
2017-09-07  9:43     ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9qmyhck.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=28262-done@debbugs.gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).