From: ludo@gnu.org (Ludovic Courtès)
To: Jelle Licht <jlicht@fsfe.org>
Cc: 27553-done@debbugs.gnu.org
Subject: bug#27553: [PATCH shepherd] Register SIGCHLD handler after primitive fork
Date: Thu, 07 Sep 2017 16:49:36 +0200 [thread overview]
Message-ID: <87o9qmtvgf.fsf@gnu.org> (raw)
In-Reply-To: <CAPsKtf+GHDagd9yLTYkSuYUts3tSvr8aE1m1XQ2xidZrQzQMVA@mail.gmail.com> (Jelle Licht's message of "Thu, 7 Sep 2017 00:56:41 +0200")
Heya!
Jelle Licht <jlicht@fsfe.org> skribis:
> I just tested what Ludo' proposed, and it seems to work like a charm.
> Seeing as we might be seeing more non-init shepherd instances w.r.t.
> user services and the possible service extension to `guix environment',
> I think it would be a good call to fix this bug :-).
Indeed, thanks for the reminder.
> From db942182224dfc0accad94897dd2122b128eef07 Mon Sep 17 00:00:00 2001
> From: Jelle Licht <jlicht@fsfe.org>
> Date: Thu, 7 Sep 2017 00:52:49 +0200
> Subject: [PATCH] Lazily register SIGCHLD hander on first call to
> 'fork+exec-command'.
>
> * modules/shepherd.scm (main): Move unconditional top-level call to 'sigaction' to...
> * modules/shepherd/service.scm (fork+exec-command): here. Use new variable.
> (%sigchld-handler-installed?): New variable.
LGTM, applied!
Ludo’.
prev parent reply other threads:[~2017-09-07 14:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-02 1:11 [bug#27553] [PATCH shepherd] Register SIGCHLD handler after primitive fork Jelle Licht
2017-07-12 21:34 ` Ludovic Courtès
2017-07-14 12:19 ` Jelle Licht
2017-07-17 8:33 ` Ludovic Courtès
2017-07-27 14:32 ` Jelle Licht
2017-09-06 22:56 ` Jelle Licht
2017-09-07 14:49 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9qmtvgf.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=27553-done@debbugs.gnu.org \
--cc=jlicht@fsfe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).