unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Stefan Reichör" <stefan@xsteve.at>
To: 28558@debbugs.gnu.org
Subject: [bug#28558] [PATCH] gnu: Add atool.
Date: Sat, 23 Sep 2017 20:16:48 +0200	[thread overview]
Message-ID: <87o9q12sbz.fsf@xsteve.at> (raw)
In-Reply-To: <bb546080-8a63-824e-43a6-24d62abc9c07@uq.edu.au> (Ben Woodcroft's message of "Sat, 23 Sep 2017 18:43:10 +1000")

Hi Ben,

> On 23/09/17 07:49, Stefan Reichör wrote:
>> * gnu/packages/compression.scm (atool): New variable.
> Thanks for the patch. While adding all compression programs supported
> (e.g. tar) as inputs is probably too much given their large number, I
> think it would be good to add "file" and patch in the path to "file"
> in bin/atool. WDYT?

Thanks for your feedback. I don't think that file is an important tool
for atool. At least I use only archives with the correct file extension.
And all the archives that I remember that I downloaded from some site
also provided the correct file extension. In that case file is not needed to
detect the archive type.

However, if you think that hard coding the full path to file is a good
thing I will update my patch. It should be doable for me...

> Otherwise LGTM.
> ben


Stefan.

  reply	other threads:[~2017-09-23 18:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-22 21:49 [bug#28558] [PATCH] gnu: Add atool Stefan Reichör
2017-09-23  8:43 ` Ben Woodcroft
2017-09-23 18:16   ` Stefan Reichör [this message]
2017-10-07 20:47     ` Ludovic Courtès
2017-10-08  9:25       ` Stefan Reichör
2017-10-18 21:10         ` bug#28558: " Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9q12sbz.fsf@xsteve.at \
    --to=stefan@xsteve.at \
    --cc=28558@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).