[bug#29112] [PATCH 0/3] GDM patches

[bug#29112] [PATCH 0/3] GDM patches

[Timothy Sample]

Hi,

These patches make GDM semi-functional (cf. [1] for all the details).

Note that this will not work in QEMU with the default “-vga std”. I’ve
been using “-vga qxl” (other options may or may not work).


-- Tim

[1] https://lists.gnu.org/archive/html/guix-devel/2017-10/msg00231.html

[bug#29112] [PATCH 1/3] gnu: gdm: Fix config file path.

[Timothy Sample]

* gnu/packages/gnome.scm (gdm)[arguments]<#:phases>: Fix the
'pre-configure phase so that GDM finds its config file.
---
 gnu/packages/gnome.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index ecfd63d25..ef52871c8 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5287,9 +5287,9 @@ libxml2.")
                 "    \"/run/current-system/profile/etc/xdg\");\n"
                 )))
             ;; Look for custom GDM conf in /run/current-system.
-            (substitute* '("common/gdm-settings-backend.c")
+            (substitute* '("common/gdm-settings-desktop-backend.c")
               (("GDM_CUSTOM_CONF")
-               "/run/current-system/etc/gdm/custom.conf"))
+               "\"/run/current-system/etc/gdm/custom.conf\""))
             ;; Use service-supplied path to X.
             (substitute* '("daemon/gdm-server.c")
               (("\\(X_SERVER X_SERVER_ARG_FORMAT")
-- 
2.14.3

[bug#29112] [PATCH 1/3] gnu: gdm: Fix config file path.

[Ludovic Courtès]

Timothy Sample <samplet@ngyro.com> skribis:

> * gnu/packages/gnome.scm (gdm)[arguments]<#:phases>: Fix the
> 'pre-configure phase so that GDM finds its config file.

Applied, thanks!

[bug#29112] [PATCH 2/3] gnu: gdm: Add configure flags for better defaults.

[Timothy Sample]

Using --with-initial-vt=7 allows GDM to run alongside TTY 1, instead of
having to replace it (i.e., stopping the mingetty service for TTY 1
before starting GDM).

By default, GDM expects distributions to install a custom Xsession
script. It provides a generic one if --enable-gdm-xsession is set.

* gnu/packages/gnome.scm (gdm)[arguments]<#:configure-flags>: Add
--with-initial-vt=7 and --enable-gdm-xsession.
---
 gnu/packages/gnome.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index ef52871c8..d8e4cd418 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5223,6 +5223,8 @@ libxml2.")
      '(#:configure-flags
        `("--without-plymouth"
          "--disable-systemd-journal"
+         "--with-initial-vt=7"
+         "--enable-gdm-xsession"
          "--localstatedir=/var"
          ,(string-append "--with-default-path="
                          (string-join '("/run/setuid-programs"
-- 
2.14.3

[bug#29112] [PATCH 2/3] gnu: gdm: Add configure flags for better defaults.

[Ludovic Courtès]

Timothy Sample <samplet@ngyro.com> skribis:

> Using --with-initial-vt=7 allows GDM to run alongside TTY 1, instead of
> having to replace it (i.e., stopping the mingetty service for TTY 1
> before starting GDM).
>
> By default, GDM expects distributions to install a custom Xsession
> script. It provides a generic one if --enable-gdm-xsession is set.
>
> * gnu/packages/gnome.scm (gdm)[arguments]<#:configure-flags>: Add
> --with-initial-vt=7 and --enable-gdm-xsession.

I moved the explanations as comments in the code and committed.

Thanks,
Ludo'.

[bug#29112] [PATCH 3/3] services: gdm: Add environment variables.

[Timothy Sample]

While not an optimal solution (see comment), this makes GDM functional.

* gnu/services/xorg.scm (gdm-shepherd-service): Set PATH and XDG_DATA_DIRS
environment variables.
---
 gnu/services/xorg.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm
index 6200fa302..c5a1a0d42 100644
--- a/gnu/services/xorg.scm
+++ b/gnu/services/xorg.scm
@@ -573,7 +573,14 @@ makes the good ol' XlockMore usable."
                      #:environment-variables
                      (list (string-append
                             "GDM_X_SERVER="
-                            #$(gdm-configuration-x-server config))))))
+                            #$(gdm-configuration-x-server config))
+                           ;; XXX: GDM requires access to a handful of
+                           ;; programs and components from Gnome (gnome-shell,
+                           ;; dbus, and gnome-session among others). The
+                           ;; following variables only work provided Gnome is
+                           ;; installed.
+                           "XDG_DATA_DIRS=/run/current-system/profile/share"
+                           "PATH=/run/current-system/profile/bin"))))
          (stop #~(make-kill-destructor))
          (respawn? #t))))
 
-- 
2.14.3

bug#29112: [PATCH 3/3] services: gdm: Add environment variables.

[Ludovic Courtès]

Timothy Sample <timsample@gmail.com> skribis:

> While not an optimal solution (see comment), this makes GDM functional.
>
> * gnu/services/xorg.scm (gdm-shepherd-service): Set PATH and XDG_DATA_DIRS
> environment variables.

Awesome, thank you for these patches!

Ludo’.