From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54006)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eZzz7-0007ij-VE
	for guix-patches@gnu.org; Fri, 12 Jan 2018 09:07:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eZzz4-0003EK-MC
	for guix-patches@gnu.org; Fri, 12 Jan 2018 09:07:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:45133)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eZzz4-0003E9-I9
	for guix-patches@gnu.org; Fri, 12 Jan 2018 09:07:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eZzz4-00075Y-Cd
	for guix-patches@gnu.org; Fri, 12 Jan 2018 09:07:02 -0500
Subject: [bug#29932] [PATCH v2 2/2] system: Rename
	operating-system-user-kernel-arguments to
	operating-system-kernel-arguments.
Resent-Message-ID: <handler.29932.B29932.151576600627226@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180112105953.7198-1-dannym@scratchpost.org>
	<20180112110147.7305-1-dannym@scratchpost.org>
Date: Fri, 12 Jan 2018 15:06:42 +0100
In-Reply-To: <20180112110147.7305-1-dannym@scratchpost.org> (Danny
	Milosavljevic's message of "Fri, 12 Jan 2018 12:01:47 +0100")
Message-ID: <87o9lzqih9.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 29932@debbugs.gnu.org

Hi,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * gnu/system.scm (operating-system-user-kernel-arguments): Rename to...
> (operating-system-kernel-arguments): ... this.
> <operating-system>: Adapt to new name.
> (operating-system-boot-parameters): Adapt to new name.
> * gnu/system/vm.scm (system-qemu-image/shared-store-script): Adapt to new=
 name.
> * gnu/tests.scm (marionette-operating-system): Adapt to new name.
> ---
>  gnu/system.scm    | 6 +++---
>  gnu/system/vm.scm | 2 +-
>  gnu/tests.scm     | 2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/system.scm b/gnu/system.scm
> index 51f45f6ac..92b3e2959 100644
> --- a/gnu/system.scm
> +++ b/gnu/system.scm
> @@ -74,7 +74,7 @@
>              operating-system-kernel
>              operating-system-kernel-file
>              operating-system-boot-kernel-arguments
> -            operating-system-user-kernel-arguments
> +            operating-system-kernel-arguments

I=E2=80=99m a bit lost: in my tree I don=E2=80=99t have
=E2=80=98operating-system-boot-kernel-arguments=E2=80=99.  Is it still pend=
ing?

Otherwise my only question is whether it=E2=80=99s a good idea to move away=
 from
the =E2=80=98user-=E2=80=99 convention.  On one hand, it=E2=80=99s the conv=
ention we also have
for services (=E2=80=98-user-services=E2=80=99 vs. =E2=80=98-services=E2=80=
=99), so it would be a good
thing to remain consistent.  OTOH, what you propose is maybe clearer.

Thoughts?

Thanks,
Ludo=E2=80=99.