From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46604)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ecgSb-0001g5-LZ
	for guix-patches@gnu.org; Fri, 19 Jan 2018 18:53:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ecgS2-0007Wc-EZ
	for guix-patches@gnu.org; Fri, 19 Jan 2018 18:52:37 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:55701)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ecgS2-0007WA-79
	for guix-patches@gnu.org; Fri, 19 Jan 2018 18:52:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ecgS1-0004Ag-Rz
	for guix-patches@gnu.org; Fri, 19 Jan 2018 18:52:01 -0500
Subject: [bug#29536] [PATCH] gnu: Add cava.
Resent-Message-ID: <handler.29536.B29536.151640591316016@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <87efocor8u.fsf@gmail.com>
	<20171202220708.cg6xnqca7ovul5ng@abyayala> <87wp24uux2.fsf@gmail.com>
Date: Sat, 20 Jan 2018 00:51:46 +0100
In-Reply-To: <87wp24uux2.fsf@gmail.com> (Oleg Pykhalov's message of "Sun, 03
	Dec 2017 10:34:17 +0300")
Message-ID: <87o9lph0fh.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 29536@debbugs.gnu.org, ng0 <ng0@n0.is>

Heya Oleg,

Oleg Pykhalov <go.wigust@gmail.com> skribis:

>>>From af48537fc5c6af11993db03004a937251d8d60e9 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust@gmail.com>
> Date: Sat, 2 Dec 2017 22:36:36 +0300
> Subject: [PATCH] gnu: Add cava.
>
> * gnu/packages/audio.scm (cava): New variable.

[...]

> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'bootstrap
> +           (lambda _
> +             (setenv "HOME" (getcwd))
> +             (zero? (system* "sh" "autogen.sh"))))

Please use =E2=80=98invoke=E2=80=99 instead of =E2=80=98system*=E2=80=99.

> +         (add-before 'build 'make-cava-ldflags
> +           (lambda _ (mkdir-p (string-append (assoc-ref %outputs "out") =
"/lib"))))

Please use:

  (lambda* (#:key outputs #:allow-other-keys)
    =E2=80=A6 outputs =E2=80=A6)

> +         (add-after 'install 'data
> +           (lambda _ (for-each (lambda (file)
> +                            (install-file file (string-append
> +                                                (assoc-ref %outputs "out=
")
> +                                                "/share/doc/examples")))
> +                          (find-files "example_files")))))))

Likewise.

> +    (home-page "https://karlstav.github.io/cava/")
> +    (synopsis "CLI audio visualizer for Alsa, MPD and Pulseaudio")

Rather: =E2=80=9CConsole audio visualizer for ALSA, MPD, and PulseAudio=E2=
=80=9D.

> +    (description "@code{cava} provides a command line audio visualizer f=
or
> +MPD, Alsa and Pulseaudio.")

Based on their README:

  C.A.V.A. is a bar audio spectrum visualizer for the terminal using
  ALSA, MPD, PulseAudio, or a FIFO buffer as its input.

OK with these changes, thank you!

Ludo=E2=80=99.