From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40696)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1f5dWH-0000hY-K6
	for guix-patches@gnu.org; Mon, 09 Apr 2018 16:36:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1f5dWE-0000n1-G7
	for guix-patches@gnu.org; Mon, 09 Apr 2018 16:36:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:36399)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1f5dWE-0000mt-BP
	for guix-patches@gnu.org; Mon, 09 Apr 2018 16:36:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1f5dWE-0008VJ-5E
	for guix-patches@gnu.org; Mon, 09 Apr 2018 16:36:02 -0400
Subject: [bug#31087] [PATCH] gnu: Add libcgroup.
Resent-Message-ID: <handler.31087.B31087.152330615032672@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180407112125.18650-1-sleep_walker@gnu.org>
	<20180407151724.11382-1-sleep_walker@gnu.org>
Date: Mon, 09 Apr 2018 22:35:45 +0200
In-Reply-To: <20180407151724.11382-1-sleep_walker@gnu.org>
	("=?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?="'s
	message of "Sat, 7 Apr 2018 17:17:24 +0200")
Message-ID: <87o9isglsu.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= <sleep_walker@gnu.org>
Cc: 31087@debbugs.gnu.org

Hello,

Tom=C3=A1=C5=A1 =C4=8Cech <sleep_walker@gnu.org> skribis:

>  * gnu/packages/linux.scm (libcgroup): New variable.

[...]

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         ;; tests try to mount cgroup filesystem and fails because it se=
ems it
> +         ;; can't be mounted twice
> +         ;; let's disable it
> +         (delete 'check))))

Simply write #:tests? #f.

> +    (native-inputs
> +     `(("bison" ,bison)
> +       ("flex" ,flex)
> +       ("linux-pam" ,linux-pam)))

Should =E2=80=98linux-pam=E2=80=99 be in =E2=80=98inputs=E2=80=99 rather th=
an =E2=80=98native-inputs=E2=80=99?

Otherwise LGTM, thanks!

Ludo=E2=80=99.