From: ludo@gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 32165@debbugs.gnu.org
Subject: [bug#32165] [PATCH] gnu: Add cdrkit-libre.
Date: Tue, 24 Jul 2018 10:38:57 +0200 [thread overview]
Message-ID: <87o9ex58pq.fsf@gnu.org> (raw)
In-Reply-To: <20180715170748.4853-1-go.wigust@gmail.com> (Oleg Pykhalov's message of "Sun, 15 Jul 2018 20:07:48 +0300")
Hi Oleg,
Oleg Pykhalov <go.wigust@gmail.com> skribis:
> * gnu/packages/cdrom.scm (cdrkit-libre): New variable.
[...]
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://repo.parabola.nu/other/cdrkit-libre/cdrkit-libre-"
> + version ".tar.gz"))
Like Nils I wonder: can you explain how it differs from cdrkit? Could
we use upstream cdrkit + snippet/patches instead of taking the source
from Parabola’s repo?
> + (build-system cmake-build-system)
> + (native-inputs
> + `(("bzip2" ,bzip2)
> + ("libcap" ,libcap)
> + ("perl" ,perl)
> + ("zlib" ,zlib)))
It may be that all of these should be ‘inputs’. Could you check:
guix gc --references $(guix build cdrkit-libre)
? If they show up here, then ‘inputs’.
> + (arguments
> + `(#:tests? #f ;no tests
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'install 'old-cdrecord
> + (lambda* (#:key outputs #:allow-other-keys)
> + (with-directory-excursion (string-append (assoc-ref outputs "out")
> + "/bin")
> + (symlink "genisoimage" "mkisofs")
> + (symlink "wodim" "cdrecord")))))))
Please return #t.
> + (home-page "http://cdrkit.org/")
Like Nils wrote, is this the right URL?
> + (synopsis "Portable command-line CD/DVD recorder software, mostly
> +compatible with cdrtools")
“Command-line CD/DVD recorder” is enough IMO.
> + (description "Cdrkit is a suite of programs for recording CDs and DVDs,
> +blanking CD-RW media, creating ISO-9660 filesystem images, extracting audio CD
> +data, and more.")
Here you can mention that it’s “mostly compatible …”.
Note: “file system” (two words). :-)
Thanks,
Ludo’.
next prev parent reply other threads:[~2018-07-24 8:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-15 17:07 [bug#32165] [PATCH] gnu: Add cdrkit-libre Oleg Pykhalov
2018-07-15 22:39 ` Nils Gillmann
2018-07-25 12:35 ` Oleg Pykhalov
2018-07-25 13:15 ` Nils Gillmann
2018-07-24 8:38 ` Ludovic Courtès [this message]
2018-07-25 12:26 ` Oleg Pykhalov
2018-07-25 13:23 ` Nils Gillmann
2018-07-26 8:56 ` Ludovic Courtès
2018-08-01 16:33 ` bug#32165: " Oleg Pykhalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9ex58pq.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=32165@debbugs.gnu.org \
--cc=go.wigust@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).