From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:37746) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giGcl-0006CO-2a for guix-patches@gnu.org; Sat, 12 Jan 2019 05:34:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1giGUM-0007Jj-Dv for guix-patches@gnu.org; Sat, 12 Jan 2019 05:26:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:57256) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1giGUM-0007JW-Ag for guix-patches@gnu.org; Sat, 12 Jan 2019 05:26:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1giGUM-00085D-4b for guix-patches@gnu.org; Sat, 12 Jan 2019 05:26:02 -0500 Subject: [bug#33920] [PATCH] gnu: Add gauche. Resent-Message-ID: References: <875zvbjvxv.fsf@gmail.com> <8709180406da2b2eabffd1b4397a2bf3@riseup.net> <87muof8pyk.fsf@gmail.com> <87sgy14yg2.fsf@gnu.org> From: Gabriel Hondet In-reply-to: <87sgy14yg2.fsf@gnu.org> Date: Sat, 12 Jan 2019 11:25:26 +0100 Message-ID: <87o98m8961.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 33920@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludovic, On Wed 09 Jan 2019 at 16:56 Ludovic Court=C3=A8s wrote: > As swedebugia noted, Gauche uses libgc and libatomic-ops. Could you > try to add these two libraries as inputs and to adjust the package to > make sure it does not use the bundled copies? Sure I'll work on it. >> +(define-public gauche >> + (package >> + (name "gauche") >> + (version "0.9.7") >> + (home-page "http://practical-scheme.net/gauche/index.html") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (string-append >> + "http://prdownloads.sourceforge.net/gauche/Gauche-" >> + version ".tgz")) > > Please use mirror://sourceforge here. As far as I understand, I should use "mirror://sourceforge/gauche/Gauche-" but it does not work (redirections fail with a 404 not found error). >> + `(#:phases >> + (modify-phases %standard-phases >> + (add-after 'unpack 'patch-/bin/sh >> + ;; needed only for tests >> + (lambda _ >> + (begin >> + (setenv "CONFIG_SHELL" (which "sh")) >> + (substitute* '("configure" >> + "test/www.scm" >> + "config.guess" >> + "ltmain.sh" >> + "ext/tls/test.scm" >> + "gc/configure" >> + "lib/gauche/configure.scm" >> + "lib/gauche/package/util.scm" >> + "lib/gauche/process.scm") >> + (("/bin/sh") (which "sh"))) > > This looks redundant with what the standard =E2=80=98patch-source-shebang= s=E2=80=99 and > =E2=80=98configure=E2=80=99 phases do, no? Isn't 'patch-source-shebangs' only patching the shebangs? Because here I have to patch other path specifications in the source as well. On the other hand, for the 'setenv', you are totally right. > Out of curiosity, do these tests rely on specific host name lookups or > external services? I'll look at it. Thank you for these useful and essential tips, Gabriel --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE5ercJXBcjd3P1FcAMbyBBfZZ1CUFAlw5wJYACgkQMbyBBfZZ 1CXflxAAnpMMYwgLOkJjwIV5EB3uJa1fjJ5V9fx5MK+fJwLko4ewX1j/S0sI3uCw 0KNxIc57I/Vb9kPMwCkLcpoGrcpppOoTzxeiionmPoRdX+CwwIvBDsDh5p0EAUXy 43cIGVQvakTGwTKyBGzw0UI7ItGVM1Z4dTWH6e1A8wqEVeIIR6qaCgcX0WpQ57zm 9HGssIrle8omfdBaAuE/v+wxbJfIxSlxUUzquw5VztPoqbEZjFWhRfqxik32cjCR vkujnWr7DylzLUGjYZwph6Gfnyc2zH/P6xrESBwCNSvXKVa4ROxXX47ZPWtLtiBY S52Z5Vx2d5Dt7rSnuP0v33oH89V7XKHr5z4MgpkjXlVF8FDcyufQTMQMB3nXQ2Vd 9w5bYi0gw3cFL5kE9JiqTgDnwCQLQbSqWaTgqu1z+HZ4oGQ0xttDfUKlO9aqqlWI //+LDs9TAYLwwGVdxI9qsESZxaSwxEiIa/GaZYM3M5os86N822SBpI+CFJbBAlcL 5l2wtNaBmZN+6fHn2q9dt2KLFu3USdxNl4o9R3pOEGmhuU/Ev6/AZUQ0CheBFARO LLHbO6AZrZKgZiDrgUNJp7ejOgvlT+NUtV3duav7SduhLC7yb++oD+4iqTqsBjB7 e7C46nc3kQfYX+8MxkhL57gWnkQR7sdlrFJ0cAAcOkjqqdfxbtM= =qCaJ -----END PGP SIGNATURE----- --=-=-=--