From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:52599)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gmDfj-0000ah-01
	for guix-patches@gnu.org; Wed, 23 Jan 2019 03:14:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gmDfh-00084N-83
	for guix-patches@gnu.org; Wed, 23 Jan 2019 03:14:06 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:42691)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gmDfe-00082s-Cs
	for guix-patches@gnu.org; Wed, 23 Jan 2019 03:14:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gmDfe-00058n-5D
	for guix-patches@gnu.org; Wed, 23 Jan 2019 03:14:02 -0500
Subject: [bug#34175] [PATCH 4/4] gnu: Add efilinux.
Resent-Message-ID: <handler.34175.B34175.154823123419742@debbugs.gnu.org>
References: <20190123000035.11320-1-dannym@scratchpost.org>
	<20190123000304.11385-1-dannym@scratchpost.org>
	<20190123000304.11385-4-dannym@scratchpost.org>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20190123000304.11385-4-dannym@scratchpost.org>
Date: Wed, 23 Jan 2019 09:12:08 +0100
Message-ID: <87o9877pyf.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 34175@debbugs.gnu.org


Danny Milosavljevic <dannym@scratchpost.org> writes:

> * gnu/packages/efi.scm (efilinux): New variable.
[=E2=80=A6]
> +    (arguments
> +     `(#:make-flags
> +       (list "CC=3Dgcc"
> +             (string-append "INCDIR=3D" (assoc-ref %build-inputs "gnu-ef=
i")
> +                            "/include")
> +             (string-append "LIBDIR=3D" (assoc-ref %build-inputs "gnu-ef=
i")
> +                            "/lib"))

Nitpick: I=E2=80=99d use a let binding for (assoc-ref %build-inputs "gnu-ef=
i").

> +       #:tests? #f ; No tests exist.
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (install-file "efilinux.efi"
> +                           (string-append (assoc-ref outputs "out")
> +                           "/libexec"))

The indentation of "/libexec" is off.

Otherwise LGTM.

--=20
Ricardo