From: Ricardo Wurmus <rekado@elephly.net>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 34175@debbugs.gnu.org
Subject: [bug#34175] [PATCH 4/4] gnu: Add efilinux.
Date: Wed, 23 Jan 2019 09:12:08 +0100 [thread overview]
Message-ID: <87o9877pyf.fsf@elephly.net> (raw)
In-Reply-To: <20190123000304.11385-4-dannym@scratchpost.org>
Danny Milosavljevic <dannym@scratchpost.org> writes:
> * gnu/packages/efi.scm (efilinux): New variable.
[…]
> + (arguments
> + `(#:make-flags
> + (list "CC=gcc"
> + (string-append "INCDIR=" (assoc-ref %build-inputs "gnu-efi")
> + "/include")
> + (string-append "LIBDIR=" (assoc-ref %build-inputs "gnu-efi")
> + "/lib"))
Nitpick: I’d use a let binding for (assoc-ref %build-inputs "gnu-efi").
> + #:tests? #f ; No tests exist.
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure)
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (install-file "efilinux.efi"
> + (string-append (assoc-ref outputs "out")
> + "/libexec"))
The indentation of "/libexec" is off.
Otherwise LGTM.
--
Ricardo
next prev parent reply other threads:[~2019-01-23 8:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 0:00 [bug#34175] [PATCH 0/4] Add EFI tools Danny Milosavljevic
2019-01-23 0:03 ` [bug#34175] [PATCH 1/4] gnu: Add gnu-efi Danny Milosavljevic
2019-01-23 0:03 ` [bug#34175] [PATCH 2/4] gnu: Add sbsigntools Danny Milosavljevic
2019-01-23 8:08 ` Ricardo Wurmus
2019-01-23 14:09 ` Danny Milosavljevic
2019-01-23 0:03 ` [bug#34175] [PATCH 3/4] gnu: Add efitools Danny Milosavljevic
2019-01-23 8:09 ` Ricardo Wurmus
2019-01-23 0:03 ` [bug#34175] [PATCH 4/4] gnu: Add efilinux Danny Milosavljevic
2019-01-23 8:12 ` Ricardo Wurmus [this message]
2019-01-23 8:05 ` [bug#34175] [PATCH 1/4] gnu: Add gnu-efi Ricardo Wurmus
2019-01-25 17:48 ` Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9877pyf.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=34175@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).