Hello again,

Ricardo Wurmus <rekado@elephly.net> writes:

>> +    (source (origin
>> +              (method hg-fetch)
>> +              (uri (hg-reference
>> +                    (url "https://hg.hedgewars.org/hedgewars/")
>> +                    (changeset (string-append version "-release"))))
>
> Is there no release tarball?

Oops. There is! I missed it the first time I looked at the tarballs, and
thought they only provided binaries and pointed to distributions
packages. Well, anyway, here it is.

>> +         (add-after 'unpack 'remove-failing-test
>> +           ;; XXX: Remove single failing test.
>> +           (lambda _
>> +             (delete-file "tests/lua/staticmines.lua")
>> +             #t))
>
> Do you know why it fails?  Is this an upstream problem or likely
> something to do with Guix?

I tried to make the tests more verbose, but I didn't succeed. Note that
it is a test in a "non-critical" directory. I assume this failure is
expected, somehow.
>
>> +         (add-after 'unpack 'fix-compiler
>> +           ;; XXX: Flag BUILD_ENGINE_C, as set above, implies using Clang to
>> +           ;; compile files.  However, using `clang' globally leads to the
>> +           ;; following issue:
>> +           ;; "qtbase-5.11.3/include/qt5/QtCore/qglobal.h:45:12: fatal error:
>> +           ;; 'type_traits' file not found".
>
> Is it really necessary to compile with Clang at all?  What happens if
> you compile with GCC?

The configure script yells at me as Clang is missing. If I eschew the
check in the CMakeLists.txt file, compilation halts with an error. Long
story short, I don't think we can build it without both clang and gcc.
>
>> +    (inputs
>> +     `(("clang" ,clang)
>
> Is this not actually a native input?

Indeed.

>> +       ("ghc" ,ghc)
>
> I think this also might be a native input.

OK.

>> +    (synopsis "Funny turn-based artillery game, featuring fighting hedgehogs!")
>
> Please remove the final exclamation point and the comma.  Maybe remove
> “Funny” because that’s subjective, but feel free to ignore me.

OK. I simply copied the description from the FSF directory.

> The description is a bit long.  We don’t need a list of weapons or the
> rules of the game (“dies when it enters the water”).  Could you try to
> shorten it and make sure that the first sentence describes what this is
> all about?

OK. Here is an update, taken from FSF directory. I also fixed a typo in
a license. Let me know if it is better now.

> Thanks for packaging it!

Thank you for the review.

Regards,

-- 
Nicolas Goaziou