From: Timothy Sample <samplet@ngyro.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 35930@debbugs.gnu.org, Robert Vollmert <rob@vllmrt.net>
Subject: [bug#35930] haskell Setup.hs-related changes
Date: Thu, 13 Jun 2019 11:57:01 -0400 [thread overview]
Message-ID: <87o9314gxe.fsf@ngyro.com> (raw)
In-Reply-To: <875zp97ugs.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 13 Jun 2019 10:36:19 +0200")
Hi!
Ludovic Courtès <ludo@gnu.org> writes:
> Hi Robert,
>
> Robert Vollmert <rob@vllmrt.net> skribis:
>
>> This primarily moves the substitution of missing Setup.hs files to
>> haskell-build-system. There was already duplicate code in a number
>> of packages to generated boilerplate Setup.hs, and I ran into a
>> couple more while trying to import some other packages.
>
> This looks like a welcome and harmless factorization; Timothy, Ricardo:
> WDYT?
>
> https://issues.guix.gnu.org/issue/35930
The first patch breaks “ghc-easyplot”.
I’m currently building some packages to test the other patches, and if
everything builds fine, they LGTM with some minor tweaks (which I’ve
already made). Should I push it to master or staging? It means
rebuilding all of our Haskell packages, which is a few hundered
packages.
Robert, do you know why the first patch doesn’t work? Should I just
omit it?
-- Tim
next prev parent reply other threads:[~2019-06-13 15:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 19:52 [bug#35930] haskell Setup.hs-related changes Robert Vollmert
2019-05-27 19:52 ` [bug#35934] [PATCH 1/4] gnu: ghc-easy-plot: remove superfluous Setup.hs rename step Robert Vollmert
2019-05-27 19:52 ` [bug#35931] [PATCH 2/4] guix: haskell-build-system: correct haddock phase documentation Robert Vollmert
2019-05-27 19:52 ` [bug#35932] [PATCH 3/4] guix: haskell-build-system: generate Setup.hs if not exists Robert Vollmert
2019-05-27 19:52 ` [bug#35933] [PATCH 4/4] gnu: haskell: leave Setup.hs generation to build system Robert Vollmert
2019-05-27 19:56 ` [bug#35930] [PATCH 1/4] gnu: ghc-easy-plot: remove superfluous Setup.hs rename step Robert Vollmert
2019-05-27 19:56 ` [bug#35930] [PATCH 2/4] guix: haskell-build-system: correct haddock phase documentation Robert Vollmert
2019-05-27 19:56 ` [bug#35930] [PATCH 3/4] guix: haskell-build-system: generate Setup.hs if not exists Robert Vollmert
2019-05-27 19:56 ` [bug#35930] [PATCH 4/4] gnu: haskell: leave Setup.hs generation to build system Robert Vollmert
2019-06-13 8:36 ` [bug#35930] haskell Setup.hs-related changes Ludovic Courtès
2019-06-13 15:57 ` Timothy Sample [this message]
2019-06-13 16:20 ` Robert Vollmert
2019-06-14 3:05 ` bug#35930: " Timothy Sample
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9314gxe.fsf@ngyro.com \
--to=samplet@ngyro.com \
--cc=35930@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=rob@vllmrt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).