From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:42011) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iTtbz-0000aC-CS for guix-patches@gnu.org; Sun, 10 Nov 2019 15:15:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iTtby-0006Or-8e for guix-patches@gnu.org; Sun, 10 Nov 2019 15:15:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:43733) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iTtbx-0006Oj-Vj for guix-patches@gnu.org; Sun, 10 Nov 2019 15:15:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iTtbx-0002KU-Na for guix-patches@gnu.org; Sun, 10 Nov 2019 15:15:01 -0500 Subject: [bug#38103] Dracula emacs theme Resent-Message-ID: From: Marius Bakke In-Reply-To: <87a795xbc6.fsf@thinkpad.i-did-not-set--mail-host-address--so-tickle-me> References: <87r22j4vvs.fsf@smtp.gmail.com> <87a795xbc6.fsf@thinkpad.i-did-not-set--mail-host-address--so-tickle-me> Date: Sun, 10 Nov 2019 21:14:09 +0100 Message-ID: <87o8xjlca6.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: bluekeys@bluekeys.eu, 38103@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable bluekeys@bluekeys.eu writes: > Hi, > > Second attempt to attach the patch.=20 Looks good! [...] =20=20 > +(define-public emacs-dracula-theme > + (package > + (name "emacs-dracula-theme") > + (version (git-version "0" "0" "320cc8cfc67e33c86045ef3e79b7627b91b9b= 517")) > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/dracula/emacs.git") > + (commit "320cc8cfc67e33c86045ef3e79b7627b91b9b517"))) Could add a (let (commit ...)) binding for the commit hash so we don't have to repeat it twice? See the surrounding packages for examples. Please also add a 'file-name' field here. > + (sha256 > + (base32 > + "0pzlwxsa823sbcf2nq2lw303cld2jc2siaaiafld0qc4xasg9zyn")))) > + (build-system emacs-build-system) > + (home-page "https://draculatheme.com/emacs") > + (synopsis "A dark theme for emacs") Just "Dark theme for Emacs", to appease 'guix lint emacs-dracula-theme'. > + (description > + "A dark theme for emacs and 50+ apps") Can you expand a bit on the "50+ apps" part? Perhaps something along the lines of "Dracula is a dark color theme implemented for more than 50 different applications. This package provides the Emacs theme." Can you send an updated patch? Thanks, and welcome! :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl3Ib5EACgkQoqBt8qM6 VPq/uwf9F2J+lQ9f10v/HNg2NP4t5wFUxjIrgL0ewn3VjuahxsBHNRO36LFypfvD GREBw/zog6RYORTd2S6UJZQfrIyMQth/A11+sZu0ELZrqQCVuf1vquiU0OfS9sU+ NC2fbswte7es8MmwIhcXdb1FBaRdeJFWOK/Ah6GKx6QoxhMkzZCOHU/jfXk05J/s +tszGIRkkPPyqYu+liokW/g51Zlu2vPhl9L2b2u/YOkhjbES5m6tygrveI5YI3qM ICMHDTtjS5Yr95ef4tJp/FJ6ieEoQtLkca6cTHsveMjKMALVmPA1nOM2pZMKL7tB K433wDOBXjUUdyJniUKzTFgY+sR8MQ== =FPJj -----END PGP SIGNATURE----- --=-=-=--