From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QPiFCmgU0l7wOQAA0tVLHw (envelope-from ) for ; Sat, 30 May 2020 08:08:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id SE5KBmgU0l4VeQAAB5/wlQ (envelope-from ) for ; Sat, 30 May 2020 08:08:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9A7799400EF for ; Sat, 30 May 2020 08:08:07 +0000 (UTC) Received: from localhost ([::1]:48224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jewXG-0007Zl-Ky for larch@yhetil.org; Sat, 30 May 2020 04:08:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jewXC-0007ZT-P4 for guix-patches@gnu.org; Sat, 30 May 2020 04:08:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45362) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jewXC-0003H7-Fl for guix-patches@gnu.org; Sat, 30 May 2020 04:08:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jewXC-0008OF-AY for guix-patches@gnu.org; Sat, 30 May 2020 04:08:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41562] use consistent arguments. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 30 May 2020 08:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41562 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Tom Zander , 41562@debbugs.gnu.org Received: via spool by 41562-submit@debbugs.gnu.org id=B41562.159082604132206 (code B ref 41562); Sat, 30 May 2020 08:08:02 +0000 Received: (at 41562) by debbugs.gnu.org; 30 May 2020 08:07:21 +0000 Received: from localhost ([127.0.0.1]:56908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jewWX-0008NN-5T for submit@debbugs.gnu.org; Sat, 30 May 2020 04:07:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jewWU-0008NA-QW for 41562@debbugs.gnu.org; Sat, 30 May 2020 04:07:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58480) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jewWP-0002z1-09; Sat, 30 May 2020 04:07:13 -0400 Received: from ti0006q161-2604.bb.online.no ([84.202.68.75]:53296 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jewWO-0004q1-3A; Sat, 30 May 2020 04:07:12 -0400 From: Marius Bakke In-Reply-To: <2590775.irdbgypaU6@cherry> References: <5645574.lOV4Wx5bFT@cherry> <3098426.mvXUDI8C0e@cherry> <874kry4g0d.fsf@gnu.org> <2590775.irdbgypaU6@cherry> Date: Sat, 30 May 2020 10:07:09 +0200 Message-ID: <87o8q53kya.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.61 X-TUID: ukZiZyYtPch9 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Tom Zander writes: > On vrijdag 29 mei 2020 22:56:18 CEST Marius Bakke wrote: >> Tom Zander via Guix-patches via writes: >> > As suggested on IRC >> >=20 >> >>From bc9a3faa045579f48804cf42f958409e51cdfbf6 Mon Sep 17 00:00:00 2001 >> >> >> > From: TomZ >> > Date: Wed, 27 May 2020 13:21:58 +0200 >> > Subject: [PATCH] gnu: flowee: Disable unpredictable test. >> >=20 >> > * gnu/packages/finance.scm (flowee): The test 'api' has some timeouts >> >=20 >> > which fail half the time in a build, so disable the test. >>=20 >> Can you move this piece of information to a comment in the code? > > Can you point to the file I find the code in, to add this to? > > In case you mean the package description, its already there. Oh you're right. In that case it would be clearer to change the commit message to something like "really disable the black box tests". >> Also, this should say (flowee)[arguments]: ... >>=20 >> > diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm >> > index f182057bb4..d176ac0660 100644 >> > --- a/gnu/packages/finance.scm >> > +++ b/gnu/packages/finance.scm >> > @@ -1531,7 +1531,7 @@ like Flowee the Hub, which Fulcrum connects to o= ver >> > RPC.")>=20 >> > (base32 >> > "1vwvaxm3b71pfx8l4rrv06wqks6xdf2333w856b36s1bzvj53rhc")))) >> >=20=20=20=20=20=20 >> > (build-system cmake-build-system) >> > (arguments >> >=20 >> > - `(#:configure-flags '("-Dbuild_tests=3DON" "-Denable_gui=3DOFF") >> > + `(#:configure-flags '("-Dbuild_tests=3DON" "-Denable_gui=3DOFF" >> > "-Denable_gui=3DOFF") >> This should probably not be here? > > Why not? I don't think passing -Denable_gui=3DOFF twice makes a difference. Does it? >> > #:phases >> >=20=20=20=20=20=20=20=20=20 >> > (modify-phases %standard-phases >> >=20=20=20=20=20=20=20=20=20=20 >> > (add-before 'configure 'make-qt-deterministic >> >=20 >> > @@ -1546,6 +1546,8 @@ like Flowee the Hub, which Fulcrum connects to o= ver >> > RPC.")>=20 >> > (lambda _ >> >=20=20=20=20=20=20=20=20=20=20=20=20=20=20 >> > (substitute* "testing/CMakeLists.txt" >> >=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 >> > (("test_api") "")) >>=20 >> Can this be removed? It looks like it tries to do the same as your new >> substitution below. > > Same file, two substitutes because there are two lines that need changing= .=20 > CMake blocks for 1) the actual subdir and 2) a build-dependency for 'make- > check' Makes sense, thanks for the explanation. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7SFC0ACgkQoqBt8qM6 VPqvOQf+Jjwp3HCAFL/vUDFgqognlAd8sTnEroOFTp80GOPVoDsIWnBndb2TvtFD 1ZP3gaMDcY/gyYVntQNqBp7JdI8OeFSxWC/BbtInem2OPhZX06ocpFagatrSMv3X CfW+i+jGq15IliDyoaoYtKYy/HbxOkcSTWR+yxdeCO5/A8IlZg4VwpQDsyOhSkhy hZKpgv39fcW1gdQX59sTCvT1OZD88LYJtse8uivj9KyLwqzOqvSDbBczVZqehDPS z40iCfnkZjNyhhnrhNcAlv4JfIvqAqwCy0LpiI3AxbSWN9DtPHdy/V3MJE/4qcim /ST+O3RqTRPB2hmtkZDb2QzmIXIyxg== =H1jA -----END PGP SIGNATURE----- --=-=-=--