From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id AOCAHKF4216pLwAA0tVLHw (envelope-from ) for ; Sat, 06 Jun 2020 11:06:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id WPJbGKF4217ZDAAA1q6Kng (envelope-from ) for ; Sat, 06 Jun 2020 11:06:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AF1F89404C5 for ; Sat, 6 Jun 2020 11:06:08 +0000 (UTC) Received: from localhost ([::1]:46438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhWeN-00051o-EB for larch@yhetil.org; Sat, 06 Jun 2020 07:06:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhWeI-00051h-3Y for guix-patches@gnu.org; Sat, 06 Jun 2020 07:06:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39333) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhWeH-0003ki-QV for guix-patches@gnu.org; Sat, 06 Jun 2020 07:06:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jhWeH-0006av-Lp for guix-patches@gnu.org; Sat, 06 Jun 2020 07:06:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41541] [PATCH 8/8] system: Add `hurd-activation'. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 06 Jun 2020 11:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41541 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: "Jan \(janneke\) Nieuwenhuizen" Cc: 41541@debbugs.gnu.org Received: via spool by 41541-submit@debbugs.gnu.org id=B41541.159144154325285 (code B ref 41541); Sat, 06 Jun 2020 11:06:01 +0000 Received: (at 41541) by debbugs.gnu.org; 6 Jun 2020 11:05:43 +0000 Received: from localhost ([127.0.0.1]:50879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhWdy-0006Zk-MR for submit@debbugs.gnu.org; Sat, 06 Jun 2020 07:05:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhWdx-0006ZN-Ai for 41541@debbugs.gnu.org; Sat, 06 Jun 2020 07:05:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59076) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhWds-0003is-52; Sat, 06 Jun 2020 07:05:36 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=51558 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jhWdr-00044B-7D; Sat, 06 Jun 2020 07:05:35 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200604135914.4499-1-janneke@gnu.org> <20200604135914.4499-9-janneke@gnu.org> Date: Sat, 06 Jun 2020 13:05:34 +0200 In-Reply-To: <20200604135914.4499-9-janneke@gnu.org> (Jan Nieuwenhuizen's message of "Thu, 4 Jun 2020 15:59:14 +0200") Message-ID: <87o8pwv4ht.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: nMswLn/MKOiK "Jan (janneke) Nieuwenhuizen" skribis: > +(define (hurd-activation-script gexps) > + "Return the Hurd activation script, which evaluates GEXPS." > + (define actions > + (map (cut program-file "activate-service.scm" <>) gexps)) > + > + (with-imported-modules (source-module-closure > + '((gnu build activation) > + (guix build utils))) > + #~(begin > + (use-modules (gnu build activation) > + (guix build utils)) > + > + (mkdir-p "/var/run") ;for the PID files > + (mkdir-p "/var/log") > + > + ;; Set up /run/current-system. Among other things this > + ;; sets up locales, which the activation snippets > + ;; executed below may expect. > + (activate-current-system #:kernel-command-line command-line) It seems that =E2=80=98command-line=E2=80=99 is unbound here, no? I was wondering: if the only thing that differs between Linux and Mach is the command line, could we keep the same activation script for both cases, and instead move the conditional to (gnu build activation), like: (if (string-contains %host-type "linux-gnu") linux-command-line mach-command-line) Does that make sense? Thanks, Ludo=E2=80=99.