From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wAsfC96v8165FAAA0tVLHw (envelope-from ) for ; Wed, 24 Jun 2020 19:56:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id wDTIBt6v817AHAAAbx9fmQ (envelope-from ) for ; Wed, 24 Jun 2020 19:56:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8EE949400C1 for ; Wed, 24 Jun 2020 19:56:12 +0000 (UTC) Received: from localhost ([::1]:35760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joBVB-0000dZ-Ut for larch@yhetil.org; Wed, 24 Jun 2020 15:56:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1joBV4-0000cR-Mw for guix-patches@gnu.org; Wed, 24 Jun 2020 15:56:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55852) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1joBV4-0006CE-Ee for guix-patches@gnu.org; Wed, 24 Jun 2020 15:56:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1joBV4-00046P-Dn for guix-patches@gnu.org; Wed, 24 Jun 2020 15:56:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41574] gnu: Add intel-xev. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 24 Jun 2020 19:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41574 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: elaexuotee@wilsonb.com Cc: 41574@debbugs.gnu.org Received: via spool by 41574-submit@debbugs.gnu.org id=B41574.159302852515726 (code B ref 41574); Wed, 24 Jun 2020 19:56:02 +0000 Received: (at 41574) by debbugs.gnu.org; 24 Jun 2020 19:55:25 +0000 Received: from localhost ([127.0.0.1]:39165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joBUP-00045V-O8 for submit@debbugs.gnu.org; Wed, 24 Jun 2020 15:55:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joBUK-00045A-IG for 41574@debbugs.gnu.org; Wed, 24 Jun 2020 15:55:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54519) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joBUF-0005RR-6M; Wed, 24 Jun 2020 15:55:11 -0400 Received: from ti0006q161-3115.bb.online.no ([88.95.106.80]:50316 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1joBU9-0007CG-G0; Wed, 24 Jun 2020 15:55:07 -0400 From: Marius Bakke In-Reply-To: <337PSS1AAVGN7.2MVZ1RZ09WTJA@wilsonb.com> References: <30SSS7KMH7STU.2VZS2NNFF6QOP@wilsonb.com> <338KSVUXDSMM8.2HI3H62CJZAVU@wilsonb.com> <878sgebzbx.fsf@gnu.org> <337PSS1AAVGN7.2MVZ1RZ09WTJA@wilsonb.com> Date: Wed, 24 Jun 2020 21:55:03 +0200 Message-ID: <87o8p86xyg.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.61 X-TUID: K2yFl6Ev2K7z --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable elaexuotee@wilsonb.com writes: > Marius, > > Thanks for taking a look at this. > >> Were these two downgrades intended? I'm assuming no, since the new >> package don't appear to use them. > > Definitely not. Looks like I was sloppy with a local rebase. Thanks for > catching this. OK. >> Does it work to use 'python-wrapper' instead of providing both Python 2 >> and Python 3 here? > > Beautiful; 'python-wrapper' is exactly what I was looking for. Great. >> Is the src output used for other things than documentation? If not, I >> think we can drop it and let users do 'guix build --source intel-xed' >> instead. The description should be modified accordingly. > > Sounds emminently reasonable to me. The new patch still has a "src" output, even though it does not seem to use it. >> Apart from this the package LGTM. Probably it should have: >>=20 >> (supported-systems '("x86_64-linux" "i686-linux")) >>=20 >> too? > > I'm not so sure, actually. The tool and library simply facilitate transla= ting > to/from x86 opcodes, but as far as I can tell it doesn't actually *execut= e* any > architecture-specific instructions. OK. >> Can you add a short description at the top of the patch file explaining >> what it does any why? > > Oh, neat. I didn't know this was possible. Nice job on the comment. :-) >> Can you send an updated patch? Thanks! > > Done! Looks like I missed a couple of things in the first round, sorry about that. Here it comes... > From a90ef5e79d863201d990d607c2926400654bfd9b Mon Sep 17 00:00:00 2001 > From: "B. Wilson" > Date: Thu, 28 May 2020 07:32:28 +0900 > Subject: [PATCH] gnu: Add intel-xed. > To: guix-patches@gnu.org > > * gnu/packages/assembly.scm (intel-xed): New variable. Please also mention the new patch and change to local.mk in the commit message. [...] > +(define-public intel-xed > + (package > + (name "intel-xed") > + (version "11.2.0") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/intelxed/xed.git") > + (commit "40125558530137444b4ee6fd26b445bfa105b543"))) Use the "11.2.0" tag here instead of the commit hash. > + (sha256 (base32 "1jffayski2gpd54vaska7fmiwnnia8v3cka4nfyzjgl8xsky= 9v2s")) > + (file-name (git-file-name name version)) > + (patches (search-patches "intel-xed-fix-nondeterminism.patch")))) > + (build-system gnu-build-system) > + (native-inputs > + `(("python-wrapper" ,python-wrapper) > + ("tcsh" ,tcsh) > + ("mbuild" > + ,(let ((name "mbuild") > + (version "0.2496")) > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/intelxed/mbuild.git") > + (commit "5304b94361fccd830c0e2417535a866b79c1c297"))) > + (sha256 > + (base32 > + "0r3avc3035aklqxcnc14rlmmwpj3jp09vbcbwynhvvmcp8srl7dl")) > + (file-name (git-file-name name version))))))) Can you add a comment about where you got that version number from? Also, would it make sense to package this separately? Can be done later though. > + (outputs '("out" "lib" "src")) As mentioned before, the 'src' output can go. Apart from these minor issues, I think it's good to go. \o/ Can you send an updated patch? TIA! :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7zr5cACgkQoqBt8qM6 VPp37ggAyOAPt8USV0wXsWeqUWpbcmzS98ri6GHhpigX5Kbhq3gE3eSHGFp1XcFq +mY2HzMmiUxpbfBTPHvVAJ4uSTKePzTqefS7b8IDdJ7H+ECVQIFvReaLysu6KmRX RpWRcm7hb97MbBDkubKEOFBo58zndRsbT8cNbP4gq48K1fQeT8IkalM+XiSjGVFQ i2j9fDVgsAJlv8F6qdhyDWjc8PHd97dpm3+PTAwIXrTB4mWmzkPNhImc27vyIb7J Mq7FBeRP8lf2h501ycRnYt9V8ru8al8gH5vTKsv0p6gq5c7mQto26faC6MRE1dsv oQ9RK+038YuFE+08+xAyVBiwL4dKqw== =kbbT -----END PGP SIGNATURE----- --=-=-=--