From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id ICucIpy3J1/VUwAA0tVLHw (envelope-from ) for ; Mon, 03 Aug 2020 07:07:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id KCaEHpy3J19ePQAAbx9fmQ (envelope-from ) for ; Mon, 03 Aug 2020 07:07:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DA88A9404C7 for ; Mon, 3 Aug 2020 07:07:07 +0000 (UTC) Received: from localhost ([::1]:38636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2UYs-00049I-4W for larch@yhetil.org; Mon, 03 Aug 2020 03:07:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2UYo-00047I-EV for guix-patches@gnu.org; Mon, 03 Aug 2020 03:07:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60658) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k2UYo-0003Gi-3A for guix-patches@gnu.org; Mon, 03 Aug 2020 03:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k2UYn-0005cQ-Sr for guix-patches@gnu.org; Mon, 03 Aug 2020 03:07:01 -0400 Subject: bug#42650: [PATCH 2/2] gnu: Add python-onnx. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 03 Aug 2020 07:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 42650 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vinicius Monego Cc: 42650-done@debbugs.gnu.org Mail-Followup-To: 42650@debbugs.gnu.org, othacehe@gnu.org, monego@posteo.net Received: via spool by 42650-done@debbugs.gnu.org id=D42650.159643836121512 (code D ref 42650); Mon, 03 Aug 2020 07:07:01 +0000 Received: (at 42650-done) by debbugs.gnu.org; 3 Aug 2020 07:06:01 +0000 Received: from localhost ([127.0.0.1]:43970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2UXk-0005ak-KU for submit@debbugs.gnu.org; Mon, 03 Aug 2020 03:06:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2UXe-0005aN-HA for 42650-done@debbugs.gnu.org; Mon, 03 Aug 2020 03:05:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35383) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2UXZ-0003Ac-55; Mon, 03 Aug 2020 03:05:45 -0400 Received: from [2a01:cb18:832e:5f00:b06a:601:6fcc:d1cf] (port=51612 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k2UXY-0001Am-Ai; Mon, 03 Aug 2020 03:05:44 -0400 From: Mathieu Othacehe References: <20200801144321.60595-1-monego@posteo.net> <20200801144321.60595-2-monego@posteo.net> Date: Mon, 03 Aug 2020 09:05:40 +0200 In-Reply-To: <20200801144321.60595-2-monego@posteo.net> (Vinicius Monego's message of "Sat, 1 Aug 2020 11:43:21 -0300") Message-ID: <87o8nsus3f.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.49 X-TUID: U99Ih8jkHvKq Hello, A few comments on this one. > * gnu/packages/machine-learning.scm (python-onnx): New variable. You need to mention the added file in the commit message and also add it to gnu/local.mk. > + ;; ONNX will build googletest from a git checkout. Patch CMake > + ;; to use googletest from Guix and enable tests by default. That seems to be a recurrent issue. Did you fix it by yourself or is there a patch out there? Otherwise both patches look fine. I fixed the patch registering thing and pushed. Thanks, Mathieu