From: Mathieu Othacehe <othacehe@gnu.org>
To: Vinicius Monego <monego@posteo.net>
Cc: 42650-done@debbugs.gnu.org
Subject: bug#42650: [PATCH 2/2] gnu: Add python-onnx.
Date: Mon, 03 Aug 2020 09:05:40 +0200 [thread overview]
Message-ID: <87o8nsus3f.fsf@gnu.org> (raw)
In-Reply-To: <20200801144321.60595-2-monego@posteo.net> (Vinicius Monego's message of "Sat, 1 Aug 2020 11:43:21 -0300")
Hello,
A few comments on this one.
> * gnu/packages/machine-learning.scm (python-onnx): New variable.
You need to mention the added file in the commit message and also add it
to gnu/local.mk.
> + ;; ONNX will build googletest from a git checkout. Patch CMake
> + ;; to use googletest from Guix and enable tests by default.
That seems to be a recurrent issue. Did you fix it by yourself or is
there a patch out there?
Otherwise both patches look fine. I fixed the patch registering thing
and pushed.
Thanks,
Mathieu
next prev parent reply other threads:[~2020-08-03 7:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 14:43 [bug#42650] [PATCH 1/2] gnu: python-protobuf: Update to 3.12.4 Vinicius Monego
2020-08-01 14:43 ` [bug#42650] [PATCH 2/2] gnu: Add python-onnx Vinicius Monego
2020-08-03 7:05 ` Mathieu Othacehe [this message]
2020-08-03 12:32 ` Vinicius Monego
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8nsus3f.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=42650-done@debbugs.gnu.org \
--cc=monego@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).