From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2nr5Cwt7Kl/EMgAA0tVLHw (envelope-from ) for ; Wed, 05 Aug 2020 09:25:31 +0000 Received: from aspmx2.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 6E2aBwt7Kl8/YQAA1q6Kng (envelope-from ) for ; Wed, 05 Aug 2020 09:25:31 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx2.migadu.com (Postfix) with ESMTPS id 8B9BA680BC4 for ; Wed, 5 Aug 2020 09:23:03 +0000 (UTC) Received: from localhost ([::1]:60994 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3FcX-0006EN-L2 for larch@yhetil.org; Wed, 05 Aug 2020 05:22:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3FYg-0000MW-8W for guix-patches@gnu.org; Wed, 05 Aug 2020 05:18:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38230) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k3FYf-0003pB-TU for guix-patches@gnu.org; Wed, 05 Aug 2020 05:18:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k3FYf-0004lA-NR for guix-patches@gnu.org; Wed, 05 Aug 2020 05:18:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42682] [PATCH 2/2] gnu: Add qmk-cli. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 05 Aug 2020 09:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42682 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jan Wielkiewicz Cc: 42682@debbugs.gnu.org Received: via spool by 42682-submit@debbugs.gnu.org id=B42682.159661907618285 (code B ref 42682); Wed, 05 Aug 2020 09:18:01 +0000 Received: (at 42682) by debbugs.gnu.org; 5 Aug 2020 09:17:56 +0000 Received: from localhost ([127.0.0.1]:49776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3FYZ-0004kq-VB for submit@debbugs.gnu.org; Wed, 05 Aug 2020 05:17:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3FYX-0004kc-M1 for 42682@debbugs.gnu.org; Wed, 05 Aug 2020 05:17:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52479) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3FYR-0003ob-Mf; Wed, 05 Aug 2020 05:17:47 -0400 Received: from lfbn-ann-1-356-169.w86-200.abo.wanadoo.fr ([86.200.73.169]:36268 helo=meru) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k3FYR-0005Kd-4Z; Wed, 05 Aug 2020 05:17:47 -0400 From: Mathieu Othacehe References: <20200802204910.15356-1-tona_kosmicznego_smiecia@interia.pl> <20200802204910.15356-2-tona_kosmicznego_smiecia@interia.pl> <87y2mwt9t0.fsf@gnu.org> <20200803144349.06022fa4@interia.pl> Date: Wed, 05 Aug 2020 11:17:43 +0200 In-Reply-To: <20200803144349.06022fa4@interia.pl> (Jan Wielkiewicz's message of "Mon, 3 Aug 2020 14:43:49 +0200") Message-ID: <87o8npjvt4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx2.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx2.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.49 X-TUID: RzUoVOZwhxFC Hello Jan, >> Do we really need to propagate all those inputs? > The python dependencies were added to propagated inputs automatically > by "guix import". The other tools are needed in the user profine, > because qmk-cli uses them, for example it fetches qmk firmware from > git, it runs some *python stuff* and when user is done making changes > to their firmware, qmk cli builds the firmware using the compiler and > flashes it using dfu. Turns out qmk_cli is just a wrapper around qmk_firmware. It clones qmk firmware repository because it cannot locate a qmk_firmware directory using QMK_HOME variable. I think the proper way to do things would be to package qmk_firwmare first (it has a root shell.nix file that should help). Then this package would define QMK_HOME using "search-paths". This way, qmk_cli would just require some python libraries, but would not propagate git, and the toolchains. Does it make sense? Thanks, Mathieu