From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mEkIArkNLl+jEwAA0tVLHw (envelope-from ) for ; Sat, 08 Aug 2020 02:28:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id wPTzOLgNLl8mVgAA1q6Kng (envelope-from ) for ; Sat, 08 Aug 2020 02:28:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3D2A9940719 for ; Sat, 8 Aug 2020 02:28:08 +0000 (UTC) Received: from localhost ([::1]:34172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4Eac-0006Ng-D2 for larch@yhetil.org; Fri, 07 Aug 2020 22:28:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4EaY-0006NU-IY for guix-patches@gnu.org; Fri, 07 Aug 2020 22:28:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46274) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k4EaY-0007gf-9T for guix-patches@gnu.org; Fri, 07 Aug 2020 22:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k4EaY-00070Q-6u for guix-patches@gnu.org; Fri, 07 Aug 2020 22:28:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42736] [PATCH] gnu: emacs-doom-themes: Update to 2.1.6-5. Resent-From: Brett Gilio Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 08 Aug 2020 02:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42736 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jack Hill Cc: 42736@debbugs.gnu.org Received: via spool by 42736-submit@debbugs.gnu.org id=B42736.159685367126911 (code B ref 42736); Sat, 08 Aug 2020 02:28:02 +0000 Received: (at 42736) by debbugs.gnu.org; 8 Aug 2020 02:27:51 +0000 Received: from localhost ([127.0.0.1]:57820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4EaM-0006zz-HP for submit@debbugs.gnu.org; Fri, 07 Aug 2020 22:27:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4EaI-0006zj-Iv for 42736@debbugs.gnu.org; Fri, 07 Aug 2020 22:27:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39055) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4EaD-0007gF-0u; Fri, 07 Aug 2020 22:27:41 -0400 Received: from [2605:6000:1a0d:48fb::e9] (port=48148 helo=lenovo-t430) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k4EaC-0000cZ-26; Fri, 07 Aug 2020 22:27:40 -0400 From: Brett Gilio References: <20200807031749.27160-1-jackhill@jackhill.us> <878serjfdk.fsf@gnu.org> <87ft8y5nto.fsf@gnu.org> Date: Fri, 07 Aug 2020 21:27:58 -0500 In-Reply-To: (Jack Hill's message of "Fri, 7 Aug 2020 22:09:39 -0400 (EDT)") Message-ID: <87o8nlc1n5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: +4+qRno0j2kx Jack Hill writes: >>> On Thu, 6 Aug 2020, Brett Gilio wrote: >>> >>>> >>>> Hey Jack, >>>> >>>> Thanks for taking time to revise this package. When I originally wrote >>>> it I made notice to the fact that some elisp bytecompilations were >>>> failing or not behaving appropriately. Since then I am pretty sure >>>> hlissner has disabled the bytecompilation completely? Could you review >>>> this for me, and if true please revise the appropriate arguments. If you >>>> aren't sure what I am talking about, please let me know. > > Brett, > > I think the way forward is to follow upstream's choices and not enable > or disable byte compilation in Guix. > > After upstream introduced commit 9cd6872 [0], our trick to selectively > leave batch compilation enabled for some files didn't work because > they already had `-*- no-byte-compile: t; -*-` at the top of the > file. In my testing, I added a phase to substitute this away. Indeed, > this allowed our trick to work again. However, the material, snazzy, > and tomorrow-day themes now have problems with byte compilation. > > Therefore, I removed the disable-breaking-compilation phase > entirely. With it removed, doom-themes-autoloads.el, > doom-themes-base.el, doom-themes.el, doom-themes-ext-org.el, and > doom-themes-ext-visual-bell.el do get byte compiled. From this > evidence I concluded that upstream is aware of this issue and is only > disabling byte compilation where necessary. > > I'll send a version 2 of the patch with the phase removed shortly. > > [0] https://github.com/hlissner/emacs-doom-themes/commit/9cd6872b1af88165834230abd45743036861f925 > > Best, > Jack Jack, Thank you for investigating this issue. I agree with your solution, and I will apply your patch removing the phase. Brett