From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id UO75Oo6jtV8LEAAA0tVLHw (envelope-from ) for ; Wed, 18 Nov 2020 22:43:26 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id sE3BNo6jtV9wZgAAB5/wlQ (envelope-from ) for ; Wed, 18 Nov 2020 22:43:26 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8913194011C for ; Wed, 18 Nov 2020 22:43:26 +0000 (UTC) Received: from localhost ([::1]:47378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfWAf-0003KU-Im for larch@yhetil.org; Wed, 18 Nov 2020 17:43:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60668) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfWAI-0003KK-Lb for guix-patches@gnu.org; Wed, 18 Nov 2020 17:43:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53693) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kfWAH-0004Bm-UV for guix-patches@gnu.org; Wed, 18 Nov 2020 17:43:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kfWAH-0001XJ-Sn for guix-patches@gnu.org; Wed, 18 Nov 2020 17:43:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44515] [PATCH] gnu: xmlstarlet: Install symlink to xmlstarlet binary. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 18 Nov 2020 22:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44515 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre Langlois Cc: 44515@debbugs.gnu.org Received: via spool by 44515-submit@debbugs.gnu.org id=B44515.16057393655881 (code B ref 44515); Wed, 18 Nov 2020 22:43:01 +0000 Received: (at 44515) by debbugs.gnu.org; 18 Nov 2020 22:42:45 +0000 Received: from localhost ([127.0.0.1]:37006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfWA1-0001Wn-A4 for submit@debbugs.gnu.org; Wed, 18 Nov 2020 17:42:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfW9z-0001WY-VQ for 44515@debbugs.gnu.org; Wed, 18 Nov 2020 17:42:44 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36851) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfW9u-00048v-Fj; Wed, 18 Nov 2020 17:42:38 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=40194 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kfW9s-0007Ae-Vu; Wed, 18 Nov 2020 17:42:37 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87zh3sumjy.fsf@gmx.com> Date: Wed, 18 Nov 2020 23:42:35 +0100 In-Reply-To: <87zh3sumjy.fsf@gmx.com> (Pierre Langlois's message of "Sun, 08 Nov 2020 11:15:29 +0000") Message-ID: <87o8jui8x0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: I81rJP8fBzaH Hi, Pierre Langlois skribis: > I recently encountered a small script incompatibility between Guix and > other distros (Arch, Fedora, Debian) because the `xml' binary is often > either moved or symlinked to `xmlstarlet'. > > So here's a patch that adds the symlink, is that OK to commit? Sure! Maybe add a comment above stating that several other distros do that. >>>From a285bc89eb37a5aa56d444c195d9ef013a30aeec Mon Sep 17 00:00:00 2001 > From: Pierre Langlois > Date: Fri, 30 Oct 2020 11:57:35 +0000 > Subject: [PATCH] gnu: xmlstarlet: Install symlink to xmlstarlet binary. > > * gnu/packages/xml.scm (xmlstarlet)[arguments]: Add 'symlink-xmlstarlet > phase. [...] > + (add-after 'install 'symlink-xmlstarlet > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin"))) > + (symlink (string-append bin "/xml") ^ "xml" is enough. Thanks, Ludo=E2=80=99.