From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 45101@debbugs.gnu.org
Subject: [bug#45101] [PATCH] scripts: discover: Remove file locks.
Date: Sat, 12 Dec 2020 20:52:01 +0100 [thread overview]
Message-ID: <87o8iy2466.fsf@gnu.org> (raw)
In-Reply-To: <20201207131706.96073-1-othacehe@gnu.org> (Mathieu Othacehe's message of "Mon, 7 Dec 2020 14:17:06 +0100")
Hi!
Mathieu Othacehe <othacehe@gnu.org> skribis:
> * guix/scripts/discover.scm (call-once, call-with-output-file/atomic): New
> procedures copied from (system base compile).
> (call-with-read-file-lock, with-read-file-lock): Remove them.
> (write-publish-file): Use "call-with-output-file/atomic" instead of
> "with-file-lock".
> (read-substitute-urls): Remve file lock.
I think you could use ‘with-atomic-file-output’ from (guix utils).
(Apologies if I gave you the wrong name before!)
Apart from that LGTM, thanks! :-)
Ludo’.
next prev parent reply other threads:[~2020-12-12 19:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 13:17 [bug#45101] [PATCH] scripts: discover: Remove file locks Mathieu Othacehe
2020-12-12 19:52 ` Ludovic Courtès [this message]
2020-12-13 12:25 ` bug#45101: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8iy2466.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=45101@debbugs.gnu.org \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).