From: "Ludovic Courtès" <ludo@gnu.org>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 26489@debbugs.gnu.org
Subject: [bug#26489] [PATCH] substitute: Ignore bad responses.
Date: Sun, 20 Dec 2020 14:39:48 +0100 [thread overview]
Message-ID: <87o8io8ul7.fsf@gnu.org> (raw)
In-Reply-To: <861rfmvpdn.fsf@gmail.com> (zimoun's message of "Fri, 18 Dec 2020 21:19:16 +0100")
Hi,
zimoun <zimon.toutoune@gmail.com> skribis:
> On Mon, 01 May 2017 at 15:14, ludo@gnu.org (Ludovic Courtès) wrote:
>
>>> I think throwing an unhandled exception is definitely the wrong thing to
>>> do here — this kills even ‘guix --keep-going --fallback’. I'm less sure
>>> about the right place to do it
>>
>> Oh right, if that kills --fallback, that’s a problem.
>>
>> Back to your initial patch, what about moving ‘bad-response’ handling to
>> the call site of ‘http-multiple-get’ instead of having it in
>> ‘http-multiple-get’? (That way, ‘http-multiple-get’ would behave like
>> ‘http-get’ in this respect.)
>>
>> Upon a ‘bad-response’, ‘fetch-narinfos’ would return #f or the empty
>> list or the partial narinfo list it has built so far.
>>
>> WDYT?
>>
>> I’d be happy with a patch along these lines!
>
> Tobias, do you plan to rework/rebase it?
In the meantime, commit 5ff521452b9ec2aae9ed8e4bb7bdc250a581f203 added
‘bad-response’ handling (and more). We should take a closer look, but
it may be that this issue is now addressed.
Ludo’.
next prev parent reply other threads:[~2020-12-20 13:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 0:27 bug#26489: [PATCH] substitute: Ignore bad responses Tobias Geerinckx-Rice
2017-04-14 9:54 ` Ludovic Courtès
2017-04-28 20:56 ` Tobias Geerinckx-Rice
2017-05-01 13:14 ` Ludovic Courtès
2020-12-18 20:19 ` [bug#26489] " zimoun
2020-12-20 13:39 ` Ludovic Courtès [this message]
2021-01-11 13:08 ` zimoun
2021-01-15 19:52 ` Julien Lepiller
2021-02-09 1:05 ` zimoun
2021-02-09 8:42 ` bug#26489: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8io8ul7.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=26489@debbugs.gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).