From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kGNfDOwQ718BQwAA0tVLHw (envelope-from ) for ; Fri, 01 Jan 2021 12:09:16 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id OOA0COwQ719DFAAAB5/wlQ (envelope-from ) for ; Fri, 01 Jan 2021 12:09:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D0E369404C8 for ; Fri, 1 Jan 2021 12:09:15 +0000 (UTC) Received: from localhost ([::1]:56062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kvJF4-0002Tw-Ld for larch@yhetil.org; Fri, 01 Jan 2021 07:09:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53012) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvJEs-0002Tm-CP for guix-patches@gnu.org; Fri, 01 Jan 2021 07:09:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44127) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kvJEs-0004Zx-4x for guix-patches@gnu.org; Fri, 01 Jan 2021 07:09:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kvJEs-0001tc-0L for guix-patches@gnu.org; Fri, 01 Jan 2021 07:09:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#39961] traceroute Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 01 Jan 2021 12:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39961 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vincent Legoll Received: via spool by 39961-submit@debbugs.gnu.org id=B39961.16095028917222 (code B ref 39961); Fri, 01 Jan 2021 12:09:01 +0000 Received: (at 39961) by debbugs.gnu.org; 1 Jan 2021 12:08:11 +0000 Received: from localhost ([127.0.0.1]:55671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvJE3-0001sP-FF for submit@debbugs.gnu.org; Fri, 01 Jan 2021 07:08:11 -0500 Received: from mira.cbaines.net ([212.71.252.8]:50176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvJE0-0001sE-58 for 39961@debbugs.gnu.org; Fri, 01 Jan 2021 07:08:10 -0500 Received: from localhost (92.41.186.20.threembb.co.uk [92.41.186.20]) by mira.cbaines.net (Postfix) with ESMTPSA id E4F2D27BC06; Fri, 1 Jan 2021 12:08:06 +0000 (GMT) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 15a0b88e; Fri, 1 Jan 2021 12:08:04 +0000 (UTC) References: User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines In-reply-to: Date: Fri, 01 Jan 2021 12:08:01 +0000 Message-ID: <87o8i897xa.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 39961@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.43 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: D0E369404C8 X-Spam-Score: -4.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: WBWusbnixt0A --=-=-= Content-Type: text/plain Vincent Legoll writes: > ping ? > > Anything I should add ? This traceroute implementation looks to be particularly difficult to build, just searching the web for some of the errors brings up other people having problems with it (like [1]). 1: https://patchwork.ozlabs.org/project/buildroot/patch/1539902241-10211-1-git-send-email-sergio.prado@e-labworks.com/ Some comments though, I'd suggest transforming what you're doing with make flags from modifying the phases to adding to the #:make-flags argument, so something like this: #:make-flags (list (string-append "LIBRARY_PATH=" (assoc-ref %build-inputs "libc") "/lib") (string-append "CFLAGS=-I" (assoc-ref %build-inputs "kernel-headers") "/include") "LDFLAGS=-lm -L../libsupp" (string-append "prefix=" (assoc-ref %outputs "out"))) What I've also done here is used the %build-inputs alist, which includes the implicit libc and kernel-headers inputs, so you can remove those inputs from the package definition. As for the -lm issue with the Makefile, that's pretty frustrating. The best thing I could come up with is something like this: (substitute* "default.rules" ((" \\$\\(LIBDEPS\\)") "$(filter-out -l%,$(LIBDEPS))")) That has the advantage of still passing the -lm flag to gcc, and just avoiding make tripping up over it. Finally, I think the license might be gpl2+, with lgpl2.1+ for libsupp, so it would be good to list both of those, with a comment describing what the lgpl license applies to. Could you send an updated patch? Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl/vEKFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XdS1g/+KeWIM+ByjMC25XiwtVC5xSFw2NFbklP3 keVRE8EufRBvMlzklxXi11ybProCxw5IVFTyhhZt2+9E9QIh5hdks3ugckSWMZP7 tOuwFVDIj0iIz96MgbpjkyPTt+itqf/A+qcCgiBdf/8p68sMP0M89ByW/s2ZH5/5 P/5rI2UAN1ffwsL2KtVf9xaHpW2BMm379XraKddqXI1Mtx9lLbpBxlXYsQiJKEGb /7cIBoPK3lkixWnwchG3YWL178Jgmr3u82p8WgerrZs4UUBmXHXwFmlKY1HF4XSM GhdZFqaoWJYTZydz4olCKrlUkKXMMsNjCyOI9btZSwQUHzdAW4kUtQwTbN8mk5Tw pjKAGH5jeKirZQgrwZvBfIcAMkFvKWxKRLdle7wJdi98hnfUaH82Fj1H6u54+P8z 5uCyBUO3ZbRjTj4pYrAMSVRNeNqitszcCFePkjyscM5s8uBCeZbS1u0YPH5yFdAA J/sgCmqEb4uOTzalImTyB0mVqeB9l7M3lEnBiSmm/6RTici1dXCED2jVyptntdZ5 JPXxdoG6wYMj5rh+VoeSVnNRU3iiQ4j1rsu1PCao2A/EWvAjhlobSfgBl2fat23T B4Im9h+G3aqcBi0k/VLMUNNdkePrp3HoR7mvJtoWOQycg9ExgGwATgf1a5KI6Ace 25dkEOSnzKY= =Ffzv -----END PGP SIGNATURE----- --=-=-=--