From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oFJPLDZ7/F8aOwAA0tVLHw (envelope-from ) for ; Mon, 11 Jan 2021 16:22:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id CAMsKDZ7/F8sHQAAbx9fmQ (envelope-from ) for ; Mon, 11 Jan 2021 16:22:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4F4DD9404CA for ; Mon, 11 Jan 2021 16:22:14 +0000 (UTC) Received: from localhost ([::1]:38602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kyzxN-00065e-5O for larch@yhetil.org; Mon, 11 Jan 2021 11:22:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kyzxC-00065V-T7 for guix-patches@gnu.org; Mon, 11 Jan 2021 11:22:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46532) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kyzxC-00069k-ME for guix-patches@gnu.org; Mon, 11 Jan 2021 11:22:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kyzxC-0006vo-Fm for guix-patches@gnu.org; Mon, 11 Jan 2021 11:22:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#42547] [PATCH] build-system/qt: Don't include useless inputs in wrapped variables. Resent-From: "Hartmut Goebel" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 11 Jan 2021 16:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42547 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 42547-submit@debbugs.gnu.org id=B42547.161038206326577 (code B ref 42547); Mon, 11 Jan 2021 16:22:02 +0000 Received: (at 42547) by debbugs.gnu.org; 11 Jan 2021 16:21:03 +0000 Received: from localhost ([127.0.0.1]:58078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyzwF-0006ub-Ag for submit@debbugs.gnu.org; Mon, 11 Jan 2021 11:21:03 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:55107) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyzwC-0006tq-Q8 for 42547@debbugs.gnu.org; Mon, 11 Jan 2021 11:21:01 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DDzTl4t0bz1rwtx; Mon, 11 Jan 2021 17:20:59 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DDzTl3t4zz1qqlC; Mon, 11 Jan 2021 17:20:59 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id Y5BfyZ7iH84e; Mon, 11 Jan 2021 17:20:58 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-188-174-55-154.dynamic.mnet-online.de [188.174.55.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Mon, 11 Jan 2021 17:20:58 +0100 (CET) Received: from lenashee.goebel-consult.de (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with SMTP id 980AD60355; Mon, 11 Jan 2021 17:20:54 +0100 (CET) Received: by lenashee.goebel-consult.de (sSMTP sendmail emulation); Mon, 11 Jan 2021 17:20:54 +0100 From: "Hartmut Goebel" References: <20200726122234.6593-1-kuba@kadziolka.net> <87imc9pkqc.fsf@gnu.org> Date: Mon, 11 Jan 2021 17:20:54 +0100 In-Reply-To: <87imc9pkqc.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 19 Sep 2020 22:36:27 +0200") Message-ID: <87o8hvfnrt.fsf@lenashee.goebel-consult.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= , 42547@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.35 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 4F4DD9404CA X-Spam-Score: -2.35 X-Migadu-Scanner: scn0.migadu.com X-TUID: 2drkA4jDQuNB Hi, I updated this patch together with other fixes for the qt-build service. See http://issues.guix.gnu.org/45784 and following TL;DR for this one: - split refining what goes to XDG_DATA_DIRS into a separate patch see http://issues.guix.gnu.org/45787 - most other requested changes applied, see http://issues.guix.gnu.org/45786 Ludovic Court=C3=A8s writes: > Do you know what impact this has on the closure size of packages you > looked at? About 220 KB. This is roughly the size of cmake-minimal, which was references via the env-var. zeal before: 1420.7 MiB after : 1229.1 MiB quassel before: 1432.5 MiB after : 1220.8 MiB Maybe more important then the reduction of size: There are now much less variables in the wrapper - it is much cleaner now. > There are quite a few packages using =E2=80=98qt-build-system=E2=80=99. = Probably a > change for =E2=80=98staging=E2=80=99 or =E2=80=98core-updates=E2=80=99? This might still go into staging: Approx. 175 packages use the qt-build-system as of today. Not checked for dependencies though. > I=E2=80=99m also not a fan of =E2=80=98or-map=E2=80=99. Lacking an alternative (for my limited scheme knowledge) I kept this. Regards hartmut