From: "Hartmut Goebel" <hartmut@goebel-consult.de>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: "Jakub Kądziołka" <kuba@kadziolka.net>, 42547@debbugs.gnu.org
Subject: [bug#42547] [PATCH] build-system/qt: Don't include useless inputs in wrapped variables.
Date: Mon, 11 Jan 2021 17:20:54 +0100 [thread overview]
Message-ID: <87o8hvfnrt.fsf@lenashee.goebel-consult.de> (raw)
In-Reply-To: <87imc9pkqc.fsf@gnu.org> ("Ludovic Courtès"'s message of "Sat, 19 Sep 2020 22:36:27 +0200")
Hi,
I updated this patch together with other fixes for the qt-build service.
See http://issues.guix.gnu.org/45784 and following
TL;DR for this one:
- split refining what goes to XDG_DATA_DIRS into a separate patch
see http://issues.guix.gnu.org/45787
- most other requested changes applied, see http://issues.guix.gnu.org/45786
Ludovic Courtès <ludo@gnu.org> writes:
> Do you know what impact this has on the closure size of packages you
> looked at?
About 220 KB. This is roughly the size of cmake-minimal, which was
references via the env-var.
zeal before: 1420.7 MiB after : 1229.1 MiB
quassel before: 1432.5 MiB after : 1220.8 MiB
Maybe more important then the reduction of size: There are now much less
variables in the wrapper - it is much cleaner now.
> There are quite a few packages using ‘qt-build-system’. Probably a
> change for ‘staging’ or ‘core-updates’?
This might still go into staging: Approx. 175 packages use the
qt-build-system as of today. Not checked for dependencies though.
> I’m also not a fan of ‘or-map’.
Lacking an alternative (for my limited scheme knowledge) I kept this.
Regards
hartmut
prev parent reply other threads:[~2021-01-11 16:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-26 12:22 [bug#42547] [PATCH] build-system/qt: Don't include useless inputs in wrapped variables Jakub Kądziołka
2020-09-19 20:36 ` Ludovic Courtès
2021-01-11 16:20 ` Hartmut Goebel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8hvfnrt.fsf@lenashee.goebel-consult.de \
--to=hartmut@goebel-consult.de \
--cc=42547@debbugs.gnu.org \
--cc=kuba@kadziolka.net \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).