From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4EfTLKXEAmBLfwAA0tVLHw (envelope-from ) for ; Sat, 16 Jan 2021 10:49:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id iEC+KKXEAmCGKwAAB5/wlQ (envelope-from ) for ; Sat, 16 Jan 2021 10:49:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 032A59402B1 for ; Sat, 16 Jan 2021 10:49:08 +0000 (UTC) Received: from localhost ([::1]:42438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0j8l-00063g-Vf for larch@yhetil.org; Sat, 16 Jan 2021 05:49:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0j8g-00063M-0b for guix-patches@gnu.org; Sat, 16 Jan 2021 05:49:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59142) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0j8f-0003xA-PN for guix-patches@gnu.org; Sat, 16 Jan 2021 05:49:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l0j8f-0005HF-Mc for guix-patches@gnu.org; Sat, 16 Jan 2021 05:49:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45889] Nextcloud Desktop (v4) Resent-From: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 16 Jan 2021 10:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45889 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Raghav Gururajan , 45889@debbugs.gnu.org Received: via spool by 45889-submit@debbugs.gnu.org id=B45889.161079411020240 (code B ref 45889); Sat, 16 Jan 2021 10:49:01 +0000 Received: (at 45889) by debbugs.gnu.org; 16 Jan 2021 10:48:30 +0000 Received: from localhost ([127.0.0.1]:42455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0j89-0005GO-O2 for submit@debbugs.gnu.org; Sat, 16 Jan 2021 05:48:30 -0500 Received: from mail-wr1-f41.google.com ([209.85.221.41]:41658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0j84-0005G5-1w for 45889@debbugs.gnu.org; Sat, 16 Jan 2021 05:48:27 -0500 Received: by mail-wr1-f41.google.com with SMTP id a12so11707157wrv.8 for <45889@debbugs.gnu.org>; Sat, 16 Jan 2021 02:48:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=16XF/7+MaCnjkLtAnlpcv08arM6atqrIuT6nwsOj3bs=; b=JIaiaUCTvs42hT3bHKPymBfC41IcqPdGWfaYr9UzDEDSR0935W4KtLABos3aAg4w4a D/que5y5x6hLEKDJ4PlSbOcikEmBjU7qs7Jmk3fr56wkZ2qG0CytaYpo+5506Q2Pm4NX 3wYSJUtHmPB9que0WrIqflQ8LDVv02fygiMzgywXSWheqN9j4/K4gMi+Axb9EKP0xBc/ Gq5GKRucddxZV2u8hKviNFlLqPjeNEdSnOw2qddzMKIoFX6PCTNs97+XE9xIVx5MoYFn C3IXBwBFP2SBBLImPaQkqyBlmhlO/P+v7eO9pD3qvv1/NVJgv9Ww9YxH6desSwyu/8xj yVtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=16XF/7+MaCnjkLtAnlpcv08arM6atqrIuT6nwsOj3bs=; b=mkYGy+SerfrvauhAXe7Ofxu8wE8pTBoJzSyHDGKP9DpvVGLtj0d0zZKQp6t04oWmKN 75kqQUCeac5iQOWn6OMlTsKPrTMLQpTsw7OUfu4TY4mlejMY2YC3AEvDEkoUgwxd+XnB ZMRdlCER5XIRqi8HZmPaEs5HdibE9/Lcn4U7gglPpRu/qOC79CYP+iWwKT5WaXh6ERAV rXJb/tNv5meZgSYSf+4R1Suva+/2QQgCvEApYuYtj+y+movo/Tc2Qh4lyqBaV5u6ESVI zsOoY4LwR9KqwYelRmOHcqR7yGmaxs7QcAC8r2Sgk5DClnxD8Y08OUEEzdVN7jnn619d Iotw== X-Gm-Message-State: AOAM533ZupDF88LzE6Mt5r+XZhNciowbPdivT3TNt4LoSf0mET4BJ6IF 9uu1wotebSj34vXpbH4LOJUIi5Y4Gz0= X-Google-Smtp-Source: ABdhPJzi3PY7Su+KVP8qmcr3vU3dznPEng7azRUb/Ol0KNKKE8eGQXX/uznNYOKV137MCcNYuobe6A== X-Received: by 2002:adf:f344:: with SMTP id e4mr17472304wrp.25.1610794098093; Sat, 16 Jan 2021 02:48:18 -0800 (PST) Received: from guixSD (host-95-244-15-108.retail.telecomitalia.it. [95.244.15.108]) by smtp.gmail.com with ESMTPSA id y6sm17754802wrp.6.2021.01.16.02.48.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Jan 2021 02:48:17 -0800 (PST) From: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti In-Reply-To: References: Date: Sat, 16 Jan 2021 11:48:16 +0100 Message-ID: <87o8hp6tu7.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 0.24 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=JIaiaUCT; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 032A59402B1 X-Spam-Score: 0.24 X-Migadu-Scanner: scn0.migadu.com X-TUID: t64nGR1/45wj Raghav Gururajan writes: Hi! > Please find the attached patch-set to add Nextcloud desktop application > to guix. I usually don't do patch review, so don't weight too much my comments. Why is it placed inside a new module? It should fit nicely in sync.scm > + (url "https://github.com/nextcloud/desktop.git") .git shouldn't be needed > + (base32 "1ba9z1kv3wlrmaxsn442vn0inzbd0smvq4xkavarn1h8i0dm62hb")))) This hash is wrong, I get 022k7b3c30dymrjc1g3ly2cac1c34gkqnvjya6p7w2j3qw2w1dm2 > + (with-directory-excursion "src/3rdparty" > + (for-each delete-file-recursively > + (list > + "libcrashreporter-qt" > + "sqlite3"))) This can be expressed in terms of what you you are keeping instead. Something along the line of: (let ((preserved-3rdparty-files '("QProgressIndicator" "qtlockedfile" "qtokenizer" "qtsingleapplication" "kmessagewidget"))) (with-directory-excursion "src/3rdparty" (for-each (lambda (directory) (simple-format #t "deleting: ~A\n" directory) (delete-file-recursively directory)) (lset-difference string=? (scandir ".") (cons* "." ".." preserved-3rdparty-files)))) #t) > + (add-after 'remove-thirdparty 'patch-plugin-dirs > + (lambda* (#:key outputs #:allow-other-keys) > + (substitute* "shell_integration/libcloudproviders/CMakeLists.txt" > + (("PKGCONFIG_GETVAR\\(dbus-1 session_bus_services_dir > _install_dir\\)") This line is too long, you can use something like ("PKGCONFIG_GETVAR\\(.*") instead. > + "set(_install_dir> \"${CMAKE_INSTALL_PREFIX}/share/dbus-1/services\")")) Other long line, maybe string-append. > + (substitute* "shell_integration/dolphin/CMakeLists.txt" > + (("ON CACHE") > + "OFF CACHE")) > + #t)) Why? > + (add-before 'check 'pre-check > + (lambda _ > + (setenv "HOME" (getcwd)) > + #t)) It's missing a comment on why this is needed (like qttest tries to create $HOME/.qttest/config/autostart/) > + (license license:gpl2+))) Unbundled dependencies have different licenses QprogressIndicator is under expat while others lgpl2.1+ if I'm not wrong Also, I tried removing ruby and python-sphinx from the dependencies and it did build fine, so be sure all of them are needed (or are they used for some optional feature?). Thanks