unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: wednesday <jessejohngildersleve@zohomail.eu>
Cc: swedebugia <swedebugia@riseup.net>, 35193-done@debbugs.gnu.org
Subject: bug#35193: [PATCH 0/3] Add python-mypy and required packages
Date: Fri, 02 Apr 2021 23:20:21 -0400	[thread overview]
Message-ID: <87o8ewqcju.fsf_-_@gmail.com> (raw)
In-Reply-To: <74772c08-9903-6e23-357c-5928517ca53f@riseup.net> (swedebugia@riseup.net's message of "Thu, 27 Jun 2019 16:11:07 +0200")

Hi!

swedebugia <swedebugia@riseup.net> writes:

> On 2019-04-30 17:29, wednesday wrote:
>> * gnu/packages/python-xyz.scm (python-mypy): New public variable.
>> ---
>>   gnu/packages/python-xyz.scm | 27 +++++++++++++++++++++++++++
>>   1 file changed, 27 insertions(+)
>> diff --git a/gnu/packages/python-xyz.scm
>> b/gnu/packages/python-xyz.scm
>> index 01c065fc83..c528d2849d 100644
>> --- a/gnu/packages/python-xyz.scm
>> +++ b/gnu/packages/python-xyz.scm
>> @@ -15679,3 +15679,30 @@ standard @code{typing} module that are supported by the mypy typechecker.")
>>                (propagated-inputs
>>                 `(("python2-typing" ,python2-typing)
>>                   ,@(package-propagated-inputs mypy))))))
>> +
>> +(define-public python-mypy
>> +  (package
>> +    (name "python-mypy")
>> +    (version "0.701")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (pypi-uri "mypy" version))
>> +       (sha256
>> +        (base32
>> +         "05479r3gbq17r22hyhxjg49smx5q864pgx8ayy23rsdj4w6z2r2p"))))
>> +    (build-system python-build-system)
>> +    ;; FIXME: tests freeze at 80%
>
> We really would like to understand why these fail and mitigate if possible.
>
> Have you reported this upstream?
>
>> +    (arguments '(#:tests? #f))
>> +    (propagated-inputs
>> +     `(("python-mypy-extensions" ,python-mypy-extensions)
>> +       ("python-typed-ast" ,python-typed-ast)
>> +       ("python-psutil" ,python-psutil)))
>> +    (home-page "http://www.mypy-lang.org/")
>> +    (synopsis "Optional static typing for Python 3 and 2 (PEP 484)")
>> +    (description "Add type annotations to your Python programs, and use mypy to type check
>> +them.  
>
> This phrase is a little eh weird. Could you rephrase to something like
> "Mypy checks type annotations..." or "Mypy is a ..."?
>
>> Mypy is essentially a Python linter on steroids, and it can catch many programming
>> +errors by analyzing your program, without actually having to run it.  Mypy has a powerful
>> +type system with features such as type inference, gradual typing, generics and union
>> +types.")
>> +    (license license:expat)))
>
>
> The LICENSE file contains this: "Portions of mypy are licensed under
> different licenses.  The files under stdlib-samples are licensed under 
> the PSF 2 License, reproduced below."
>
> Could you update the patch when you get an answer from upstream?
>
> Thanks for the patch. :)

It seems python-mypy and the required dependencies were merged (last
year) from another contributor that probably had failed to notice about
them here.  Thank you nonetheless, and thanks to swedebugia for the
review!

Closing.

Maxim




      reply	other threads:[~2021-04-03  3:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-08 13:44 [bug#35193] [PATCH 0/3] Add python-mypy and required packages JesseJohnGildersleve
2019-04-08 14:20 ` [bug#35193] [PATCH 1/3] Add python-typed-ast JesseJohnGildersleve
2019-04-08 14:21 ` [bug#35193] [PATCH 2/3] Add python-mypy-extensions JesseJohnGildersleve
2019-04-08 14:23 ` [bug#35193] [PATCH 3/3] Add python-mypy JesseJohnGildersleve
2019-04-30 15:29 ` [bug#35193] [PATCH v2 0/3] Updating and fixing mypy packages wednesday
2019-04-30 15:29   ` [bug#35193] [PATCH v2 1/3] gnu: Add python-typed-ast wednesday
2019-04-30 15:29   ` [bug#35193] [PATCH v2 2/3] gnu: Add python-mypy-extensions wednesday
2019-04-30 15:29   ` [bug#35193] [PATCH v2 3/3] gnu: Add python-mypy wednesday
2019-06-27 14:11     ` swedebugia
2021-04-03  3:20       ` Maxim Cournoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8ewqcju.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=35193-done@debbugs.gnu.org \
    --cc=jessejohngildersleve@zohomail.eu \
    --cc=swedebugia@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).