unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
From: Sergiu Ivanov <sivanov@colimite.fr>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 48101-done@debbugs.gnu.org
Subject: [bug#48101] [PATCH] gnu: Add aspell-dict-ro.
Date: Fri, 30 Apr 2021 15:17:43 +0200	[thread overview]
Message-ID: <87o8dvx66g.fsf@colimite.fr> (raw)
In-Reply-To: <20210430125416.1cec31e1@tachikoma.lepiller.eu>

Thus quoth  Julien Lepiller  on Fri Apr 30 2021 at 12:54 (+0200):
> Le Thu, 29 Apr 2021 10:17:05 +0200,
> Sergiu Ivanov <sivanov@colimite.fr> a écrit :
>
>> Dear Guix,
>> 
>> Please find attached my first ever patch adding the Romanian
>> aspell dictionary.
>> 
>> The addition seems very simple and I tested building and installing it
>> in my custom channel and building within a Git checkout of Guix.
>> 
>> Do tell me if there are any improvement opportunities, I am here to
>> learn :-)
>> 
>> -
>> Sergiu
>
> Pushed as 847f523381f79e46d151257bf5f9a636a85db8ac with some small
> changes:
>
> I added a copyright line for you at the top of the file.

Oh, thank you, I completely forgot about that!

> There was an alignment issue, caused by tabulations. I replaced them
> with spaces (please don't use tabs).

Ooops, sorry, I've just disabled tabs in my Emacs configuration.
Not sure why I kept them enabled anyway.

> You should be able to use the package after running "guix pull". Thanks
> for your contribution!

Thank you for your time!




      reply	other threads:[~2021-04-30 14:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-29  8:17 Sergiu Ivanov
2021-04-30 10:54 ` bug#48101: " Julien Lepiller
2021-04-30 13:17   ` Sergiu Ivanov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8dvx66g.fsf@colimite.fr \
    --to=sivanov@colimite.fr \
    --cc=48101-done@debbugs.gnu.org \
    --cc=julien@lepiller.eu \
    --subject='Re: [bug#48101] [PATCH] gnu: Add aspell-dict-ro.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

unofficial mirror of guix-patches@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git