From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0EYmLGgyo2AsjAAAgWs5BA (envelope-from ) for ; Tue, 18 May 2021 05:20:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id GMjoJ2gyo2C6YgAA1q6Kng (envelope-from ) for ; Tue, 18 May 2021 03:20:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0DD63A4DA for ; Tue, 18 May 2021 05:20:08 +0200 (CEST) Received: from localhost ([::1]:44144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liqH9-0006CI-4k for larch@yhetil.org; Mon, 17 May 2021 23:20:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48716) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liqH4-0006Bs-Fz for guix-patches@gnu.org; Mon, 17 May 2021 23:20:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42660) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1liqH4-0004Wp-8x for guix-patches@gnu.org; Mon, 17 May 2021 23:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1liqH4-0004LV-3w for guix-patches@gnu.org; Mon, 17 May 2021 23:20:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48437] [PATCH] lint: archival: Lookup content in Disarchive database. Resent-From: Timothy Sample Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 18 May 2021 03:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48437 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 48437@debbugs.gnu.org X-Debbugs-Original-Cc: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.162130795116624 (code B ref -1); Tue, 18 May 2021 03:20:02 +0000 Received: (at submit) by debbugs.gnu.org; 18 May 2021 03:19:11 +0000 Received: from localhost ([127.0.0.1]:54200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liqGF-0004K3-1m for submit@debbugs.gnu.org; Mon, 17 May 2021 23:19:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:45744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liqGB-0004Ju-Pq for submit@debbugs.gnu.org; Mon, 17 May 2021 23:19:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48622) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liqGB-00068s-Cm for guix-patches@gnu.org; Mon, 17 May 2021 23:19:07 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:60489) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liqG9-0003ej-E7; Mon, 17 May 2021 23:19:07 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6E5B35C0198; Mon, 17 May 2021 23:19:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 17 May 2021 23:19:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=4A570MIgOwm3cqyoO+6ZRegdsmoVkpka2dXrVAPD0 v0=; b=K4OFflyNF8icGdiY27Q3PxoM2ntLE+QPs3PAh2T8P6Lli0cNnKBww1KHb wq9PC7dGvX/88ILu6TATimo7uyt4s5xw8z5a0o4AXRI/6RkHcEp5xg8eGR+iyUCy j5mfAmPeUlRbaLVe0r3EndgeuzSppMK33C+P7bc+Q5kCDA93sFGDQo46Tm3BMHiN 1twkXlNDWn4uhqBiawH3kCG+AczuKLPuTHky0i8qigI2njSS/t5wcdx7x/b6kD33 BR9bOmrTIyPPY4cb26OVDymWJxEihLTBrMsEKj/weFdZM9km/q2XcZk2OBGs5gB8 d4fZdo9W7FVDG5SVBbn9hz+16ZP8w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdeiiedgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufhfffgjkfgfgggtgfesthhqredttderjeenucfhrhhomhepvfhimhho thhhhicuufgrmhhplhgvuceoshgrmhhplhgvthesnhhghihrohdrtghomheqnecuggftrf grthhtvghrnhepieduuefhgeegleelveehgedugfeuhfeikefftdevieelgfelhfdvtdfg ieehtefgnecukfhppeejgedrudduiedrudekiedrgeegnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepshgrmhhplhgvthesnhhghihrohdrtgho mh X-ME-Proxy: Received: from mrblack (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 17 May 2021 23:19:01 -0400 (EDT) From: Timothy Sample References: <20210515102814.5944-1-ludo@gnu.org> Date: Mon, 17 May 2021 23:19:01 -0400 In-Reply-To: <20210515102814.5944-1-ludo@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 15 May 2021 12:28:14 +0200") Message-ID: <87o8d8loey.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=66.111.4.28; envelope-from=samplet@ngyro.com; helo=out4-smtp.messagingengine.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621308008; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4A570MIgOwm3cqyoO+6ZRegdsmoVkpka2dXrVAPD0v0=; b=N6dER5pk2pH/T/2B1A3DJPX0NfXres4HGWRtOx4kuEKhhyrioXDyX5UGs5xENUvDp4l3Zh HMFhhoo0CYnyyNfbgmpjLQML9a24wLyPQwGuiucoWDxzN7Tuknd11Smo6RjrnHLdcjz2O4 CJg+tB3yzBe6jwo8RrEEz3VR2ggiSgEjfTb+bBvTqlHn6+Cp1ibzwlQO/MlY6bmC1azBTr iPH8p8nX6Q7oiIpt8ihIp13iDbRDE/p+iSYdpO+KB1RQZsEXiWg3GJmasiZFRbwCLFUo4K JcvR4B332QHVzE1uIx9FLrhhDDn8N4UrYY8DprcVBu4l0lZ5E9hhSvEehti4eA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621308008; a=rsa-sha256; cv=none; b=l6yBNyvJcUnYWROP3NRkc9eusUuarqyYq8yMhzfPcPkfbxlXshrzpiUa8075sHOon/9SSa A1ayvAtPilcUZ5lwHxD1FcDjZzTLd1HmFF+pPW78OUKfom0a4BuNw+pH0/MgGmKcYW3JvG Xon/jXNAezkWgrSh8YhTWjMneuleQ2GvYYezHVuPGL2ge38KKM2kwAZJ986YWNLxmZuJzL k0DkmIYUtUOqjjH32QD+hityl+WvlyOyda9MjClNLx2GMN6GFdZ8zmxaHjrfzGs6y57yIo sTHh2neYc3VuCItyL7TCO6o7G2NIwBE7Qn63enMEjNFwdCrEjpo/bglBO9DcUQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=K4OFflyN; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.44 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=K4OFflyN; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 0DD63A4DA X-Spam-Score: -1.44 X-Migadu-Scanner: scn0.migadu.com X-TUID: cu2p+l8fBvtS Hello, Ludovic Court=C3=A8s writes: > This patch makes the =E2=80=98archival=E2=80=99 checker check the Disarch= ive database(s) > when SWH =E2=80=98lookup-content=E2=80=99 returns #f. [...] > > It assumes that the swhid found in the Disarchive metadata is valid, a > reasonable assumption IMO. > > Thoughts? One thing to consider is that just because Disarchive has captured an archive=E2=80=99s metadata and computed the SWHID of its contents doesn=E2= =80=99t mean that the contents are actually in the SWH archive. (Maybe that=E2=80=99s w= hat you meant when you wrote about valid IDs above.) It would be neat if the lint check looked up the SWHID to see if it exists. Unfortunately, Disarchive doesn=E2=80=99t make getting the underlying SWHID easy at the mo= ment. One option would be to pass a resolver to =E2=80=9Cdisarchive-assemble=E2= =80=9D that exfiltrates the ID using =E2=80=9Cset!=E2=80=9D. Another one would be to = =E2=80=9Cread=E2=80=9D the specification and search for a form like =E2=80=98(swhid "swh:1:dir:...")= =E2=80=99. Neither is particularly lovely.... Other than that, the code looks good and everything seems to work. :) -- Tim