From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oBVKMkEfQWHIogAAgWs5BA (envelope-from ) for ; Wed, 15 Sep 2021 00:16:33 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id wIodLkEfQWFRGgAA1q6Kng (envelope-from ) for ; Tue, 14 Sep 2021 22:16:33 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 61F0F1FBC1 for ; Wed, 15 Sep 2021 00:16:32 +0200 (CEST) Received: from localhost ([::1]:38212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQGj9-0007Aa-C7 for larch@yhetil.org; Tue, 14 Sep 2021 18:16:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQGig-00076q-Ud for guix-patches@gnu.org; Tue, 14 Sep 2021 18:16:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38791) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQGig-0003ei-MS for guix-patches@gnu.org; Tue, 14 Sep 2021 18:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQGig-0004KK-En for guix-patches@gnu.org; Tue, 14 Sep 2021 18:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50333] [PATCH] Fixed missing files in org-roam 2.1.0 Resent-From: Adolfo De =?UTF-8?Q?Un=C3=A1nue?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 14 Sep 2021 22:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50333 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: 50333@debbugs.gnu.org Received: via spool by 50333-submit@debbugs.gnu.org id=B50333.163165773016589 (code B ref 50333); Tue, 14 Sep 2021 22:16:02 +0000 Received: (at 50333) by debbugs.gnu.org; 14 Sep 2021 22:15:30 +0000 Received: from localhost ([127.0.0.1]:50337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQGi5-0004JP-R2 for submit@debbugs.gnu.org; Tue, 14 Sep 2021 18:15:30 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:48147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQGi2-0004JB-VD for 50333@debbugs.gnu.org; Tue, 14 Sep 2021 18:15:24 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 4BEE65C0102; Tue, 14 Sep 2021 18:15:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 14 Sep 2021 18:15:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unanue.mx; h= references:from:to:cc:subject:date:in-reply-to:message-id :mime-version:content-type:content-transfer-encoding; s=fm3; bh= 0OJiCuo8truDiVXArMdYjx3+S9n3wvQoe3BS+ifwDmM=; b=VPAahPHnn8wvdLd6 0cAW6RY+TgDpy4EJRn4r03KQHcm2nrfPU0VHxMibqkVfEYwdPFuzv5sUSuN1K2Zr IgPDrRxzqCxbVWG41CLfjkDU0JJwckPAhRoDFGvwI8ZqaX97hCG/1i3vLpwAJY82 u9Wg/porRYM61QxPMPKBbIgF2MdjLLVjVD9vC0PB7UHZGfK/DvUHybA/YMLvzzvC 0NjitaBa11xqWbfnCqoJBnGNBlprOO9iEf3sKE6V35JTa3QdWvUhqFAR7dAyu0ZV 4dZpOuKvnPJf+ahFwjzeesp2Qn/8vwA3C9UN1b5PuSkllZK8yscdFAzNUIEgJZ6c qFA7zA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=0OJiCuo8truDiVXArMdYjx3+S9n3wvQoe3BS+ifwD mM=; b=vzqzxb5PU5u61iZ2VwOv0Z+ONrNMJDWfssvcg5h1rCdTIx/o740rGPGAd UibebyTDMZWMA08ywAZLngCSvdXYJf2uIYI5m3gOq7joiHpa7PFcuj2m9NWzG3VI hRU8h6vZG6jDpRqeXCiKHizjjMksiHUHu05ygT/1vHTGHA/CtXHAgvrv13yA+WVT O5eBnZ48c95JwMy7u2c+3ZyC3Jrfsmj22dX8Cxqv/QmhEhmOKtXrMuA8D3gCe5Vi Ur9hElAANbiwcL5+9XiZ8UNUG6H9QhN2KnuR4sdqi/J3qP1pWXqIWavOb/LrKIKn tModUCZ+utvzW37470p1KIFI3RKvw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudehtddgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpehffgfhvffuffgjkfggtgfgsehtqh ertddtreejnecuhfhrohhmpeetugholhhfohcuffgvucgfnhojnhhuvgcuoegrugholhhf ohesuhhnrghnuhgvrdhmgieqnecuggftrfgrthhtvghrnhepkeejvddtjefhleeujeette eghfekffduhfeghfekgfevteehuedtteektdeitdetnecuffhomhgrihhnpehgnhhurdho rhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg guohhlfhhosehunhgrnhhuvgdrmhig X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 Sep 2021 18:15:16 -0400 (EDT) References: <877dfzebfd.fsf@unanue.mx> <87v93icnst.fsf@unanue.mx> <86ilz3tkai.fsf@gmail.com> User-agent: mu4e 1.6.3; emacs 28.0.50 From: Adolfo De =?UTF-8?Q?Un=C3=A1nue?= Date: Tue, 14 Sep 2021 17:10:49 -0500 In-reply-to: <86ilz3tkai.fsf@gmail.com> Message-ID: <87o88ureh9.fsf@unanue.mx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631657793; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=0OJiCuo8truDiVXArMdYjx3+S9n3wvQoe3BS+ifwDmM=; b=YU2duSP8ZR5ijBHYlfL6TwtiDYFuvcXWzUrlRX9huwmkLYkIcCOlSZNLTQBHcPJU27Tk4h RzYWqau/p1b+U65fD87OMcRaa8OwFcJXv2ph2QizyFPm3VkDcLVh/GM37mg2M6VEDOIJUw 455e398d9bEmaEjqqJA78vFfwihKxb8XvJ4U6zklIy4vk0sQu7OyiWI/7K9PtCTqbJagcF Sq7OVWEKtE5LHSzjX65t7j1x6iPkpIw8MdVnW1MC+BP2EpgZzufi/Wff2luSsoX/b4EJ5h qZAXc51fkqL/1fGJzjIi0sSgLtFJCGKaThtia7biIIonMni1Ci4TIPOnmAys8Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631657793; a=rsa-sha256; cv=none; b=J16yKGS5Cr8+ZHgbjdYCsMsRLXB2TytWfFtydrkU9CbzC2IlOPLZjz4DV66xysw0kiVF0/ IseSGREGItNaGPO06zRJ6Me2oyB66sA8p9RfCwv1Ih4GEdMkqUDPseYcmWaZVJ6NYHPkCq ASx7RYpzqaRddOkkNV/vZ4DkFK2QQ/tvHKM/ntnkBZgj1NM2ed9ELJm8/fgNicixZtHg85 xTWW6SJEYSNVOREa2DXnqcbXtEBdmGjaNrMx7OX5XDZt2BjufM8B+NwkgLct7vy4eaRTmZ S8Yrk6CPUg34EQEjXRn/EUTVYQaF1zQlgR/NymjXh07d3ZHnxzFue1CTrGxLWg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=unanue.mx header.s=fm3 header.b=VPAahPHn; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b=vzqzxb5P; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 3.40 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=unanue.mx header.s=fm3 header.b=VPAahPHn; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b=vzqzxb5P; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 61F0F1FBC1 X-Spam-Score: 3.40 X-Migadu-Scanner: scn0.migadu.com X-TUID: DPwQZTfhDZMi Thank you for your comments and advices. zimoun writes: > Hi, > > You are asking in about=20 > this > one. Well, I am not an expert and I am not an Emacs Roam user. > > On Thu, 02 Sep 2021 at 22:57, Adolfo De Un=C3=A1nue=20 > wrote: > >>>>From a99fa75c0f5d3025827d99c3ef6a2c71c85e0be5 Mon Sep 17=20 >>>00:00:00 2001 >> From: =3D?UTF-8?q?Adolfo=3D20De=3D20Un=3DC3=3DA1nue?=3D=20 >> >> Date: Thu, 2 Sep 2021 22:23:58 -0500 >> Subject: [PATCH] Fixed missing files in org-roam v2.1.0 > > The commit message should be: > > --8<---------------cut=20 > here---------------start------------->8--- > gnu: emacs-org-roam: Adding extensions. > > * guix/emacs-xyz.scm (emacs-org-roam)[arguments]: Add phases to=20 > install > extensions. > --8<---------------cut=20 > here---------------end--------------->8--- > > Or something along these lines. > Should I apply your suggested changes, commit them, use this=20 commit message, create the patch and send them again? >> --- >> gnu/packages/emacs-xyz.scm | 94=20 >> +++++++++++++++++++++----------------- >> 1 file changed, 53 insertions(+), 41 deletions(-) >> >> diff --git a/gnu/packages/emacs-xyz.scm=20 >> b/gnu/packages/emacs-xyz.scm >> index 030809f5ac..431444c255 100644 >> --- a/gnu/packages/emacs-xyz.scm >> +++ b/gnu/packages/emacs-xyz.scm >> @@ -103,6 +103,7 @@ >> ;;; Copyright =C2=A9 2021 Matthew James Kraai >> ;;; Copyright =C2=A9 2021 Noisytoot >> ;;; Copyright =C2=A9 2021 Simon South >> +;;; Copyright =C2=A9 2021 Nanounanue > > Since you submit with this name =E2=80=9CAdolfo De Un=C3=A1nue=E2=80=9C, = the=20 > Copyright should > be the same instead of a nick name. From my point of view,=20 > nickname as > copyright holder should be avoided; if possible, obviously. :-) I will do, makes complete sense > >> + (let ((commit "f819720c510185af713522c592833ec9f2934251") > > Usually, the package uses tagged version instead of random=20 > commit. When > it is not possible because upstream do not tag, it seems good to=20 > provide > an explanation why the lasted tagged version cannot be used; > explanations as a comment or in the cover letter. > As you guessed, org-roam has not tagged this new (breaking)=20 change, that's why I am using the commit > Another reason is because for instance it changes all the=20 > indentation > and makes =E2=80=98git log/blame=E2=80=99 harder to investigate. > >> + (add-after 'install 'install-extensions >> + (lambda* (#:key outputs #:allow-other-keys) >> + (copy-recursively >> + "extensions" >> + (string-append (assoc-ref outputs "out") >> + (string-append >> + "/share/emacs/site-lisp/org-roam-" >> + ,version))) >> + #t)) > > Patch#50333 will install the extensions with =E2=80=9Cguix install > emacs-org-roam=E2=80=9D. Instead the attempt of patch#50374 is to=20 > install with > =E2=80=9Cguix install emacs-org-roam-extensions=E2=80=9D. Well, I do not= know=20 > if > patch#50374 is correct, though. > > Because I am not an Org-Roam user, I do not have an opinion=20 > about this > extensions. Maybe it is better to distribute them along the=20 > package > emacs-org-roam or in a separate package, I do not know. WDYT? > I mean, structurally the upstream owner just moved some files to a=20 new folder, my guess is that it shouldn't be a different packages=20 since it is still part of org-roam. > All the best, > simon Again thank you, it was super helpful! -- - A