From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 50952-done@debbugs.gnu.org
Subject: bug#50952: [PATCH] gnu: Add naev.
Date: Tue, 02 Nov 2021 21:33:46 +0100 [thread overview]
Message-ID: <87o872uwk5.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87k0husani.fsf@gnu.org> ("Ludovic Courtès"'s message of "Sat, 30 Oct 2021 19:08:33 +0200")
Hello,
Ludovic Courtès <ludo@gnu.org> writes:
>> Subject: [PATCH] gnu: Add naev.
>>
>> * gnu/packages/games.scm (naev): New variable.
>
> [...]
>
>> + (build-system meson-build-system)
>> + (arguments
>> + ;; XXX: Do not add debugging symbols, which cause the build to fail.
>
> That sounds weird. Perhaps ‘--buildtype=release’ does something beyond
> removing ‘-g’, which would explain that it doesn’t fail?
I couldn't spot anything suspicious in the code base. However, upstream
mention that "--buildtype=release" should be used for a regular
installation.
> Otherwise LGTM!
Pushed. Thank you!
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2021-11-02 20:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 20:32 [bug#50952] [PATCH] gnu: Add naev Nicolas Goaziou
2021-10-30 17:08 ` Ludovic Courtès
2021-11-02 20:33 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o872uwk5.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=50952-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).