From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <guix-patches-bounces+larch=yhetil.org@gnu.org>
Received: from mp11.migadu.com ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms5.migadu.com with LMTPS
	id 8JVyB/A8D2NedQAAbAwnHQ
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Wed, 31 Aug 2022 12:50:24 +0200
Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp11.migadu.com with LMTPS
	id qHd5B/A8D2PX3AAA9RJhRA
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Wed, 31 Aug 2022 12:50:24 +0200
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id C870315F2E
	for <larch@yhetil.org>; Wed, 31 Aug 2022 12:50:23 +0200 (CEST)
Received: from localhost ([::1]:36672 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	id 1oTLIc-0000xW-VD
	for larch@yhetil.org; Wed, 31 Aug 2022 06:50:23 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:46936)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1oTLIJ-0000xM-Gy
 for guix-patches@gnu.org; Wed, 31 Aug 2022 06:50:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:48578)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1oTLIJ-0001tM-89
 for guix-patches@gnu.org; Wed, 31 Aug 2022 06:50:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1oTLII-0000U4-4Q
 for guix-patches@gnu.org; Wed, 31 Aug 2022 06:50:02 -0400
X-Loop: help-debbugs@gnu.org
Subject: [bug#39136] [PATCH] gnu: services: Add endlessh.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: guix-patches@gnu.org
Resent-Date: Wed, 31 Aug 2022 10:50:02 +0000
Resent-Message-ID: <handler.39136.B39136.16619429851834@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 39136
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Joshua Branson <jbranso@dismail.de>
Cc: 39136@debbugs.gnu.org
Received: via spool by 39136-submit@debbugs.gnu.org id=B39136.16619429851834
 (code B ref 39136); Wed, 31 Aug 2022 10:50:02 +0000
Received: (at 39136) by debbugs.gnu.org; 31 Aug 2022 10:49:45 +0000
Received: from localhost ([127.0.0.1]:38327 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1oTLI1-0000TV-1p
 for submit@debbugs.gnu.org; Wed, 31 Aug 2022 06:49:45 -0400
Received: from eggs.gnu.org ([209.51.188.92]:59446)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@gnu.org>) id 1oTLHy-0000TF-6I
 for 39136@debbugs.gnu.org; Wed, 31 Aug 2022 06:49:43 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:34736)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@gnu.org>)
 id 1oTLHs-0001qY-Th; Wed, 31 Aug 2022 06:49:36 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=PLue9P7BEPor8f/Vtyo/+spTDvd0iwjoPnszWmHLLzQ=; b=Ut9Yx7svYLs7h6Qxl6iA
 mlRFKrlLkZRx6hGNpYfKw+J+QUY2WXT6ZcxKk41s5OlMaJKjxL3I9B5gIJnhQT/rIyY5QzAZJfF4C
 H1gdgLVf+zOuCewIhR/ARkpGZd3z4xIf8CM16MABP6RbqgOqgcQ7zloaT0oTj9DFE2EDHW9yMD3Ex
 yTqEeSsQ/HcJiXNlrVZILPqUY6COFYWSbz55laxxLXePaMvfUkknB8Ns7jhETJL9+SF1FRohKe8hx
 IzshK+40IEVD15j4UKBd9fWfklz6wN1R5w6fhw0FoPpUgsxO2WO8I3oPI1cpFQNlorSb+lHwfnh4n
 zIWqUHJXF3DSiA==;
Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:50428
 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@gnu.org>)
 id 1oTLHs-0007IP-54; Wed, 31 Aug 2022 06:49:36 -0400
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20210315162949.17092-1-jbranso@dismail.de>
 <20210315162949.17092-2-jbranso@dismail.de>
Date: Wed, 31 Aug 2022 12:49:33 +0200
In-Reply-To: <20210315162949.17092-2-jbranso@dismail.de> (Joshua Branson's
 message of "Mon, 15 Mar 2021 12:29:49 -0400")
Message-ID: <87o7w0bsci.fsf_-_@gnu.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: guix-patches@gnu.org
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+larch=yhetil.org@gnu.org>
X-Migadu-Flow: FLOW_IN
X-Migadu-To: larch@yhetil.org
X-Migadu-Country: US
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1661943024;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:resent-cc:
	 resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=PLue9P7BEPor8f/Vtyo/+spTDvd0iwjoPnszWmHLLzQ=;
	b=DAMSrN9Mq6Pawi1njMGUnCUdQXCUnrS2551LZr5tllbB7q65k4NKYcztXa27XcDCuT5VwV
	nOCBG5nQLW0sFDIl3SiPzyVZSeE9oEIGeTXcD58DLqHO1apAcmRqHWqE1kx/wNZ8fxVEcg
	+iYrXBKAZkikz927DH5O+UmoXVPL1e8E6XVjobCEUUJAeACojbaK9E9xaUd0fMte2MBnAU
	6xVZNfAptxLIkjkl4Qk5iEl15kTYqLZ/BXzHM7lk5ThOXIGT0ACRQICeTdh/0bAlAa3efi
	WY5KYR7wTosYbjndCDCTIbqAFEZLhUuvJDoOzXk9HuZgHInX25LIBkq5rQLZpg==
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1661943024; a=rsa-sha256; cv=none;
	b=GB9dWQ92r9dpzB0bXYuxc+xpTrkAe42DEsosUgLj2SbZeCfQWIhRQxnIK/xU8U5u6RUeVs
	yM3Lng3lldo3wT48BAkIm6wfStw2TlItNUMvlAiveog7z2p7qqK0ZPb47PKXo8VN5Vzr9C
	z7px2XMwwx11JZeIVVoQETqlqfTKvoR/Xszzg6MZdWgHbg2g3azssx5Ks1783E/ylAuyJx
	L4H9J2tNBr9MzvaTvBWEqrRc8L+woKuflFgPsBpgNsVyGsb/y12TW7Yd+A7RRrRO+twrXZ
	OkfMdP0KDm2fLhzsEcXb+jSNTbbxddhZWGVtRX6RcImKu8ZkZX8O2FvK/B/K0A==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Ut9Yx7sv;
	dmarc=pass (policy=none) header.from=gnu.org;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Spam-Score: -2.98
Authentication-Results: aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Ut9Yx7sv;
	dmarc=pass (policy=none) header.from=gnu.org;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Queue-Id: C870315F2E
X-Spam-Score: -2.98
X-Migadu-Scanner: scn0.migadu.com
X-TUID: 3L9tzTQH4w9i

Hi Joshua,

Joshua Branson <jbranso@dismail.de> skribis:

> doc: endlessh service documentation.
>
> * doc/guix.texi (Networking Services): New endlessh-service-type section.
>
> services: containerized endlessh
>
> * gnu/services/ssh.scm (endlessh-config->conf): make-forkexec-contructor =
->
> make-forkexec-constructor/container. and attempted to enable logging to s=
yslog.
>   (define-record-type* <endlessh-configuration>)
>   move default values of endlessh configuration to separate line.
>   Add copyright line for Nicolo.

Could you merge both patch #1 and patch #2?  Usually doc is added in the
same commit as the thing being documented.

> +@cindex Endlessh
> +@deffn {Scheme Variable} endlessh-service-type
> +This is the type for the @uref{https://github.com/skeeto/endlessh,
> +Endlessh} program that delays ssh clients for days at a time by

Nitpick: s/ssh/SSH/.

> +@emph{very slowly} sending a random and endless SSH banner.  The smart
> +hacker will put endlessh running on port 22, and let crackers get stuck

Maybe =E2=80=9CThe smart hacker will put=E2=80=9D -> =E2=80=9CYou would typ=
ically run=E2=80=9D

> +   (start #~(make-forkexec-constructor/container

Let=E2=80=99s forget about =E2=80=98/container=E2=80=99 for now if it doesn=
=E2=80=99t work yet.

Perhaps we can have a minimal system test to make sure the thing is
running and listening on the right port?  There are tests for
full-fledged SSH servers in (gnu tests ssh) that could serve as
inspiration.

Could you send a (hopefully) last version with these changes?

Thanks in advance,
Ludo=E2=80=99.