[bug#52900] [PATCH] gnu: libfido2: install udev rules

[bug#52900] [PATCH] gnu: libfido2: install udev rules

[dan]

[arguments]: Add a configure flag specifying the installation directory of the
udev rule.

---
 gnu/packages/security-token.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 6a3e2d9179..719515e3ea 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -777,7 +777,9 @@ (define-public libfido2
        ("openssl" ,openssl)))
     (build-system cmake-build-system)
     (arguments
-     '(#:phases
+     '(#:configure-flags
+       (list (string-append "-DUDEV_RULES_DIR=" %output "/lib/udev/rules.d"))
+       #:phases
        (modify-phases %standard-phases
          ;; regress tests enabled only for debug builds
          (delete 'check))))
-- 
2.34.0

[bug#52900] Update cover letter

[dan]

For some reason the cover letter was not shown up properly.  The 
following is the missing line:

* gnu/packages/security-token.scm(libfido2): Install udev rules.
-- 
dan

[bug#52900] [PATCH] gnu: libfido2: install udev rules

[John Kehayias via Guix-patches via]

Hello,

Thanks for the patch. Could you update it to match the current package definition of libfido2 (and you may want to add your copyright line to the top)?

Since libu2f is deprecated, we should rely on libfido2, so we need the udev rules that this patch makes available. I tested a local version which just needed to add the (string-append...) s-expression to the #:configure-flags that are currently present. I tested that it built and did have the udev rules.

Thanks!
John

[bug#52900] [PATCH] gnu: libfido2: install udev rules.

[Nicolas Graves via Guix-patches via]

[arguments]: Add a configure flag specifying the installation directory of the
udev rule.
---
 gnu/packages/security-token.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 447a7a582d..5f10b5592a 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -909,7 +909,8 @@ (define-public libfido2
                "-DPKG_CONFIG_EXECUTABLE="
                (search-input-file %build-inputs
                                   (string-append
-                                    "/bin/" ,(pkg-config-for-target)))))
+                                   "/bin/" ,(pkg-config-for-target))))
+             (string-append "-DUDEV_RULES_DIR=" %output "/lib/udev/rules.d"))
        #:phases
        (modify-phases %standard-phases
          ;; regress tests enabled only for debug builds
--
2.37.3

--
Best regards,
Nicolas Graves

bug#52900: [PATCH] gnu: libfido2: install udev rules.

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]


Nicolas Graves via Guix-patches via <guix-patches@gnu.org> writes:

> [arguments]: Add a configure flag specifying the installation directory of the
> udev rule.
> ---
>  gnu/packages/security-token.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks all, I've gone ahead and pushed this to master as.
33f56db65498b75ad0a55b780ce501d2b3532044.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]