From: "Ludovic Courtès" <ludo@gnu.org>
To: phodina <phodina@protonmail.com>
Cc: 59758@debbugs.gnu.org
Subject: [bug#59758] [PATCH] gnu: Add dislocker.
Date: Sun, 08 Jan 2023 12:10:22 +0100 [thread overview]
Message-ID: <87o7r9wach.fsf@gnu.org> (raw)
In-Reply-To: <13dcrROCOAZUMAyeACm23prm8ws3D8N1muEl4H76Bm4ExuaDS7YUESqMssqd9JU60lUiIHGzftJ0ZMqR22SqkJs31EV3s-wuTbgX027L2Ac=@protonmail.com> (phodina@protonmail.com's message of "Fri, 02 Dec 2022 04:52:53 +0000")
Hi,
phodina <phodina@protonmail.com> skribis:
> From d237aca245c0868df016ffa9ac49b7b3f1af11cc Mon Sep 17 00:00:00 2001
> From: Petr Hodina <phodina@protonmail.com>
> Date: Thu, 13 Jan 2022 13:24:23 +0100
> Subject: [PATCH] gnu: Add dislocker.
>
> * gnu/packages/linux.scm (dislocker): New variable.
> + (version "0.7.3")
> + (source (origin
> + (method url-fetch)
> + (uri
> + "https://github.com/Aorimn/dislocker/archive/refs/tags/v0.7.3.tar.gz")
This auto-generated tarball changes over time, as reported by ‘guix
lint’. Could you use ‘git-fetch’ instead?
> + (build-system cmake-build-system)
> + (arguments '(#:tests? #f))
Please avoid disabling tests. If you really have to, add a short
comment explaining why it has to be disabled.
> + (synopsis "FUSE driver to read/write Windows BitLocker drives")
> + (description
> + "This package provides means to to read BitLocker encrypted
> + partitions. Write functionality is also provided but check the README.")
Indentation is off. :-)
Could you send an updated patch?
Thanks,
Ludo’.
next prev parent reply other threads:[~2023-01-08 11:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 4:52 [bug#59758] [PATCH] gnu: Add dislocker phodina via Guix-patches via
2023-01-08 11:10 ` Ludovic Courtès [this message]
2023-01-08 23:57 ` phodina via Guix-patches via
2023-01-09 0:00 ` phodina via Guix-patches via
2023-01-12 22:33 ` bug#59758: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7r9wach.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=59758@debbugs.gnu.org \
--cc=phodina@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).