From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 0ypDFVcMz2P/sgAAbAwnHQ (envelope-from ) for ; Mon, 23 Jan 2023 23:38:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 6MGMFFcMz2OYoAAA9RJhRA (envelope-from ) for ; Mon, 23 Jan 2023 23:38:15 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 28724814A for ; Mon, 23 Jan 2023 23:38:15 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pK5S0-0005po-Ro; Mon, 23 Jan 2023 17:38:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pK5Rz-0005pP-24 for guix-patches@gnu.org; Mon, 23 Jan 2023 17:38:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pK5Ry-0004cd-Hj for guix-patches@gnu.org; Mon, 23 Jan 2023 17:38:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pK5Rx-0003er-T6 for guix-patches@gnu.org; Mon, 23 Jan 2023 17:38:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60735] [PATCH v2 2/3] system: Deprecate hosts-file. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 23 Jan 2023 22:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60735 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: 60735@debbugs.gnu.org Received: via spool by 60735-submit@debbugs.gnu.org id=B60735.167451348014054 (code B ref 60735); Mon, 23 Jan 2023 22:38:01 +0000 Received: (at 60735) by debbugs.gnu.org; 23 Jan 2023 22:38:00 +0000 Received: from localhost ([127.0.0.1]:55521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pK5Rw-0003ec-3f for submit@debbugs.gnu.org; Mon, 23 Jan 2023 17:38:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pK5Ru-0003eP-1Y for 60735@debbugs.gnu.org; Mon, 23 Jan 2023 17:37:59 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pK5Ro-0004Yk-5w; Mon, 23 Jan 2023 17:37:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=kxc3kkceNhaAcZZYfYaWe59+StHGIzUcFddVxED7HyQ=; b=f1YdCr5XOzaw+ovb7Xgq 2Dj7eciujVglRc6qIh5bwbgFmJtOG/1fIhFh0ftMKMwY73x/kgw5DRIafV039YIxRzLTVg6pEydfi czPV5bW1UUMS6OyzZchb1C9oLYnKLxQLFgGzGazpmpJXPdy2Ur49xGecelcv53AuoRYNsFDfTqQEY nJxRXmWRN3OUGsP1/Wehs9B8YXyassCXyOnzxbrrliUxDc25zUgCTuEqJ94+YDRbx5I206IT3iL1d QJCGZsOf0ncZj8AAtufuSi0RJZF6WxP6aGnCih3UHYCAEn/vi/5mtLVcj8lUX2aOsJXRPOSvm+fl5 bL24p15EpyIeGA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pK5Rn-0000q2-Lv; Mon, 23 Jan 2023 17:37:51 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quartidi 4 =?UTF-8?Q?Pluvi=C3=B4se?= an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Perce-neige X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 23 Jan 2023 23:37:49 +0100 In-Reply-To: (Bruno Victal's message of "Wed, 18 Jan 2023 16:54:13 +0000") Message-ID: <87o7qoyj0i.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=f1YdCr5X; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674513495; a=rsa-sha256; cv=none; b=g9KGOT5KM5u2IonapFEh04OYTjzdsE2D2gKOBLz9+DaGicZ4P9C/anonJXoPQD3WmRXDZy YnJ+use7GrV/YJg8XmW+swpASVKMbybEYKKgTwCpKhgIjBCyJNDsNekpWDc0uOR7rcbJcA RI9DnX1yagoh6oTOHlpUqZNkn5wN9wSSHG+WcQHYYKhVr40LG4VILa6AxFOlJ03BW+71Uc vus4WXe79IsYEYSH/B025HsmrwlOpbDuLaAIZ7KH6XZNZv4k6qTaaZE6LJjnXq3j+YPXLL Nu0sCTBuHv/0o8vs/LZbRskN1FzOVBeG8LkXfxGPAqE2G3A6bwGN1VsJQ3LK3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674513495; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=kxc3kkceNhaAcZZYfYaWe59+StHGIzUcFddVxED7HyQ=; b=E8tWDZDkrrh28f83OUF2ryc+mpsjxQKsOp59OVhGB4zt3r4RsTwtrQ+wqSm2cMvopfzb7y AJTISY8gt1K07E1md6UHxTDF7fs+D4HJliJaLN58Z34cwcPEH8NyIuMPJUy8r9wh5lo+Jz ugsJEqSvbUP3MmBkvjT1TNvhTqYCf6T5q6BLCvBWf0GpuXEFfRd2mJeDPwmmDOkMmyDGGh 4EqvN8PrYK7ciOcvQmrgUSYoh3LbyJSqrVOVjHmGhyEUK2+6UFu+92y7umJc5pulm+cu6N hUetjwS2yA9t1xSkVQSRP/rCVPY5OWNlZehBLRibNtZoDvFs62N49PnShl8zUQ== X-Spam-Score: -3.59 X-Migadu-Queue-Id: 28724814A X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=f1YdCr5X; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-Migadu-Spam-Score: -3.59 X-TUID: oJ8FoyIRwRTd Bruno Victal skribis: > * gnu/system.scm (operating-system-hosts-file): Deprecate procedure. > (warn-hosts-file-field-deprecation): New procedure, helper for > deprecated variable). > (operating-system)[hosts-file]: Use helper to warn deprecated field. > (operating-system-default-essential-services) > (hurd-default-essential-services): Use hosts-service-type. > (local-host-aliases): Return a list of host-entry records. > (default-/etc/hosts): Remove procedure. > (operating-system-etc-service): Remove hosts file. > * doc/guix.texi (operating-system Reference) > (Networking Services) (Virtualization Services): Rewrite documentation > entries to use hosts-service-type. > * gnu/tests/ganeti.scm: Use hosts-service-type extension. > --- > > WIP, the ganeti tests fail because host-name is added as an alias of loca= lhost. Before these patches, =E2=80=98host-name=E2=80=99 was already an alias of = =E2=80=98localhost=E2=80=99. Is there something else interfering? > + (simple-service 'block-facebook-hosts hosts-service-type > + (let ((host-pairs > + (filter-map > + (lambda (x) > + (and (not (or (string-null? x) > + (string-prefix? "#" x))) > + (remove string-null? > + (string-split > + x > + char-set:whitespace)))) > + (string-split %facebook-host-aliases #\new= line)))) > + (map (match-lambda > + ((addr name) > + (host addr name))) > + host-pairs))) It doesn=E2=80=99t matter because it=E2=80=99s removed in the commit that f= ollows I think using =E2=80=98string-tokenize=E2=80=99 instead of =E2=80=98string-sp= lit=E2=80=99 may bring simplifications. > +++ b/gnu/system.scm > @@ -14,6 +14,7 @@ > ;;; Copyright =C2=A9 2020, 2022 Efraim Flashner > ;;; Copyright =C2=A9 2021 Maxime Devos > ;;; Copyright =C2=A9 2021 raid5atemyhomework > +;;; Copyright =C2=A9 2023 Bruno Victal > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -31,6 +32,7 @@ > ;;; along with GNU Guix. If not, see . >=20=20 > (define-module (gnu system) > + #:use-module (guix discovery) Do we really need this module? Otherwise LGTM. Ludo=E2=80=99.