From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MJRiFazXz2OYXAEAbAwnHQ (envelope-from ) for ; Tue, 24 Jan 2023 14:05:48 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mLGDFKzXz2MSZAEAG6o9tA (envelope-from ) for ; Tue, 24 Jan 2023 14:05:48 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 27E662AE17 for ; Tue, 24 Jan 2023 14:05:48 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKIXE-0004Zb-GV; Tue, 24 Jan 2023 07:36:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKIWy-0004R6-95 for guix-patches@gnu.org; Tue, 24 Jan 2023 07:36:09 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKIWw-0001Md-R1 for guix-patches@gnu.org; Tue, 24 Jan 2023 07:36:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pKIWw-0003Li-J3 for guix-patches@gnu.org; Tue, 24 Jan 2023 07:36:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60976] [PATCH] gnu: Add ditaa. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 24 Jan 2023 12:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60976 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Frank Pursel , 60976@debbugs.gnu.org Received: via spool by 60976-submit@debbugs.gnu.org id=B60976.167456371612799 (code B ref 60976); Tue, 24 Jan 2023 12:36:02 +0000 Received: (at 60976) by debbugs.gnu.org; 24 Jan 2023 12:35:16 +0000 Received: from localhost ([127.0.0.1]:56044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKIWB-0003KL-MC for submit@debbugs.gnu.org; Tue, 24 Jan 2023 07:35:15 -0500 Received: from mail-wr1-f54.google.com ([209.85.221.54]:42823) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKIW7-0003Jc-0o for 60976@debbugs.gnu.org; Tue, 24 Jan 2023 07:35:11 -0500 Received: by mail-wr1-f54.google.com with SMTP id d14so10045820wrr.9 for <60976@debbugs.gnu.org>; Tue, 24 Jan 2023 04:35:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=c8kfzm88cpBp4eaZdig8rIlIfs9VZIrpbTtYhkEsRF0=; b=BB5oVNJJTKoQkO4PVShk8/qxCm6xXGDztUEBJVvWBQoT5WBYSpWVm1fPoCXrx3EHlQ T8s5pdiVxImL5Wh8U06bD552i880oJRVcdHjv8jXLm5dnwOWdYbhbfecBpEZ/di9o1q2 nEOCjq2MyQe1W8ieI38FEIZxcGqk+gxLF1AHSiJM/HUjpKaQ5pjWE2v/xwJ/Fker+aHb sbfJJ7Rz7VQbgQEKSMC7MMpXEB+XB2SHjtasbPbOvB0pgEcWGmvtX8dtCvHbe+z0OgMX S3XzP+e4UmYqeRn2s7BgwpffI4Dotdp8auCkhMuZZeOKzA2hVNly8Z85AqWu/HurASnl P3nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c8kfzm88cpBp4eaZdig8rIlIfs9VZIrpbTtYhkEsRF0=; b=LyaQkNJUEVXfiSWfa7KqN8HZNbA2Sys8hPwHTfstOxrfkex3yIh4pqatRDyNjeJern ARzrAEfdZC8Y+LGSoLmbnZenc45Au679kAzD9/hrhb0aLhre6GLmKOmm5aFHFDj+CBgo D1JG0Bp8ZK7Kf4GkOrKMfgEFBKoftPiBdhVvvYE94etIXu0sfyCoE8LjvffJ+peByMli 2v+ljzYy8mEEwqN/G3XoB1FFahYx3VotJ0a8umd6r4vhc4Q7gGQZoPJjy4Q9vXvymIYM YvRjfWj924W6JuzebyjTWMvM+7t9UXyQmPSFSJYMMVWEp0X0m8GtCg6W5qqCdh7LcBOG fdRg== X-Gm-Message-State: AO0yUKVpcdpE7LkQ2ZbiQ/cflFHntdl54GWi430AvCuXi+ee/MPlS0Ti GPXQ2CUt8iAffGcz35rjrN8T3TKjiLc= X-Google-Smtp-Source: AK7set8mZT3bGY9jOIEuTxMxsxKdifcrn5nPhOPTP3jS4irs2MRcidVXR+QVG2e4d/CO0Wq98PP1/A== X-Received: by 2002:adf:d239:0:b0:2bf:b2fe:a2c4 with SMTP id k25-20020adfd239000000b002bfb2fea2c4mr179623wrh.7.1674563705224; Tue, 24 Jan 2023 04:35:05 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id s18-20020a5d4ed2000000b002bde537721dsm1805098wrv.20.2023.01.24.04.35.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 04:35:04 -0800 (PST) From: Simon Tournier In-Reply-To: <63cb23b3.650a0220.26d15.f66d@mx.google.com> References: <63cb23b3.650a0220.26d15.f66d@mx.google.com> Date: Tue, 24 Jan 2023 11:44:58 +0100 Message-ID: <87o7qop5xx.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674565548; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=c8kfzm88cpBp4eaZdig8rIlIfs9VZIrpbTtYhkEsRF0=; b=dcnZ65WvPphW3ymJs20ElWSaTsZPxQx5AcdbbNDcxnKv+x/Al04QkmaaCdlQW1P4DMoQVx S6LFpI/aqiFtKEmH6FPMHmis3UVSEURrkY4PUFO7CpBfAlRGpi0q7ttGGf0S0Qsa69nNG6 idgz+EZcEv823S5lyD3QuWyPMmJpg9+IV/2lN9SJJPo2BXNDhO9KPIknlv2Mg6qo86H0lO KoSuCnONNeiCS+qcznIQ8NInJXhUS0CUAxxpXdxfCRsxf/xrI1g3ZSS++V9eHW1GNSKhdT GDuo7xvwiWcIwi0wPGpCMwVBP0LNMZf1DtJB/LiTalV+9coi2GF6l8OVqVXH4w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=BB5oVNJJ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674565548; a=rsa-sha256; cv=none; b=sTArsdwD/KzhaFVyln71CRjuPBOCmKei8k3MEegyRDOLFts96r/jRnPxYlmfgx4vzmUeh4 OFTcq4AY3Kslu4VFlt8wimpmpSzF/ju9jTe2Q3znNxv//LmYH6VMSL2cz4CP7HDIZM6zPM Ej021NVnv5lD0FRR5h6MNMNhsaozg26MuC69nBloU4yYhY1NajemcNzITyQRmmoYlYlWE5 GK8wnHMGdMhO3OpcG/KM64ySxs2HUaj+IurKRigrrj9QMmvzMzf2c5F4gPxo2XuxIi5nqb yGEwwkGqoRPifFOTTRTRePODtrCrmc3HLubVtI92vh+4M4J+VJVImvaXCgDqHg== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=BB5oVNJJ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Spam-Score: 7.41 X-Spam-Score: 7.41 X-Migadu-Queue-Id: 27E662AE17 X-TUID: tVFySz1U6Xmn Hi, Thanks for your contribution. Several minor things. On ven., 06 janv. 2023 at 10:46, Frank Pursel wrote: > * gnu/packages/ditaa.scm: New file. Why a new file? Could you split this commit? Basically, each package addition should go to their own commit. > +(define-public java-jericho-html Why not some of the gnu/packages/java-*.scm files? Or gnu/packages/batik.scm > +(define-public java-libbatik Idem. > + (arguments > + `(#:tests? #f Please provide a comment why the tests are disabled. For example, if there is no test suite or if upstream does not provide tests, (arguments `(#:tests? #f ; no tests > +(define-public ditaa Why not in gnu/packages/graph.scm? Cheers, simon