[bug#59997] [PATCH] gnu: add minimacy

["Ludovic Courtès" <ludo@gnu.org>]

HI,

Simon Tournier <zimon.toutoune@gmail.com> skribis:

> From: Konrad Hinsen <konrad.hinsen@fastmail.net>
>
> * gnu/packages/minimacy.scm: New file.
> * gnu/packages/patches/minimacy.patch: New patch.
> * gnu/local.mk: Add them.

[...]

> diff --git a/gnu/packages/minimacy.scm b/gnu/packages/minimacy.scm
> new file mode 100644
> index 0000000000..6cfba75879
> --- /dev/null
> +++ b/gnu/packages/minimacy.scm
> @@ -0,0 +1,102 @@
> +;;; Copyright © 2022 Konrad Hinsen <konrad.hinsen@fastmail.net>

It misses the very first line.  :-)

> +    (outputs '("out"             ;core
> +               "X11"             ;for GUI programs, with X11 and ALSA
> +               "X11GL"))         ;for GUI programs, with X11, OpenGL, and ALSA

Two things: output names are lowercase by convention, and the
(unofficial) convention for the GUI output is “gui”.

Does it make sense to separate the two GUI outputs?  It seems better to
me to keep just one “gui” output with both OpenGL and non-OpenGL
thingies.  WDYT?

> +          (delete 'check))))

Rather #:tests? #f with a comment explaining why.

> +    (synopsis "Minimalist computing system")
> +    (description
> +     "Minimacy is an open-source minimalist computing technology.

s/an open-source/a/

> +It consists of a programming language (compiler plus virtual machine)
> +and a library, written such that the whole system can be fully
> +understood by a single person.  An optional extension to the virtual
> +machine adds X11 and ALSA for user interfaces, another extension
> +adds OpenGL support.")

Could you send one last revision?

Thanks!

Ludo’.