unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Simon Tournier <zimon.toutoune@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>, 62570@debbugs.gnu.org
Cc: "Ricardo Wurmus" <rekado@elephly.net>,
	"Timothy Sample" <samplet@ngyro.com>,
	"Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#62570] [PATCH 3/6] gnu: texlive-latex-bigfoot: Replace with texlive-bigfoot.
Date: Fri, 07 Apr 2023 18:48:00 +0200	[thread overview]
Message-ID: <87o7nzk5a7.fsf@gmail.com> (raw)
In-Reply-To: <20230331153226.607420-3-mail@nicolasgoaziou.fr>

Hi Nicolas, all,

Thanks, the series LGTM.

In the context of discussion about SWH coverage, see [1,2,3,4], this
change is very welcome because it factorize the package ’source’ as more
or less we discussed in [4].

1: https://yhetil.org/guix/87v8j0bqdd.fsf@gnu.org
2: https://sympa.inria.fr/sympa/arc/swh-devel/2023-03/msg00009.html
3: https://issues.guix.gnu.org/issue/43442#20
4: https://issues.guix.gnu.org/62712


Other said, that’s said… The good ol’ svn-fetch,

> -    (source (origin
> -              (method svn-fetch)
> -              (uri (texlive-ref "latex" "bigfoot"))

is replaced by ’simple-texlive-package’,

> +  (let ((template (simple-texlive-package
> +                   "texlive-bigfoot"
> +                   (list "doc/latex/bigfoot/"
> +                         "source/latex/bigfoot/"
> +                         "tex/latex/bigfoot/")
> +                   (base32
> +                    "140b4bbjcgajd1flznmi3ga6lx5pna2nxybr2dqm9515lny8gwf0"))))
> +    (package
> +      (inherit template)

However, it goes from this,

    $ tree -L 6 $(guix build --no-grafts texlive-latex-bigfoot -S)
    /gnu/store/z9kc9qbg40nl0azivpmfmhrnqb6dnmqm-texlive-latex-bigfoot-59745-checkout
    ├── bigfoot.drv
    ├── bigfoot.dtx
    ├── bigfoot.ins
    ├── perpage.drv
    ├── perpage.dtx
    ├── suffix.drv
    └── suffix.dtx

    0 directories, 7 files

to that,

    $ tree -L 6 $(./pre-inst-env guix build --no-grafts texlive-latex-bigfoot -S)
    guix build: package 'texlive-latex-bigfoot' has been superseded by 'texlive-bigfoot'
    /gnu/store/rws86c5hi1r25f14h95hiqzgcw8rbir2-texlive-bigfoot-59745-checkout
    ├── doc
    │   └── latex
    │       └── bigfoot
    │           ├── bigfoot.pdf
    │           ├── COPYING
    │           ├── Makefile
    │           ├── perpage.pdf
    │           ├── README
    │           └── suffix.pdf
    ├── source
    │   └── latex
    │       └── bigfoot
    │           ├── bigfoot.drv
    │           ├── bigfoot.dtx
    │           ├── bigfoot.ins
    │           ├── perpage.drv
    │           ├── perpage.dtx
    │           ├── suffix.drv
    │           └── suffix.dtx
    └── tex
        └── latex
            └── bigfoot
                ├── bigfoot.sty
                ├── perpage.sty
                └── suffix.sty

    9 directories, 16 files


Here, I have two questions (unrelated to the patch series ;-)):

 1. Does it make sense to keep the PDF and .sty files?
 2. Which of the both is the closest of upstream structure?

    Assuming SWH ingested TUG and other related TeX sources, which is
    still WIP AFAIK, it would be simpler if we store an identifier
    (swhid or others) that we can query via SWH API without parsing and
    rebuild from their content the files we need for the checksum.


Cheers,
simon




  reply	other threads:[~2023-04-07 16:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-31 15:30 [bug#62570] [PATCH 0/6] Fix name and dependencies of a few Texlive packages Nicolas Goaziou
2023-03-31 15:32 ` [bug#62570] [PATCH 1/6] gnu: Add texlive-ncctools Nicolas Goaziou
2023-03-31 15:32   ` [bug#62570] [PATCH 2/6] gnu: Add texlive-relsize Nicolas Goaziou
2023-03-31 15:32   ` [bug#62570] [PATCH 3/6] gnu: texlive-latex-bigfoot: Replace with texlive-bigfoot Nicolas Goaziou
2023-04-07 16:48     ` Simon Tournier [this message]
2023-04-07 18:01       ` Nicolas Goaziou
2023-04-08  9:35         ` Simon Tournier
2023-04-08 13:07           ` Nicolas Goaziou
2023-04-18 13:30             ` bug#62570: " Nicolas Goaziou
2023-03-31 15:32   ` [bug#62570] [PATCH 4/6] gnu: texlive-latex-acronym: Replace with texlive-acronym Nicolas Goaziou
2023-03-31 15:32   ` [bug#62570] [PATCH 5/6] gnu: texlive-latex-totcount: Replace with texlive-totcount Nicolas Goaziou
2023-03-31 15:32   ` [bug#62570] [PATCH 6/6] gnu: texlive-latex-lastpage: Replace with texlive-lastpage Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7nzk5a7.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=62570@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    --cc=rekado@elephly.net \
    --cc=samplet@ngyro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).