From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Sharlatan Hellseher <sharlatanus@gmail.com>
Cc: 62801@debbugs.gnu.org
Subject: [bug#62801] [PATCH 0/4]: gnu: python-astroalign: Update to 2.4.2.
Date: Wed, 19 Apr 2023 21:48:40 -0400 [thread overview]
Message-ID: <87o7nj1fyf.fsf_-_@gmail.com> (raw)
In-Reply-To: <20230412210529.30189-1-sharlatanus@gmail.com> (Sharlatan Hellseher's message of "Wed, 12 Apr 2023 22:05:26 +0100")
Hello,
Sharlatan Hellseher <sharlatanus@gmail.com> writes:
> * gnu/packages/astronomy.scm (python-astroscrappy): New variable.
> ---
> gnu/packages/astronomy.scm | 48 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 48 insertions(+)
>
> diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
> index db290f5987..f162be6006 100644
> --- a/gnu/packages/astronomy.scm
> +++ b/gnu/packages/astronomy.scm
> @@ -1302,6 +1302,54 @@ (define-public python-astroquery
> to access online Astronomical data. Each web service has its own sub-package.")
> (license license:bsd-3)))
>
> +(define-public python-astroscrappy
> + (package
> + (name "python-astroscrappy")
> + (version "1.1.0")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "astroscrappy" version))
> + (sha256
> + (base32 "0shmfilvzpmlwz4fh0bx4kqmzr0y39fgga6vipxb5d1rx1y6q6by"))))
> + (build-system pyproject-build-system)
> + (arguments
> + (list
> + #:phases
> + #~(modify-phases %standard-phases
> + (add-after 'unpack 'preparations
> + (lambda _ (setenv "HOME" "/tmp")))
> + (add-before 'install 'writable-compiler
> + (lambda _ (make-file-writable "astroscrappy/_compiler.c")))
> + (add-before 'check 'writable-compiler
> + (lambda _ (make-file-writable "astroscrappy/_compiler.c")))
> + (replace 'check
> + (lambda* (#:key inputs outputs tests? #:allow-other-keys)
> + (when tests?
> + (add-installed-pythonpath inputs outputs)
The 'add-install-to-pythonpath' is not needed; this is implicitly
already done before the check phase in the python build systems.
> + ;; Extensions have to be rebuilt before running the tests.
> + (invoke "python" "setup.py" "build_ext" "--inplace")
I think it'd be a bit cleaner to move this in a distinct phase named
e.g. 'build-extension. Then the check phase of pyproject-build-system
could be left alone. If the '--pyargs' argument is really required, it
can be provided via the #:test-flags #~(list "--pyargs" "astroscrappy")
argument.
> + (invoke "python" "-m" "pytest" "--pyargs" "astroscrappy")))))))
> + (native-inputs
> + (list python-cython
> + python-extension-helpers
> + python-h5py
> + python-pandas
> + python-pytest-astropy
> + python-scikit-image
> + python-setuptools-scm
> + python-scipy))
The last input should appear earlier (sort).
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-04-20 3:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 20:57 [bug#62801] [PATCH 0/4]: gnu: python-astroalign: Update to 2.4.2 Sharlatan Hellseher
2023-04-12 21:05 ` [bug#62801] [PATCH 1/4] gnu: Add python-astroscrappy Sharlatan Hellseher
2023-04-12 21:05 ` [bug#62801] [PATCH 2/4] gnu: Add python-memory-profiler Sharlatan Hellseher
2023-04-20 1:52 ` [bug#62801] [PATCH 0/4]: gnu: python-astroalign: Update to 2.4.2 Maxim Cournoyer
2023-04-12 21:05 ` [bug#62801] [PATCH 3/4] gnu: Add python-ccdproc Sharlatan Hellseher
2023-04-20 1:55 ` [bug#62801] [PATCH 0/4]: gnu: python-astroalign: Update to 2.4.2 Maxim Cournoyer
2023-04-12 21:05 ` [bug#62801] [PATCH 4/4] " Sharlatan Hellseher
2023-04-20 1:58 ` [bug#62801] [PATCH 0/4]: " Maxim Cournoyer
2023-04-20 1:48 ` Maxim Cournoyer [this message]
2023-04-18 20:21 ` [bug#62801] Sharlatan Hellseher
2023-04-24 17:41 ` [bug#62801] Sharlatan Hellseher
2023-05-07 14:40 ` bug#62801: Maxim Cournoyer
2023-04-21 20:04 ` [bug#62801] [PATCH v2 1/4] gnu: Add python-astroscrappy Sharlatan Hellseher
2023-04-21 20:04 ` [bug#62801] [PATCH v2 2/4] gnu: Add python-memory-profiler Sharlatan Hellseher
2023-04-21 20:04 ` [bug#62801] [PATCH v2 3/4] gnu: Add python-ccdproc Sharlatan Hellseher
2023-04-21 20:04 ` [bug#62801] [PATCH v2 4/4] gnu: python-astroalign: Update to 2.4.2 Sharlatan Hellseher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7nj1fyf.fsf_-_@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=62801@debbugs.gnu.org \
--cc=sharlatanus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).