From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id iGjJLNSoSGQnxgAASxT56A (envelope-from ) for ; Wed, 26 Apr 2023 06:30:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id AJvtK9SoSGTaCAAAG6o9tA (envelope-from ) for ; Wed, 26 Apr 2023 06:30:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C21B62CC86 for ; Wed, 26 Apr 2023 06:30:11 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1prWn7-0003yV-Sr; Wed, 26 Apr 2023 00:30:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prWn5-0003y5-Hw for guix-patches@gnu.org; Wed, 26 Apr 2023 00:30:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1prWn5-0003kW-7p for guix-patches@gnu.org; Wed, 26 Apr 2023 00:30:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1prWn5-0007S1-1l for guix-patches@gnu.org; Wed, 26 Apr 2023 00:30:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63071] [PATCH] gnu: Add emacs-riscv-mode. Resent-From: Andrew Tropin Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 26 Apr 2023 04:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63071 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Gabriel Wicki , 63071@debbugs.gnu.org Cc: Liliana Marie Prikler Received: via spool by 63071-submit@debbugs.gnu.org id=B63071.168248335528554 (code B ref 63071); Wed, 26 Apr 2023 04:30:02 +0000 Received: (at 63071) by debbugs.gnu.org; 26 Apr 2023 04:29:15 +0000 Received: from localhost ([127.0.0.1]:53948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prWmI-0007QT-Qh for submit@debbugs.gnu.org; Wed, 26 Apr 2023 00:29:15 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:54847) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prWmF-0007QB-AO for 63071@debbugs.gnu.org; Wed, 26 Apr 2023 00:29:13 -0400 Received: (Authenticated sender: andrew@trop.in) by mail.gandi.net (Postfix) with ESMTPSA id 29268C0002; Wed, 26 Apr 2023 04:29:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=gm1; t=1682483344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n1QQGCfpK7qggRhDWXlBMXxyZ6u7NuSTggYYTkJytrg=; b=h+GnhNmhxNzSFEyqB6YQwpJrbyvxuHBooEwph08p/yX6YMUCkAgs/eeZuqQCOZlqCYD8P3 5ITb9PRmlu7ihXWDXOuWDh3a5CdOIbxjQ0ye89am24C8DqaKpP5/nIyeuaFXLJd+ywCgxn wRFewQdr5103k61ZfbOx0hjhgElXo2X14RwGgRYijnFDtQa9htxtTbJ7J0wGc1uu6+KHRb VLGO6ivZSLKBO37oEJN+n/ivyuWbiEZfNiC6hU0NM/ODY+67k9Nbvim7XEiTUq6SzUZtdW Kn35qvZa+HsTf2Ngc/vBbrQWI0cLPlSOrtvHeLnLznRkjc1dw+ScBxko6NeQjw== From: Andrew Tropin In-Reply-To: <6e8f134d43202eb43e72b1be2ac5dd520968f75d.camel@erlikon.ch> References: <6e8f134d43202eb43e72b1be2ac5dd520968f75d.camel@erlikon.ch> Date: Wed, 26 Apr 2023 08:29:00 +0400 Message-ID: <87o7nbe06r.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1682483412; a=rsa-sha256; cv=none; b=QnfxJVhKKPhxGiCTPmH3Bo0DqbgGSPuVyfpzXTZYcpljM7prP3bP57ALPXvAzNFb3k5T02 oaXIsEETYjQoUrzcm30+vj5Adxop6EjZdDnISHVMmDMP1cdwp2KlJ1b1bZqx4o4ShqTfCy vz6R5kr7bv+Bff6EeyZm2hGW35h+8NUUrX0E0LTyYILGY8pUp+9K1fkESnbJLxI4ALRN9C P97AR5loqY4VPyndD2KfZFlvU5aiMAX6/0AGuVtMw+uYpm2qRGjZjIyeFmibFZPvuYckZO C7QrMUOUQDEFdtZcZEtk5mh6Dfm6fDepxNf2fClJVdddpkp9nP2L4aYUcr3JJQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop.in header.s=gm1 header.b=h+GnhNmh; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1682483412; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=n1QQGCfpK7qggRhDWXlBMXxyZ6u7NuSTggYYTkJytrg=; b=DR4ySwSA7F6gk/Kgg0PJ8w2tOA2csEPu2+MXE9WaO9IKEgJa0lSS/9eyLO+K7ZiDraFOdf gltPjnCWAXSualEYrysoW8j23YLTiZNzhzXCaL7wt2AH6lnM51+IlB7uUVMwe/NsGHW0rx SVVJ4tBqQfHtrMyMt3dfuluop697rsov6hQAvbo9sfb/PAeAqkc5OK8UfrTr6gfG8QZrAB 5wVnzT6tgjd4J/rsxg5Zk3c6Y9DtN88mwtNZUNkHtvMpLW+8rmYLAYp0jOkt/PxdaCB6Ne CIiTfCrrfvEnrm66nnHcwidrcuRCR9zhQxHclBc3jbrGdgn75NL0nudFcKvLWQ== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop.in header.s=gm1 header.b=h+GnhNmh; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.41 X-Spam-Score: -1.41 X-Migadu-Queue-Id: C21B62CC86 X-TUID: XnGD5eiCnJAw --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2023-04-25 17:48, Gabriel Wicki wrote: > * gnu/packages/emacs-xyz.scm (emacs-riscv-mode): New variable. > --- > Hi Gabriel, > > your patch didn't apply cleanly thanks to some coding issues, but I got > them to work with a little bit of work. Below is an expanded patch that > also makes sure that spike actually exists. It also uses 0.1 as base > version, taken from riscv-mode.el. > > Cheers, > Liliana > > gnu/packages/emacs-xyz.scm | 35 +++++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index 7c8af093fc..3d4b9998ce 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -127,6 +127,7 @@ > ;;; Copyright =C2=A9 2023 Dominik Delgado Steuter > ;;; Copyright =C2=A9 2023 Juliana Sims > ;;; Copyright =C2=A9 2023 Evgeny Pisemsky > +;;; Copyright =C2=A9 2023 Gabriel Wicki > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -259,6 +260,7 @@ (define-module (gnu packages emacs-xyz) > #:use-module (gnu packages erlang) > #:use-module (gnu packages statistics) > #:use-module (gnu packages libcanberra) > + #:use-module (gnu packages virtualization) > #:use-module (gnu packages web-browsers) > #:use-module (gnu packages wget) > #:use-module (guix utils) > @@ -35854,6 +35856,39 @@ (define-public emacs-nasm-mode > Unlike Emacs' generic ASM mode, it understands NASM-specific syntax.") > (license license:unlicense))) >=20=20 > +(define-public emacs-riscv-mode > + (let ((commit "8e335b9c93de93ed8dd063d702b0f5ad48eef6d7") > + (revision "1")) Revision should be 0 here, everything else LGTM. > + (package > + (name "emacs-riscv-mode") > + (version (git-version "0.1" revision commit)) > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/AdamNiederer/riscv-mode") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "06jlf84mx49scw3zm1wjj25zinr2yr9abiyh83rli78wb1hdc0l4"= )))) > + (build-system emacs-build-system) > + (arguments > + (list #:phases > + #~(modify-phases %standard-phases > + (add-after 'unpack 'hardcode-spike > + (lambda* (#:key inputs #:allow-other-keys) > + (emacs-substitute-variables "riscv-mode.el" > + ("riscv-interpreter" > + (search-input-file inputs "bin/spike")))))))) > + (inputs (list spike)) > + (home-page "https://github.com/AdamNiederer/riscv-mode") > + (synopsis "Emacs major mode for RISC-V assembly") > + (description > + "RISC-V mode is a major mode for editing RISC-V assembly programs. > +It includes syntax highlighting, syntactic indentation and code evaluati= on > +with spike.") > + (license license:gpl3+)))) > + > (define-public emacs-validate-html > ;; XXX: Upstream did not tag commits yet. However, commit below match= es the > ;; last version bump. Version is extracted from the keyword in main f= ile. =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmRIqIwACgkQIgjSCVjB 3rD0vQ//TCskaY+2bhrIfrb1qZkxSRUNK4khuqaT0QrkjcGZlyCf6Q/LVQJn//dz sLtzsxQVQ3HWJH5ttj0ir9v3yEKQdoIItM+bwxzijGkFMAE8N5Lmq7GT92KEzkI+ djRrHANGjoK7BjNptlXqL/D2lFN6+FEFfFOfoHzt3XmPK097r64wmMcJnWc1pZ8H cJdxlIxNT7msKoKhs9ZxI6rEGb6DKMrCyR9KnucoAjIncE3G8YMwA1JN/+ZIdues n7j4G/yEofo7dtUg0Xjv3KkMvQibax71Dxsx9f0bsH7EwVanFetXox1W97iLYeXk BoTqlWQdF3ZBxxvIn2OnXCKc5WLjcNaJeZZx25MXKBIBoaHRR8Dr6VINuXXb1Vgv idDDBd7DwMeF7P2ISBF8waWQg3fa33FYyKxVUyDSX6HKZeuDGZibcQpV1mz2C+79 t1pZTVnBMpWhuCPyQOjLwEJDLLDXGCfiuKqJ+m0soD+OG4Wzq9AM+9Ajd2SjTY0l IzqE3pm/CER1mEl6S7auSdSBh72Gh37DUCP1GTe3vs35yEPeXdkL9MP6wRAtkaNP Hwotw34AW09mJ9h5DYslE0hhr654PtbqvQgnpfXeg16ZT8zvka28Xzuot/pEFEd0 UpsFUVeQvhmw3DJj8MRuOkVi/ZVyLThYcTLSHdaiAg+/DOezeZo= =nVWV -----END PGP SIGNATURE----- --=-=-=--