From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id GAVSO8UMV2Q15QAASxT56A (envelope-from ) for ; Sun, 07 May 2023 04:28:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id sPM0O8UMV2R2OAAAauVa8A (envelope-from ) for ; Sun, 07 May 2023 04:28:21 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2008430392 for ; Sun, 7 May 2023 04:28:20 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvU84-0003i7-OW; Sat, 06 May 2023 22:28:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvU82-0003hw-RK for guix-patches@gnu.org; Sat, 06 May 2023 22:28:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvU82-0004n3-IT for guix-patches@gnu.org; Sat, 06 May 2023 22:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvU82-0000RB-1N for guix-patches@gnu.org; Sat, 06 May 2023 22:28:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63215] [PATCH mumi 0/2] Cc all issue participants when sending email Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 07 May 2023 02:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63215 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Arun Isaac Cc: 63215@debbugs.gnu.org Received: via spool by 63215-submit@debbugs.gnu.org id=B63215.16834264691660 (code B ref 63215); Sun, 07 May 2023 02:28:02 +0000 Received: (at 63215) by debbugs.gnu.org; 7 May 2023 02:27:49 +0000 Received: from localhost ([127.0.0.1]:36078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvU7o-0000Qi-LC for submit@debbugs.gnu.org; Sat, 06 May 2023 22:27:48 -0400 Received: from mail-qk1-f177.google.com ([209.85.222.177]:54352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvU7j-0000QR-Dt for 63215@debbugs.gnu.org; Sat, 06 May 2023 22:27:47 -0400 Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-7575d85d562so81012385a.0 for <63215@debbugs.gnu.org>; Sat, 06 May 2023 19:27:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683426457; x=1686018457; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=T9KvhEGioD8TRASPd00qIjqDYavobD86+OPqsAjT5Cs=; b=IqU/Zlv+1rQP8wIPkFvK5EYzAezUBUBfPpHJFTZuJKo+yI5ZJKGD7d2yc2ukJX7N/E NMhqrS3sZy7J0ww14rK0T4oVzur7cuJ5vvK0IhEiR/lKJu/K1iASAhaV71NEpwqYJi8n z5WtcM3V1I2WWusJLxq03KxUNX4S4+do+VR2zz94aMfjuV77MFhfn0/m8KaOKn4DZNt7 gzDash2Q3IARzpqwKs4TU8lmyrrAQ22SRVv+ExOFdgvhkaNnbdyKQxgeiJDPuRMqh5KF vNA5zr+3+02GDGBVYC/8o5nQ95U0viOuTb+pxRvMBAgq0UcVXnBUZHjy5h29F6hJHOGK 86xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683426457; x=1686018457; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T9KvhEGioD8TRASPd00qIjqDYavobD86+OPqsAjT5Cs=; b=LyvMK9bUMMn0iUZoL2em7fvhBFVxeyg3r/jphQVPXTpW2j/dx5j68zWhJhACux8miw xuTlMjrvj1bjjQ8PEwCHUe4rUfTWU1tpjk6Jnk/lGukjoVaf3HCGDJETbBcCQMt9PJ6b 3KQDkKQJD9+kUXkT9Ni6c44/KeyirW6VfwYr9VNxgebB86j5rFsOdZ5XQsYEaWVwyA8y IcjXkTL9MA2WHa/ujRM0u3nIo46jOgpNocxO1Z7G4ZMBURVq69UtgciUMASblsVfHmAK OPR/MAThjuvdNUAHYvqhkXIKNfEfp9xUuxtxKwlb173z0IvDX/p3LgvGj08njCr/foHd oXWA== X-Gm-Message-State: AC+VfDxyEAtqQyZnMsVBiDSs9/kqX/HaOtwZHQI59k/PTsuB7OHTPoOh 7O68YptfeYHy97bA65bpnMoxo5V9ND0= X-Google-Smtp-Source: ACHHUZ45Niyt+HVKXyi3SyYf+3Cnl32/B7apIubHnyX9zNn2ecoqevUb4Ri5mQBseepop2rFgY3ARw== X-Received: by 2002:a05:6214:2409:b0:61b:5b4b:2a4 with SMTP id fv9-20020a056214240900b0061b5b4b02a4mr10910386qvb.29.1683426457443; Sat, 06 May 2023 19:27:37 -0700 (PDT) Received: from hurd (dsl-205-236-230-162.b2b2c.ca. [205.236.230.162]) by smtp.gmail.com with ESMTPSA id t17-20020a0ce2d1000000b0061b5d3a61aesm1778389qvl.9.2023.05.06.19.27.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 May 2023 19:27:36 -0700 (PDT) From: Maxim Cournoyer References: <20230501225158.18612-1-arunisaac@systemreboot.net> <20230501225158.18612-3-arunisaac@systemreboot.net> <87y1m6yw80.fsf_-_@gmail.com> <87jzxnbkqt.fsf@systemreboot.net> <87a5yic3mw.fsf@systemreboot.net> <871qju4urk.fsf@gmail.com> <87zg6h9jph.fsf@systemreboot.net> Date: Sat, 06 May 2023 22:27:35 -0400 In-Reply-To: <87zg6h9jph.fsf@systemreboot.net> (Arun Isaac's message of "Sat, 06 May 2023 23:30:18 +0100") Message-ID: <87o7mw3mg8.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683426500; a=rsa-sha256; cv=none; b=atDpuL7+kQ9x+oo/+FL51s4kIEAKWCvD92I12tmSNhGyPw9niravmRLVMSZBgniy7Hxdgt OrHxYNZ9cjtsbkp11+xocNlLtoYNepR5lPtspilnyJUol51E+332C+sKBLfg1o8105pAhA B/COmZmhiQtdDCHnPTNbYMiLRK57cWMw0R/kupJOmhv4s+EA4HsFDdSDgPfAgj0UmDaIPS gK9X3rYTVgLSxRIbG1GwGWs5z/N34m/3VS4bxBW4xPIYbF+y89wQWQ8lQHV+b3ITExAUnm J2JobHbfPlO4XJ9wdkg7NzkdooO/Q/N5QAP2QFYFzVBUkkTOD7XBXnf5AWwBcA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b="IqU/Zlv+"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683426500; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=T9KvhEGioD8TRASPd00qIjqDYavobD86+OPqsAjT5Cs=; b=KZ4dsunsAMJCdSW2n+64APo0/mNzWAouW+iYIQEnYtLL/MdDVzpCZC6cNtyKimIo0DvcYQ +WgYGJJ7PItNoIn12pcSLSGkUII29T97kxyh+jbygEgKcoIp8dYAxdtmgvGhZSmWqYct9L roVXL9ktp19W65VSrxMmKiiip2NlcDFi60Oi83hFcl6b0X+thBrfNFqg6GH3D9dUaMKaAb jyruxbAf/CHz/ooX7X6i7/dNh9kDeJIECVE8mEZQzlPFFtlUb7pQ2l7cnt1viwSF7G91uh SQUvEuynrRvpYscGz2btt4QtsDU4Z47gHYHyJi+D2AZT7N3NdXR/rX1b3H9/Bg== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b="IqU/Zlv+"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.30 X-Spam-Score: 7.30 X-Migadu-Queue-Id: 2008430392 X-TUID: SpdU/xzqvJo1 Hi Arun, Arun Isaac writes: > Hi Maxim, > >> If you meant that it's mumi instead of git that should call >> etc/teams.scm, it makes sense. I'm not sure the functionality of >> teams.scm proper should be moved wholesale into mumi, as it's useful >> outside of mumi (for plain git users, say). > > I see your point about keeping things working for plain git users. Makes > sense. > >> Mumi could invoke etc/teams.scm to produce the list of team members for >> the changes involved, add any missing collaborators retrieved from the >> message data to the set (avoiding duplicates), then format the >> 'X-Debbugs-CC' header with comma-separated values. It should then >> invoke git with the '--no-header-cmd' option to avoid teams.scm being >> called again. > > mumi invoking etc/teams.scm is not so nice since that means coupling > mumi to the specific repository layout of guix. This reduces its > generality to other projects, say skribilo. Perhaps it could use the value of `git config sendemail.headerCmd` to figure out which script already produces X-Debbugs-CC headers, if any. > Maybe, let's just keep multiple X-Debbugs-Cc headers for now. Let mumi > and teams.scm be unaware of each other for now. We can revisit the > question of coupling them later. OK, sounds good to me. -- Thanks, Maxim