unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 63215@debbugs.gnu.org
Subject: [bug#63215] [PATCH mumi 0/2] Cc all issue participants when sending email
Date: Sat, 06 May 2023 22:27:35 -0400	[thread overview]
Message-ID: <87o7mw3mg8.fsf@gmail.com> (raw)
In-Reply-To: <87zg6h9jph.fsf@systemreboot.net> (Arun Isaac's message of "Sat,  06 May 2023 23:30:18 +0100")

Hi Arun,

Arun Isaac <arunisaac@systemreboot.net> writes:

> Hi Maxim,
>
>> If you meant that it's mumi instead of git that should call
>> etc/teams.scm, it makes sense.  I'm not sure the functionality of
>> teams.scm proper should be moved wholesale into mumi, as it's useful
>> outside of mumi (for plain git users, say).
>
> I see your point about keeping things working for plain git users. Makes
> sense.
>
>> Mumi could invoke etc/teams.scm to produce the list of team members for
>> the changes involved, add any missing collaborators retrieved from the
>> message data to the set (avoiding duplicates), then format the
>> 'X-Debbugs-CC' header with comma-separated values.  It should then
>> invoke git with the '--no-header-cmd' option to avoid teams.scm being
>> called again.
>
> mumi invoking etc/teams.scm is not so nice since that means coupling
> mumi to the specific repository layout of guix. This reduces its
> generality to other projects, say skribilo.

Perhaps it could use the value of `git config sendemail.headerCmd` to
figure out which script already produces X-Debbugs-CC headers, if any.

> Maybe, let's just keep multiple X-Debbugs-Cc headers for now. Let mumi
> and teams.scm be unaware of each other for now. We can revisit the
> question of coupling them later.

OK, sounds good to me.

-- 
Thanks,
Maxim




  reply	other threads:[~2023-05-07  2:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-01 20:56 [bug#63215] [PATCH mumi 0/2] Cc all issue participants when sending email Arun Isaac
2023-05-01 21:01 ` [bug#63215] [PATCH mumi 1/2] client: Support passing options to git send-email Arun Isaac
2023-05-01 21:01   ` [bug#63215] [PATCH mumi 2/2] client: Cc issue participants when sending email Arun Isaac
2023-05-01 22:51 ` [bug#63215] [PATCH v2 mumi 0/2] Cc all issue participants Arun Isaac
2023-05-01 22:51   ` [bug#63215] [PATCH v2 mumi 1/2] client: Support passing options to git send-email Arun Isaac
2023-05-01 22:51   ` [bug#63215] [PATCH v2 mumi 2/2] client: Cc issue participants when sending email Arun Isaac
2023-05-03  2:39     ` [bug#63215] [PATCH mumi 0/2] Cc all " Maxim Cournoyer
2023-05-05  2:00       ` Arun Isaac
2023-05-05 13:24         ` Arun Isaac
2023-05-05 16:18           ` Maxim Cournoyer
2023-05-06 22:30             ` Arun Isaac
2023-05-07  2:27               ` Maxim Cournoyer [this message]
2023-05-07 11:27                 ` bug#63215: " Arun Isaac
2023-05-06 22:35 ` [bug#63215] [PATCH 1/2] client: Support passing options to git send-email Arun Isaac
2023-05-06 22:35   ` [bug#63215] [PATCH 2/2] client: Cc issue participants when sending email Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7mw3mg8.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=63215@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).