From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id kCtQFzZf8WTMzQAAauVa8A:P1 (envelope-from ) for ; Fri, 01 Sep 2023 05:49:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id kCtQFzZf8WTMzQAAauVa8A (envelope-from ) for ; Fri, 01 Sep 2023 05:49:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 03D90364D4 for ; Fri, 1 Sep 2023 05:49:10 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b="TbIU3/Tc"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693540150; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HPrlgDP2TBz6zT6CtPA1KSn9ZfhPI+Gjz1ks6Y1JRZA=; b=C4wZEpowIdGb9sa9XbhgZ7HpBY6HlX+LKsBTi/x5m/7EgHVsuVR44470i/1PkVqwUuSCCo 1qkvzw/QDZr100Eavkv/Gt7ie0XvFtGVVCHmyprJt5kBgzuvbHSjTNu1GNql5dqGwOtmtG 58W/A3s5AOQdPaDRYeXn5wBpws5hzkigmwdXwCwRhvH+pHzem79MIhRAQQMlaV1rYuO/Iv uS3JWOFIpb5oG9efRFCSGeSvUEtNwcq08/pk1Ur/PHljF4jI1HKFtLfPIr6jvE5K8rFZc1 xLvqO0oCDQM/vlP96tBGCG2Za/SPess4oWHO5OElIniOUSIULa/WXhtgXMVPHA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693540150; a=rsa-sha256; cv=none; b=DR1Envj3zbf/ObeWmf+Mere61j+8OfvfK/0m7jWRmJ0nWD2xQaNNLHT9Z9r6Cb20/D69N3 V09qm1oiyzoAJJrVdqrlXIXRs/s578Uq+PT55sQ4Ui6wJjsnxtCgzT9mKuzIn3oRl1Mq0U JjrfyGVPtXC6nX5k5JaxhkFOeE4K1y5Q+kmWSDTXNZuKQQnZzx5q2XquAYC6s6t9/uMgyP 1hw+Swj8YIQ7ZePVEoWWS0GSVcjou7SxwmUTW9rvDlaZCI3fT3muahokZf7AdkUUzbYVkh izKefHyQb4bu3mzT58XxHlpXxvLkJSd3LSy12YABPs3/0VnwcuppnUiisnCUyQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b="TbIU3/Tc"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbv9S-0000no-Bl; Thu, 31 Aug 2023 23:48:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbv9Q-0000gT-Vz for guix-patches@gnu.org; Thu, 31 Aug 2023 23:48:53 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbv9Q-0001Q1-Nk for guix-patches@gnu.org; Thu, 31 Aug 2023 23:48:52 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qbv9Z-0007sf-K1 for guix-patches@gnu.org; Thu, 31 Aug 2023 23:49:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65654] [PATCH] gnu: dbus-cxx: Update to 2.4.0. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 01 Sep 2023 03:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65654 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: iyzsong@envs.net Cc: Raghav Gururajan , =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= , Liliana Marie Prikler , 65654@debbugs.gnu.org Received: via spool by 65654-submit@debbugs.gnu.org id=B65654.169354011430210 (code B ref 65654); Fri, 01 Sep 2023 03:49:01 +0000 Received: (at 65654) by debbugs.gnu.org; 1 Sep 2023 03:48:34 +0000 Received: from localhost ([127.0.0.1]:59590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbv97-0007r7-64 for submit@debbugs.gnu.org; Thu, 31 Aug 2023 23:48:33 -0400 Received: from mail-qv1-xf33.google.com ([2607:f8b0:4864:20::f33]:60640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbv95-0007qI-42 for 65654@debbugs.gnu.org; Thu, 31 Aug 2023 23:48:31 -0400 Received: by mail-qv1-xf33.google.com with SMTP id 6a1803df08f44-64b8e1c739aso8823416d6.0 for <65654@debbugs.gnu.org>; Thu, 31 Aug 2023 20:48:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693540096; x=1694144896; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=HPrlgDP2TBz6zT6CtPA1KSn9ZfhPI+Gjz1ks6Y1JRZA=; b=TbIU3/TcNPasLBRiSj2w/vVQeGeYGcQ1ygNasYrMRCzECt5P2RHCPC1APL3h0YvKuW V23HA7aLg5Ct7WigeFNOaAG6idP8VUyVf28Z/1yghl6uHWK1zX0Uo5KIuJ85Luhmo1kG Dgw8kxeAOT1j/pFibGewUWWJnDy3ryXcyC+TlMT2BrpFZbHbSgxL9Ab3JLisN1zBfwwL g9PxMwNo5xwexcZjb63KR4ZFtvYornirY+gideJYGl3a1SYRhp/6M7Q+dk3kR1aFBlwr QxX31eG9+tpMvibGsk2IhrzZ7N2GZjhRbXv5R8x90ijXk2nf+tSfn6GUfCPncWkPbD7J VDGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693540096; x=1694144896; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=HPrlgDP2TBz6zT6CtPA1KSn9ZfhPI+Gjz1ks6Y1JRZA=; b=aZbfScGxerOkt+drxQEXVsoAyyq7tU15DRLErAuouu3F1PcWER2CvCm0igG8uDHxHX rMczv+TlAYFRQGh0HYGGPdjLWzDiX5WQqrJez0Z5KyfUP5nZE9zYAklRgQ3QEXFKUa7R xUEyf2oF8EvQphl9OtZ2Jt5BwtiEJfh+zBw+gceWFN8Wk07OF7p26bhPfWPC4ztpYduL QmlO/17ZC1izhGSgTj592jCG7y1gnDwY36we0jg4/uLbtGMt9dNHnOuXzkmi2ZyQarpJ kHxnuFdRpAkSGxiiAFdorXqyoCJz3j2p6FFL5yvFdrYLgQm++VuqbOHg+4kVOmvRj6ii KfDg== X-Gm-Message-State: AOJu0YwcXt9UEQaZchliTGPbzmlUQVRnki10uKVEIVD+DGlhULLSd60i msHfroxY4Mr0FDaxr+wT2e2htHptDZQ= X-Google-Smtp-Source: AGHT+IF7Yp/tPXGKFgk/nzbubARl5zeUAA9+t2Bw/TdtvqJMe/kvdAu57xpweMWJE0UBfVe8s/Tkkw== X-Received: by 2002:a0c:8d4a:0:b0:630:198c:3c60 with SMTP id s10-20020a0c8d4a000000b00630198c3c60mr1199804qvb.23.1693540096208; Thu, 31 Aug 2023 20:48:16 -0700 (PDT) Received: from hurd (dsl-10-128-23.b2b2c.ca. [72.10.128.23]) by smtp.gmail.com with ESMTPSA id a22-20020a0cb356000000b0064f5d70d072sm1136983qvf.37.2023.08.31.20.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Aug 2023 20:48:15 -0700 (PDT) From: Maxim Cournoyer References: <5686dc3309451165e7875231057a98030399a085.1693479069.git.iyzsong@member.fsf.org> Date: Thu, 31 Aug 2023 23:48:14 -0400 In-Reply-To: <5686dc3309451165e7875231057a98030399a085.1693479069.git.iyzsong@member.fsf.org> (iyzsong@envs.net's message of "Thu, 31 Aug 2023 18:51:14 +0800") Message-ID: <87o7im5zb5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 4.28 X-Spam-Score: 4.28 X-Migadu-Queue-Id: 03D90364D4 X-Migadu-Scanner: mx2.migadu.com X-TUID: sltj9cBtOio6 Hi =E5=AE=8B=E6=96=87=E6=AD=A6! iyzsong@envs.net writes: > From: =E5=AE=8B=E6=96=87=E6=AD=A6 > > * gnu/packages/glib.scm (dbus-cxx): Update to 2.4.0. > [source]: Switch to git-fetch. > [arguments]: Use g-exps. Adjust configure-flags. > Skip 'test-machine-uuid-method' test. > [inputs]: Remove python and glibmm. Move libsigc++ to... > [propagated-inputs]: ...here. Add glib. > [native-inputs]: Remove m4. > [license]: Change to lgpl3+ and bsd-3. > --- > gnu/packages/glib.scm | 36 ++++++++++++++++++++---------------- > 1 file changed, 20 insertions(+), 16 deletions(-) > > diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm > index f523706449..043d506a9e 100644 > --- a/gnu/packages/glib.scm > +++ b/gnu/packages/glib.scm > @@ -1255,26 +1255,30 @@ (define-public dbus-c++ > (define-public dbus-cxx > (package > (name "dbus-cxx") > - (version "0.12.0") > + (version "2.4.0") Wooh, big update! > (source (origin > - (method url-fetch) > - (uri (string-append "mirror://sourceforge/dbus-cxx/dbus-cx= x/" > - version "/dbus-cxx-" version ".tar.gz"= )) > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/dbus-cxx/dbus-cxx") > + (commit version))) > + (file-name (git-file-name name version)) > (sha256 > (base32 > - "1acsgpkd9v7b9jdc79ijmh9dbdfrzgkwkaff518i3zpk7y6g5mzw"))= )) > + "0c9q2bjs4m66zq0qysyip8fnkvvjpj46rkjcvw15nhmfhzbq16ag"))= )) > (build-system cmake-build-system) > (arguments > - `(#:configure-flags '("-DENABLE_TESTS=3DON" > - "-DENABLE_TOOLS=3DON" > - "-DENABLE_GLIBMM=3DON"))) > - (inputs (list dbus > - libsigc++ > - glibmm > - python > - popt > - expat)) > - (native-inputs (list pkg-config m4)) > + (list #:configure-flags #~(list "-DBUILD_TESTING=3DON" > + "-DENABLE_TOOLS=3DON" > + "-DENABLE_GLIB_SUPPORT=3DON") > + #:phases > + #~(modify-phases %standard-phases > + (replace 'check > + (lambda _ > + ;; XXX: Missing /etc/machine-id in the build environm= ent. > + (invoke "ctest" "-E" "test-machine-uuid-method")))))) > + (propagated-inputs (list glib libsigc++)) Propagation being frowned upon, a comment should explain why it's needed here (referenced in headers or Requires of .pc files is the classic reason). > + (inputs (list dbus expat popt)) > + (native-inputs (list pkg-config)) > (synopsis "C++ wrapper for dbus") > (description "Dbus-cxx is a C++ wrapper for dbus.\n > It exposes the C API to allow direct manipulation and > @@ -1288,7 +1292,7 @@ (define-public dbus-cxx > Some codes examples can be find at: > @url{https://dbus-cxx.github.io/examples.html}") > (home-page "https://dbus-cxx.github.io/") > - (license license:gpl3))) > + (license (list license:lgpl3+ license:bsd-3)))) Perhaps add an inline comment: ;dual licensed Otherwise LGTM, assuming CI is happy. --=20 Thanks, Maxim