From: "Ludovic Courtès" <ludo@gnu.org>
To: "Sören Tempel" <soeren@soeren-tempel.net>
Cc: 65486-done@debbugs.gnu.org
Subject: bug#65486: [PATCH] syscalls: Add support for musl libc
Date: Sun, 17 Sep 2023 12:14:05 +0200 [thread overview]
Message-ID: <87o7i1yumq.fsf@gnu.org> (raw)
In-Reply-To: <3V5VFSTNLLLHJ.3BBPH8V2N2EUI@8pit.net> ("Sören Tempel"'s message of "Fri, 15 Sep 2023 12:57:29 +0200")
Hi,
Sören Tempel <soeren@soeren-tempel.net> skribis:
> From b1d478defc7f3e794974be2b9665cd4a58030569 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?S=C3=B6ren=20Tempel?= <soeren+git@soeren-tempel.net>
> Date: Thu, 14 Sep 2023 12:35:38 +0000
> Subject: [PATCH] syscalls: Add support for musl libc
>
> This commit allows using Guix on a foreign distro which uses musl libc,
> for example, Alpine Linux. Usage of musl libc is detected via a new
> musl-libc? variable using the Guile %host-type.
>
> Using the new musl-libc? variable, we can now implement musl-specific
> quirks. The two compatibility problems I encountered in this regard are
> that musl dose not export a readdir64 and statfs64 symbol. On musl,
> these two functions are implemented as CPP macros that expand to
> readdir/statfs. To workaround that, a case-distinction was added.
>
> The existing linux? variable has been modified to return true if the
> %host-system contains "linux-" in order to ensure it is true for both
> linux-gnu as well as linux-musl host systems.
>
> The patch has been tested on Alpine Linux and is already used for the
> downstream Guix package shipped in Alpine Linux's package repository.
>
> * guix/build/syscalls.scm (musl-libc?): New variable.
> * guix/build/syscalls.scm (linux?): Truth value on any linux system.
> * guix/build/syscalls.scm (readdir-procedure): Support musl libc.
> * guix/build/syscalls.scm (statfs): Support musl libc.
This version LGTM. Applied, thanks!
Ludo’.
next prev parent reply other threads:[~2023-09-17 10:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 6:33 [bug#65486] [PATCH] syscalls: Add support for musl libc soeren
2023-09-09 13:04 ` [bug#65486] [PATCH v2] " soeren
2023-09-11 21:09 ` [bug#65486] [PATCH] " Ludovic Courtès
2023-09-13 10:23 ` Sören Tempel
2023-09-13 20:39 ` Ludovic Courtès
2023-09-15 10:57 ` Sören Tempel
2023-09-17 10:14 ` Ludovic Courtès [this message]
2023-09-17 10:17 ` Ludovic Courtès
2023-09-17 11:38 ` Christopher Baines
2023-09-17 15:21 ` [bug#65486] [PATCH v3] syscalls: Consistently use existing linux? definition soeren
2023-09-17 15:21 ` [bug#65486] [PATCH v3] syscalls: Add support for musl libc soeren
2023-09-30 10:16 ` [bug#65486] [PATCH] " Sören Tempel
2023-10-10 17:15 ` Christopher Baines
2023-10-23 10:11 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7i1yumq.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=65486-done@debbugs.gnu.org \
--cc=soeren@soeren-tempel.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).