From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id eKdHKkr0C2WIQAEAauVa8A:P1 (envelope-from ) for ; Thu, 21 Sep 2023 09:44:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id eKdHKkr0C2WIQAEAauVa8A (envelope-from ) for ; Thu, 21 Sep 2023 09:44:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5B10EA4A1 for ; Thu, 21 Sep 2023 09:44:10 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=i4ImfnwW; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1695282250; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=r7jgmg7Tbqs/pkl3ag7avRFLnhRgE1sSWRSD9nHg3+E=; b=rYsoEUzwVnmfhToqf+7joGcCWzvEMZEaKksU/WsIfHYMXKDb9kNePmIL9jkvMgSQ8iHjTp rJomY2xFJ05N8zN/X7VVdNyPKe+abcnL1llT0i0JivSvkIjDvtF8CWJCCDNmUs9+DgfG0N J7kjAKjeXxW14xta0uTGTalQUKgRT8qFyvC5WwyEBs9TN7v6ycrOiIwiwBmoUOCFeUfaV1 NYHE844fhu+gFn9e+3LUEsLaB5EQ4GnU8cWdSMwEqwCKHIO72LFfk4N92MPEOQF9yzc7Rq C/Tm61DAv6aYLoioMlq0Hkf5FYfIb8uzVBNk+WoeaiiRvUdcJrKOq5NWkv5mVQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1695282250; a=rsa-sha256; cv=none; b=IXOx2MGxBkaYCcal7uJkdJ5nYUiyd1WA2/bx5YsnPM61lZTmO1OARkY/+XF41A/7o0nIKz BX4/OeFS5XpZBdtqgbbQ+VkykVeX+YsGff9EVbuazs5ANnIJSgIYVJgw5QNIMj8sSX93AR rcjzYQ2vlz/l6iIY1EvQXZS8c10mnqQbzdWtzRzjDNSa9jo21p+6XVsL5B7HDVrkX4vspu bh+XWGZL62KizDVuqeUtqbLuLDuvc0uJheohnQdnQUGqef3aKyS3aqA4wVKK9AcTtsu5bT 4iGXOIWvbpkyEix1pw2j+3RJ8MPiQo3bk6guLfYyD//16cXrAcqUHeLY5NI0Mg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=i4ImfnwW; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjELy-0007zq-Dr; Thu, 21 Sep 2023 03:44:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjELo-0007ua-Qs for guix-patches@gnu.org; Thu, 21 Sep 2023 03:43:54 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjELo-0007yQ-IP for guix-patches@gnu.org; Thu, 21 Sep 2023 03:43:52 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qjELy-0006vO-2f for guix-patches@gnu.org; Thu, 21 Sep 2023 03:44:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65866] [PATCH 0/8] Add built-in builder for Git checkouts Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 21 Sep 2023 07:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65866 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 65866@debbugs.gnu.org, Christopher Baines Received: via spool by 65866-submit@debbugs.gnu.org id=B65866.169528218826541 (code B ref 65866); Thu, 21 Sep 2023 07:44:02 +0000 Received: (at 65866) by debbugs.gnu.org; 21 Sep 2023 07:43:08 +0000 Received: from localhost ([127.0.0.1]:60970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjEL5-0006u0-V6 for submit@debbugs.gnu.org; Thu, 21 Sep 2023 03:43:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjEL4-0006tP-0d for 65866@debbugs.gnu.org; Thu, 21 Sep 2023 03:43:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjEKk-0007Xp-BD; Thu, 21 Sep 2023 03:42:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=r7jgmg7Tbqs/pkl3ag7avRFLnhRgE1sSWRSD9nHg3+E=; b=i4ImfnwWsp9UU+7eDVW/ XLJzSd8bahPsg5/kddtmEb6rJgLwGZyu+Sh1gG3rN0i2uTDyrlww2AxWErG5pj2XMe2TPZkqMCS3n AC7espyJLghVjOsQE10LcD4spAnFo5qdrIRI/MXo3Is5tPOYt+IsRdwuS9DuiXGLnK1LyvCmtj8Kz KkGU1sq0gxH9janNZEnpEiqcJ6QitnkIrymriQv+tjow9LdCVqHmvqzfCJ6R0wAMTP0iE/3oF5QB9 GxsHih90jDLzoMS4eGEMOys2uqPMng7yA+nNNQuO6M/kjCvToLzonpprge9GSoz/vtDIfLcg3g/F6 IEKR9QQCVQoZIQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <3c42634cb47dd7eaa81a198bc2d097ca74a973ed.1694441831.git.ludo@gnu.org> <8734z8698q.fsf_-_@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quintidi 5 jour =?UTF-8?Q?compl=C3=A9mentaire?= an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour des =?UTF-8?Q?R=C3=A9compenses?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 21 Sep 2023 09:42:30 +0200 In-Reply-To: <8734z8698q.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Wed, 20 Sep 2023 13:32:37 -0400") Message-ID: <87o7hwas61.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.44 X-Spam-Score: -5.44 X-Migadu-Queue-Id: 5B10EA4A1 X-Migadu-Scanner: mx0.migadu.com X-TUID: Vp6y62SERrW7 Hi Maxim, Maxim Cournoyer skribis: >> +(define* (perform-git-download drv #:optional output >> + #:key print-build-trace?) >> + "Perform the download described by DRV, a fixed-output derivation, to >> +OUTPUT. >> + >> +Note: Unless OUTPUT is #f, we don't read the value of 'out' in DRV sinc= e the >> +actual output is different from that when we're doing a 'bmCheck' or > > I'd drop the 'we's and use impersonal imperative tense or at least > 's/when we're doing/when doing/'. Noted. (That=E2=80=99s actually copied from =E2=80=98perform-download=E2= =80=99; I=E2=80=99ll fix it there as well.) >> +'bmRepair' build." >> + (derivation-let drv ((output* "out") > > I'd name this variable just 'out', for consistency with the others. No because there=E2=80=99s also a parameter called =E2=80=98output=E2=80=99= and there=E2=80=99s (or output output*). But lemme see, I should remove this optional =E2=80=98output=E2=80=99 parameter. >> +;; 'with-temporary-git-repository' relies on the 'git' command. >> +(unless (which (git-command)) (test-skip 1)) > > I'd expect the 'git' command to now be required by Autoconf at build > time, which should mean checking it here is not useful/required? That comes in a subsequent patch. >> +(test-assert "'git-download' built-in builder, not found" >> + (let* ((drv (derivation %store "git-download" >> + "builtin:git-download" '() >> + #:env-vars >> + `(("url" . "file:///does-not-exist.git") >> + ("commit" >> + . "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa= a")) >> + #:hash-algo 'sha256 >> + #:hash (gcrypt:sha256 #vu8()) >> + #:recursive? #t))) >> + (guard (c ((store-protocol-error? c) >> + (string-contains (store-protocol-error-message c) "faile= d"))) >> + (build-derivations %store (list drv)) >> + #f))) >> + > > Maybe the error message compared could be more precised, if it already > contains the necessary details? Unfortunately it doesn=E2=80=99t (same strategy as with the existing =E2=80=9Cbuiltin:download=E2=80=9D tests.) Thanks for your feedback! Ludo=E2=80=99.