From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Vivien Kraus <vivien@planete-kraus.eu>
Cc: rg@raghavgururajan.name,
Liliana Marie Prikler <liliana.prikler@gmail.com>,
66823@debbugs.gnu.org
Subject: [bug#66823] [PATCH gnome-team v2 2/6] gnu: feedbackd: Update to 0.2.1.
Date: Tue, 31 Oct 2023 10:38:43 -0400 [thread overview]
Message-ID: <87o7gesvpo.fsf@gmail.com> (raw)
In-Reply-To: <342085efe49d5efdbd6524285a7dbdee85e4f1f9.1698610511.git.vivien@planete-kraus.eu> (Vivien Kraus's message of "Sun, 29 Oct 2023 17:32:11 +0100")
Hi,
Vivien Kraus <vivien@planete-kraus.eu> writes:
> * gnu/packages/gnome.scm (feedbackd): Update to 0.2.1.
> [#:phases]: Add 'unpack-gmobile.
> (inputs): Add gmobile.
> * gnu/packages/patches/feedbackd-use-system-gmobile.patch: New file.
[...]
> diff --git a/gnu/packages/patches/feedbackd-use-system-gmobile.patch b/gnu/packages/patches/feedbackd-use-system-gmobile.patch
> new file mode 100644
> index 0000000000..4dc3534a07
> --- /dev/null
> +++ b/gnu/packages/patches/feedbackd-use-system-gmobile.patch
> @@ -0,0 +1,39 @@
> +From 9a967f056379b0f024ceeff45fcb8889a3fe093e Mon Sep 17 00:00:00 2001
> +Message-ID: <9a967f056379b0f024ceeff45fcb8889a3fe093e.1698603600.git.vivien@planete-kraus.eu>
> +From: Vivien Kraus <vivien@planete-kraus.eu>
> +Date: Sun, 29 Oct 2023 19:12:27 +0100
> +Subject: [PATCH] Use a system-installed gmodule.
> +
> +* meson.build (gmobile_subp): Remove.
> +(gmobile): Make it a pkg-config dependency.
> +---
> + meson.build | 8 +-------
> + subprojects/gmobile/.empty | 0
> + 2 files changed, 1 insertion(+), 7 deletions(-)
> + delete mode 100644 subprojects/gmobile/.empty
> +
> +diff --git a/meson.build b/meson.build
> +index 8725e76..347ded1 100644
> +--- a/meson.build
> ++++ b/meson.build
> +@@ -14,13 +14,7 @@ gio_unix = dependency('gio-unix-2.0', version: '>=2.50.0')
> + glib = dependency('glib-2.0', version: '>=2.50.0')
> + if get_option('daemon')
> + gobject = dependency('gobject-2.0', version: '>=2.50.0')
> +- gmobile_subp = subproject('gmobile',
> +- default_options: [
> +- 'examples=false',
> +- 'gtk_doc=false',
> +- 'tests=false',
> +- ])
> +- gmobile = gmobile_subp.get_variable('gmobile_dep')
> ++ gmobile = dependency('gmobile')
There is a better way to accomplish the above, documented at [0].
Implemented as such, I think upstream would probably be interested in
merging it as-is, which we should do (forward the patch). The
alternative is maintaining custom patches ad vitam aeternam, which is a
lot of work :-).
[0] https://mesonbuild.com/Subprojects.html#toggling-between-system-libraries-and-embedded-sources
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-10-31 14:39 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 16:44 [bug#66823] [PATCH gnome-team 0/4] Add GNOME Calls Vivien Kraus via Guix-patches via
2023-10-29 11:04 ` [bug#66823] [PATCH gnome-team 4/4] gnu: Add calls Vivien Kraus via Guix-patches via
2023-10-29 17:09 ` Liliana Marie Prikler
2023-10-31 14:21 ` Maxim Cournoyer
2023-10-29 16:32 ` [bug#66823] [PATCH gnome-team 1/4] gnu: feedbackd: Update to 0.2.1 Vivien Kraus via Guix-patches via
2023-10-29 17:10 ` Liliana Marie Prikler
2023-10-31 13:54 ` Maxim Cournoyer
2023-10-29 16:34 ` [bug#66823] [PATCH gnome-team 2/4] gnu: Add sofia-sip Vivien Kraus via Guix-patches via
2023-10-29 17:13 ` Liliana Marie Prikler
2023-10-31 14:00 ` Maxim Cournoyer
2023-10-29 16:36 ` [bug#66823] [PATCH gnome-team 3/4] gnu: Add libcallaudio Vivien Kraus via Guix-patches via
2023-10-31 14:02 ` Maxim Cournoyer
2023-10-29 20:15 ` [bug#66823] [PATCH gnome-team v2 0/6] Add GNOME Calls, slightly better Vivien Kraus via Guix-patches via
2023-10-29 11:04 ` [bug#66823] [PATCH gnome-team v2 6/6] gnu: Add calls Vivien Kraus via Guix-patches via
2023-10-31 14:43 ` Maxim Cournoyer
2023-10-29 16:32 ` [bug#66823] [PATCH gnome-team v2 2/6] gnu: feedbackd: Update to 0.2.1 Vivien Kraus via Guix-patches via
2023-10-31 14:38 ` Maxim Cournoyer [this message]
2023-10-29 16:34 ` [bug#66823] [PATCH gnome-team v2 3/6] gnu: Add sofia-sip Vivien Kraus via Guix-patches via
2023-10-29 16:36 ` [bug#66823] [PATCH gnome-team v2 4/6] gnu: Add libcallaudio Vivien Kraus via Guix-patches via
2023-10-29 18:34 ` [bug#66823] [PATCH gnome-team v2 1/6] gnu: Add gmobile Vivien Kraus via Guix-patches via
2023-10-31 14:30 ` Maxim Cournoyer
2023-10-29 19:05 ` [bug#66823] [PATCH gnome-team v2 5/6] gnu: Add libcall-ui Vivien Kraus via Guix-patches via
2023-10-31 14:40 ` Maxim Cournoyer
2023-10-31 19:36 ` [bug#66823] [PATCH gnome-team v3 0/6] Add Calls, and inform upstreams Vivien Kraus via Guix-patches via
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v3 1/6] gnu: Add gmobile Vivien Kraus via Guix-patches via
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v3 2/6] gnu: feedbackd: Update to 0.2.1 Vivien Kraus via Guix-patches via
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v3 3/6] gnu: Add sofia-sip Vivien Kraus via Guix-patches via
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v3 4/6] gnu: Add libcallaudio Vivien Kraus via Guix-patches via
2023-10-31 19:35 ` [bug#66823] [PATCH gnome-team v3 5/6] gnu: Add libcall-ui Vivien Kraus via Guix-patches via
2023-10-31 19:35 ` [bug#66823] [PATCH gnome-team v3 6/6] gnu: Add calls Vivien Kraus via Guix-patches via
2023-10-31 20:48 ` [bug#66823] [PATCH gnome-team v4 0/6] Add Calls Vivien Kraus via Guix-patches via
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v4 1/6] gnu: Add gmobile Vivien Kraus via Guix-patches via
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v4 2/6] gnu: feedbackd: Update to 0.2.1 Vivien Kraus via Guix-patches via
2023-11-01 3:06 ` Maxim Cournoyer
2023-11-01 11:44 ` Liliana Marie Prikler
2023-11-01 15:30 ` Vivien Kraus via Guix-patches via
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v4 3/6] gnu: Add sofia-sip Vivien Kraus via Guix-patches via
2023-11-01 3:09 ` Maxim Cournoyer
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v4 4/6] gnu: Add libcallaudio Vivien Kraus via Guix-patches via
2023-10-31 19:35 ` [bug#66823] [PATCH gnome-team v4 5/6] gnu: Add libcall-ui Vivien Kraus via Guix-patches via
2023-10-31 19:35 ` [bug#66823] [PATCH gnome-team v4 6/6] gnu: Add calls Vivien Kraus via Guix-patches via
2023-11-01 3:15 ` Maxim Cournoyer
2023-11-01 15:32 ` Vivien Kraus via Guix-patches via
2023-11-01 19:26 ` Maxim Cournoyer
2023-11-02 17:07 ` [bug#66823] [PATCH gnome-team v5 0/6] Waiting for Purism Vivien Kraus via Guix-patches via
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v5 1/6] gnu: Add gmobile Vivien Kraus via Guix-patches via
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v5 2/6] [WIP] gnu: feedbackd: Update to 0.2.1 Vivien Kraus via Guix-patches via
2023-11-02 18:08 ` Liliana Marie Prikler
2023-11-07 15:45 ` Maxim Cournoyer
2023-11-07 16:54 ` Liliana Marie Prikler
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v5 3/6] gnu: Add sofia-sip Vivien Kraus via Guix-patches via
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v5 4/6] gnu: Add libcallaudio Vivien Kraus via Guix-patches via
2023-10-31 19:35 ` [bug#66823] [PATCH gnome-team v5 5/6] gnu: Add libcall-ui Vivien Kraus via Guix-patches via
2023-10-31 19:35 ` [bug#66823] [PATCH gnome-team v5 6/6] gnu: Add calls Vivien Kraus via Guix-patches via
2023-11-02 18:11 ` [bug#66823] [PATCH gnome-team v5 0/6] Waiting for Purism Liliana Marie Prikler
2023-11-04 7:01 ` bug#66823: " Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7gesvpo.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=66823@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
--cc=rg@raghavgururajan.name \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).