From: Mehmet Tekman <mtekman89@gmail.com>
To: 67343@debbugs.gnu.org
Subject: [bug#67343] [PATCH] Add fftw-cmake
Date: Mon, 27 Nov 2023 23:59:53 +0100 [thread overview]
Message-ID: <87o7feyf86.fsf@gmail.com> (raw)
In-Reply-To: <87o7fmu8or.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 300 bytes --]
After talking with <futurile> via irc[0], it was explained to me that I can
inherit an existing package decleration instead of cloning it.
0: https://logs.guix.gnu.org/guix/2023-11-27.log#151712
This is an update of the previous patch. Please use this patch instead
and ignore the previous one.
[-- Attachment #2: fftw3-cmake via inherit --]
[-- Type: text/x-patch, Size: 2149 bytes --]
From b4a6539391ae1a5e241d6398f8f33a5e63e890e1 Mon Sep 17 00:00:00 2001
From: Mehmet Tekman <mtekman89@gmail.com>
Date: Mon, 27 Nov 2023 23:38:32 +0100
Subject: [PATCH] * gnu/packages/algebra.scm (fftw-cmake): New variable
This is a clone of the fftw function, but uses cmake to build in order for
the FFTW3LibraryDepends.cmake file to be built, neccesary for packages with
cmake builds that depend on fftw3.
See: https://bugzilla.redhat.com/show_bug.cgi?id=1729652#c5
This variable is cloned from the existing fftw3 in order to not break any
downstream packages that make use of the target optimizations given by the
gnu build.
Change-Id: I620d00d980421bc063c325718e0cafc4ae23e57e
---
gnu/packages/algebra.scm | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm
index c0fe75ddfd..ecad6b2b21 100644
--- a/gnu/packages/algebra.scm
+++ b/gnu/packages/algebra.scm
@@ -15,6 +15,7 @@
;;; Copyright © 2020, 2021, 2023 Vinicius Monego <monego@posteo.net>
;;; Copyright © 2021 Lars-Dominik Braun <ldb@leibniz-psychology.org>
;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>
+;;; Copyright © 2023 Mehmet Tekman <mtekman89@gmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -733,6 +734,20 @@ (define-public kiss-fft-for-extempore
a C program.")
(license license:bsd-3)))
+(define-public fftw-cmake
+ (package/inherit fftw
+ ;; Cmake compiling is experimental since 2017, and it is not clear if this
+ ;; build has the same target-specific optimizations as the fftw gnu build.
+ ;; See: https://fftw.org/release-notes.html
+ (name "fftw-cmake")
+ (build-system cmake-build-system)
+ (arguments (default-keyword-arguments '()
+ '()))
+ (description (string-append (package-description fftw)
+ " This CMake build offers the file
+FFTW3LibraryDepends.cmake required by some dependent packages, absent in the
+gnu build version."))))
+
(define-public fftw
(package
(name "fftw")
--
2.41.0
next prev parent reply other threads:[~2023-11-27 23:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 20:56 [bug#67343] [PATCH] Add fftw-cmake Mehmet Tekman
2023-11-27 22:59 ` Mehmet Tekman [this message]
2023-11-28 13:06 ` Mehmet Tekman
2024-03-29 16:47 ` bug#67343: " Sharlatan Hellseher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7feyf86.fsf@gmail.com \
--to=mtekman89@gmail.com \
--cc=67343@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).